Github messages for voidlinux
 help / color / mirror / Atom feed
From: reedts <reedts@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] qmk: update to 1.0.0.
Date: Mon, 30 Aug 2021 21:56:10 +0200	[thread overview]
Message-ID: <20210830195610._V8Wr0uiZy-NxAb8NLVnLFP-_UugaBR7nzI7sHm9IAQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32685@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

New review comment by reedts on void-packages repository

https://github.com/void-linux/void-packages/pull/32685#discussion_r698766057

Comment:
Thank you for calling my attention on that `milc`-module. I just build this qmk package on another machine and noticed the same. Turns out that on my main system I obviously had qmk 1.0.0 installed via `pip`, so that milc was still installed.

This is however indeed a problem with regards to this PR. I could however just also make a PR for `python3-milc`. Shouldn't be to hard and wouldn't harm anyway, right?

What's your opinion on how to proceed? Should we even include this package in the repo, or just make all users install it via pip in the future? In this case, we should however remove the current `qmk` package in this repo, since it has not been compatible with the qmk firmware for quite some time...

Cheers

  parent reply	other threads:[~2021-08-30 19:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 11:33 [PR PATCH] " reedts
2021-08-30 18:07 ` [PR REVIEW] " Chocimier
2021-08-30 18:35 ` [PR PATCH] [Updated] " reedts
2021-08-30 18:39 ` reedts
2021-08-30 18:41 ` reedts
2021-08-30 18:43 ` [PR REVIEW] " reedts
2021-08-30 19:30 ` Chocimier
2021-08-30 19:56 ` reedts [this message]
2021-08-30 19:57 ` reedts
2021-08-30 20:03 ` Chocimier
2022-03-12 22:38 ` [PR PATCH] [Closed]: " Johnnynator
2022-03-12 22:38 ` Johnnynator
2022-01-14 22:44 [PR PATCH] " ifreund
2022-01-15 10:36 ` [PR REVIEW] " paper42
2022-01-15 10:36 ` paper42
2022-01-15 10:36 ` paper42
2022-01-15 10:36 ` paper42
2022-01-15 11:28 ` ifreund
2022-01-15 11:28 ` ifreund
2022-01-15 11:30 ` ifreund
2022-01-15 12:53 ` ifreund
2022-01-20  0:53 ` paper42
2022-01-20  0:53 ` paper42
2022-01-20  0:53 ` paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830195610._V8Wr0uiZy-NxAb8NLVnLFP-_UugaBR7nzI7sHm9IAQ@z \
    --to=reedts@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).