[PR PATCH] volctl depends on pulsectl since v0.9.0

[PR PATCH] volctl depends on pulsectl since v0.9.0

[jpastuszek]

[-- Attachment #1: Type: text/plain, Size: 3905 bytes --]

There is a new pull request by jpastuszek against master on the void-packages repository

https://github.com/jpastuszek/void-packages volctl
https://github.com/void-linux/void-packages/pull/32773

volctl depends on pulsectl since v0.9.0
https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I was getting this errors after update (for a while now):

```
2021-08-31_16:33:52.93948 ModuleNotFoundError: No module named 'pulsectl'
2021-08-31_16:33:54.25495 Traceback (most recent call last):
2021-08-31_16:33:54.25499   File "/bin/volctl", line 33, in <module>
2021-08-31_16:33:54.25513     sys.exit(load_entry_point('volctl==0.9.0', 'gui_scripts', 'volctl')())
2021-08-31_16:33:54.25515   File "/bin/volctl", line 25, in importlib_load_entry_point
2021-08-31_16:33:54.25526     return next(matches).load()
2021-08-31_16:33:54.25527   File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
2021-08-31_16:33:54.25540     module = import_module(match.group('module'))
2021-08-31_16:33:54.25542   File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
2021-08-31_16:33:54.25557     return _bootstrap._gcd_import(name[level:], package, level)
2021-08-31_16:33:54.25559   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
2021-08-31_16:33:54.25572   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
2021-08-31_16:33:54.25583   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
2021-08-31_16:33:54.25595   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
2021-08-31_16:33:54.25607   File "<frozen importlib._bootstrap_external>", line 850, in exec_module
2021-08-31_16:33:54.25619   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
2021-08-31_16:33:54.25630   File "/usr/lib/python3.9/site-packages/volctl/__main__.py", line 12, in <module>
2021-08-31_16:33:54.25640     from volctl.app import VolctlApp
2021-08-31_16:33:54.25642   File "/usr/lib/python3.9/site-packages/volctl/app.py", line 19, in <module>
2021-08-31_16:33:54.25654     from volctl.pulsemgr import PulseManager
2021-08-31_16:33:54.25655   File "/usr/lib/python3.9/site-packages/volctl/pulsemgr.py", line 7, in <module>
2021-08-31_16:33:54.25664     from pulsectl import (
```

Installing `python3-pulsectl` fixes the issue.
Looks like for v0.9.0 the developer started depending on this Python package:

https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167


A patch file from https://github.com/void-linux/void-packages/pull/32773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-volctl-32773.patch --]
[-- Type: text/x-diff, Size: 1054 bytes --]

From 75f021288c91cad53f87841d4eb6159db6021ffd Mon Sep 17 00:00:00 2001
From: Jakub Pastuszek <jpastuszek@protonmail.com>
Date: Tue, 31 Aug 2021 17:42:36 +0100
Subject: [PATCH] volctl depends on pulsectl since v0.9.0

https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167
---
 srcpkgs/volctl/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 73e735257f72..3ea354de5f50 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,10 +1,10 @@
 # Template file for 'volctl'
 pkgname=volctl
 version=0.9.0
-revision=1
+revision=2
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
+depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click python3-pulsectl"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"

Re: [PR REVIEW] volctl depends on pulsectl since v0.9.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32773#discussion_r699653212

Comment:
It sounds like we don't need click and yaml now, could you verify that?

Re: [PR REVIEW] volctl depends on pulsectl since v0.9.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32773#discussion_r699653212

Comment:
It sounds like we don't need python3-click and python3-yaml now, could you verify that?

Re: [PR PATCH] [Updated] volctl depends on pulsectl since v0.9.0

[jpastuszek]

[-- Attachment #1: Type: text/plain, Size: 3910 bytes --]

There is an updated pull request by jpastuszek against master on the void-packages repository

https://github.com/jpastuszek/void-packages volctl
https://github.com/void-linux/void-packages/pull/32773

volctl depends on pulsectl since v0.9.0
https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I was getting this errors after update (for a while now):

```
2021-08-31_16:33:52.93948 ModuleNotFoundError: No module named 'pulsectl'
2021-08-31_16:33:54.25495 Traceback (most recent call last):
2021-08-31_16:33:54.25499   File "/bin/volctl", line 33, in <module>
2021-08-31_16:33:54.25513     sys.exit(load_entry_point('volctl==0.9.0', 'gui_scripts', 'volctl')())
2021-08-31_16:33:54.25515   File "/bin/volctl", line 25, in importlib_load_entry_point
2021-08-31_16:33:54.25526     return next(matches).load()
2021-08-31_16:33:54.25527   File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
2021-08-31_16:33:54.25540     module = import_module(match.group('module'))
2021-08-31_16:33:54.25542   File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
2021-08-31_16:33:54.25557     return _bootstrap._gcd_import(name[level:], package, level)
2021-08-31_16:33:54.25559   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
2021-08-31_16:33:54.25572   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
2021-08-31_16:33:54.25583   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
2021-08-31_16:33:54.25595   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
2021-08-31_16:33:54.25607   File "<frozen importlib._bootstrap_external>", line 850, in exec_module
2021-08-31_16:33:54.25619   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
2021-08-31_16:33:54.25630   File "/usr/lib/python3.9/site-packages/volctl/__main__.py", line 12, in <module>
2021-08-31_16:33:54.25640     from volctl.app import VolctlApp
2021-08-31_16:33:54.25642   File "/usr/lib/python3.9/site-packages/volctl/app.py", line 19, in <module>
2021-08-31_16:33:54.25654     from volctl.pulsemgr import PulseManager
2021-08-31_16:33:54.25655   File "/usr/lib/python3.9/site-packages/volctl/pulsemgr.py", line 7, in <module>
2021-08-31_16:33:54.25664     from pulsectl import (
```

Installing `python3-pulsectl` fixes the issue.
Looks like for v0.9.0 the developer started depending on this Python package:

https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167


A patch file from https://github.com/void-linux/void-packages/pull/32773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-volctl-32773.patch --]
[-- Type: text/x-diff, Size: 1974 bytes --]

From 75f021288c91cad53f87841d4eb6159db6021ffd Mon Sep 17 00:00:00 2001
From: Jakub Pastuszek <jpastuszek@protonmail.com>
Date: Tue, 31 Aug 2021 17:42:36 +0100
Subject: [PATCH 1/2] volctl depends on pulsectl since v0.9.0

https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167
---
 srcpkgs/volctl/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 73e735257f72..3ea354de5f50 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -1,10 +1,10 @@
 # Template file for 'volctl'
 pkgname=volctl
 version=0.9.0
-revision=1
+revision=2
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click"
+depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click python3-pulsectl"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"

From c7219a3854c5f23ba89379a795b7f32d22041f2c Mon Sep 17 00:00:00 2001
From: Jakub Pastuszek <jpastuszek@protonmail.com>
Date: Wed, 1 Sep 2021 17:54:58 +0100
Subject: [PATCH 2/2] Removed python3-yaml and python3-click dependencies

---
 srcpkgs/volctl/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/volctl/template b/srcpkgs/volctl/template
index 3ea354de5f50..43ea4491d52a 100644
--- a/srcpkgs/volctl/template
+++ b/srcpkgs/volctl/template
@@ -4,7 +4,7 @@ version=0.9.0
 revision=2
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-yaml python3-click python3-pulsectl"
+depends="python3-gobject gtk+3 desktop-file-utils python3-cairo python3-pulsectl"
 short_desc="Lightweight volume control for pulseaudio in your systray"
 maintainer="teldra <teldra@rotce.de>"
 license="GPL-2.0-only"

Re: volctl depends on pulsectl since v0.9.0

[jpastuszek]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by jpastuszek on void-packages repository

https://github.com/void-linux/void-packages/pull/32773#issuecomment-910472174

Comment:
Yeah, good point, it works fine without this dependencies.

Re: volctl depends on pulsectl since v0.9.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32773#issuecomment-910489646

Comment:
> Yeah, good point, it works fine without this dependencies.

Thank you for noticing this.

Re: volctl depends on pulsectl since v0.9.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32773#issuecomment-910489646

Comment:
Thank you for noticing this.

Re: [PR PATCH] [Merged]: volctl depends on pulsectl since v0.9.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 3749 bytes --]

There's a merged pull request on the void-packages repository

volctl depends on pulsectl since v0.9.0
https://github.com/void-linux/void-packages/pull/32773

Description:
https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I was getting this errors after update (for a while now):

```
2021-08-31_16:33:52.93948 ModuleNotFoundError: No module named 'pulsectl'
2021-08-31_16:33:54.25495 Traceback (most recent call last):
2021-08-31_16:33:54.25499   File "/bin/volctl", line 33, in <module>
2021-08-31_16:33:54.25513     sys.exit(load_entry_point('volctl==0.9.0', 'gui_scripts', 'volctl')())
2021-08-31_16:33:54.25515   File "/bin/volctl", line 25, in importlib_load_entry_point
2021-08-31_16:33:54.25526     return next(matches).load()
2021-08-31_16:33:54.25527   File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
2021-08-31_16:33:54.25540     module = import_module(match.group('module'))
2021-08-31_16:33:54.25542   File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
2021-08-31_16:33:54.25557     return _bootstrap._gcd_import(name[level:], package, level)
2021-08-31_16:33:54.25559   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
2021-08-31_16:33:54.25572   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
2021-08-31_16:33:54.25583   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
2021-08-31_16:33:54.25595   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
2021-08-31_16:33:54.25607   File "<frozen importlib._bootstrap_external>", line 850, in exec_module
2021-08-31_16:33:54.25619   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
2021-08-31_16:33:54.25630   File "/usr/lib/python3.9/site-packages/volctl/__main__.py", line 12, in <module>
2021-08-31_16:33:54.25640     from volctl.app import VolctlApp
2021-08-31_16:33:54.25642   File "/usr/lib/python3.9/site-packages/volctl/app.py", line 19, in <module>
2021-08-31_16:33:54.25654     from volctl.pulsemgr import PulseManager
2021-08-31_16:33:54.25655   File "/usr/lib/python3.9/site-packages/volctl/pulsemgr.py", line 7, in <module>
2021-08-31_16:33:54.25664     from pulsectl import (
```

Installing `python3-pulsectl` fixes the issue.
Looks like for v0.9.0 the developer started depending on this Python package:

https://github.com/buzz/volctl/commit/ef7fa2386f9a793b65027f727cbd068e8a2d9167

Re: volctl depends on pulsectl since v0.9.0

[jpastuszek]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by jpastuszek on void-packages repository

https://github.com/void-linux/void-packages/pull/32773#issuecomment-910472174

Comment:
Yeah, good point, it works fine without these dependencies.

Re: volctl depends on pulsectl since v0.9.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32773#issuecomment-910492109

Comment:
one commit for one package next time, the commits should have been squashed