Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: imagescan: update to 3.65.0.
Date: Sun, 05 Sep 2021 20:54:58 +0200	[thread overview]
Message-ID: <20210905185458.qBxX4YYJK3ryGNwrzeLLlaPJ7B29zeUyyKRisT_IHgY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32825@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/32825#issuecomment-913206369

Comment:
Welp, didn't think to check before I bumped `imagescan` on my own. I'm in the same boat as you; I just bought an Epson all-in-one printer today and wanted to get scanning working on Void.

In general I agree with @ericonr that these patches are too extensive to support in Void without pushing them upstream. Also, the `tesseract-ocr` dependency really ought to be optional, and if it requires build-time support, then it probably ought to be a non-default option.

I also agree that an `INSTALL.msg` isn't desirable to fix documentation issues. I was able to get my network scanner working in this fashion with a quick web search, so I don't think it merits special attention here. Patching the configuration path in any documentation we ship would be OK, but since our `imagescan` only ships a single `conf_file` at `/etc/utsushi/utsushi.conf`, it's not difficult to make the leap.

Because our `imagescan` is not at `3.65.0` and your changes there amount to modifying some default configuration and dependency options that merit discussion, please move the `imagescan-plugin-networkscan` changes to a separate PR.

  parent reply	other threads:[~2021-09-05 18:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 20:54 [PR PATCH] " jbenden
2021-09-04  7:44 ` [PR PATCH] [Updated] " jbenden
2021-09-04 20:25 ` jbenden
2021-09-04 21:29 ` jbenden
2021-09-04 21:30 ` jbenden
2021-09-05 18:43 ` [PR REVIEW] " ericonr
2021-09-05 18:43 ` ericonr
2021-09-05 18:51 ` jbenden
2021-09-05 18:53 ` [PR REVIEW] " jbenden
2021-09-05 18:54 ` ahesford [this message]
2021-09-05 19:01 ` jbenden
2021-09-05 19:03 ` jbenden
2021-09-05 19:03 ` [PR PATCH] [Closed]: " jbenden
2021-09-05 20:00 ` ahesford
2021-09-05 20:10 ` jbenden
2021-09-05 20:15 ` ahesford
2021-09-05 21:32 ` jbenden
2021-09-05 21:34 ` jbenden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210905185458.qBxX4YYJK3ryGNwrzeLLlaPJ7B29zeUyyKRisT_IHgY@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).