From: AviKav <AviKav@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] oil: bring package contents more inline with the project's install script
Date: Mon, 06 Sep 2021 04:29:55 +0200 [thread overview]
Message-ID: <20210906022955.1Zb0jlUljVNlXUCWLyWPUF6OsPDLLZ7Moa9IQsHhNWs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32850@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
There is an updated pull request by AviKav against master on the void-packages repository
https://github.com/AviKav/void-packages oil
https://github.com/void-linux/void-packages/pull/32850
oil: bring package contents more inline with the project's install script
Add `oil` symlink as well as man page
Project no longer bothers to symlink `oshc` (seems to be incomplete/broken)
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
A patch file from https://github.com/void-linux/void-packages/pull/32850.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-oil-32850.patch --]
[-- Type: text/x-diff, Size: 1470 bytes --]
From 5cef434f829e98b5891137033b6f18bf687d2871 Mon Sep 17 00:00:00 2001
From: AviKav <avikav@avikav.net>
Date: Sun, 5 Sep 2021 16:53:29 -0400
Subject: [PATCH] oil: bring package contents more inline with the project's
install script
include man page
add oil as a command and as a shell
remove oshc as the projects's own install script no longer installs it
---
srcpkgs/oil/template | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index 09b496a6d3b1..934607a92a1e 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,7 +1,7 @@
# Template file for 'oil'
pkgname=oil
version=0.9.0
-revision=1
+revision=2
build_style=configure
configure_args="--prefix=/usr $(vopt_with readline)"
hostmakedepends="$(vopt_if readline readline-devel)"
@@ -12,7 +12,7 @@ license="Apache-2.0"
homepage="https://www.oilshell.org"
distfiles="${homepage}/download/${pkgname}-${version}.tar.xz"
checksum=c64e22a3665756ea54ea60aa983f7893501a13c2a4d1c7f73c8c76f17ea03636
-register_shell="/usr/bin/osh"
+register_shell="/usr/bin/osh /usr/bin/oil"
nocross="Build systems gets confused with host and cross toolchains/headers"
nostrip=yes
@@ -27,8 +27,9 @@ pre_build() {
do_install() {
# Install binaries
vbin _bin/oil.ovm
- # Symlink osh, oshc to oil.ovm.
+ vman doc/osh.1
+ # Symlink osh, oil to oil.ovm.
cd "${DESTDIR}"/usr/bin
ln -s oil.ovm osh
- ln -s oil.ovm oshc
+ ln -s oil.ovm oil
}
next prev parent reply other threads:[~2021-09-06 2:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 23:03 [PR PATCH] " AviKav
2021-09-05 23:23 ` [PR REVIEW] " Duncaen
2021-09-06 2:29 ` AviKav [this message]
2021-09-06 2:32 ` AviKav
2021-09-06 19:04 ` ericonr
2022-05-08 5:06 ` AviKav
2022-05-08 5:07 ` AviKav
2022-05-23 6:09 ` bugcrazy
2022-06-03 7:46 ` [PR PATCH] [Updated] " AviKav
2022-08-15 9:51 ` bugcrazy
2022-08-15 21:09 ` [PR PATCH] [Closed]: " AviKav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906022955.1Zb0jlUljVNlXUCWLyWPUF6OsPDLLZ7Moa9IQsHhNWs@z \
--to=avikav@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).