From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: fwudp: change deps and config
Date: Sat, 11 Sep 2021 21:44:57 +0200 [thread overview]
Message-ID: <20210911194457.6t5ZIrlaTs7tUWSXeYySNWUjtKMJ1nksDIrCo-TSijI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32932@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32932#issuecomment-917466982
Comment:
I think removing the configure arg is a bad idea. It might be default disabled later in life and we won't notice.
I'm not sure how best to deal with udisks2, will look into how the whole thing works (but I think the commit message should mention the rationale, like you did in the PR body). And yeah, it def needs dbus.
next prev parent reply other threads:[~2021-09-11 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 15:18 [PR PATCH] " dkwo
2021-09-11 19:44 ` ericonr [this message]
2021-09-12 6:30 ` [PR PATCH] [Updated] " dkwo
2021-09-15 7:36 ` fwupd: change deps dkwo
2021-09-16 1:27 ` ericonr
2021-09-16 11:35 ` [PR PATCH] [Updated] " dkwo
2021-09-16 11:58 ` dkwo
2021-09-16 18:53 ` ericonr
2021-09-16 19:30 ` [PR PATCH] [Updated] " dkwo
2021-09-16 19:31 ` dkwo
2021-10-07 8:24 ` [PR PATCH] [Updated] " dkwo
2021-10-07 8:36 ` dkwo
2021-11-09 12:22 ` dkwo
2021-11-09 19:39 ` [PR PATCH] [Merged]: " ericonr
2021-11-09 19:40 ` ericonr
2021-11-10 8:59 ` dkwo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210911194457.6t5ZIrlaTs7tUWSXeYySNWUjtKMJ1nksDIrCo-TSijI@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).