Github messages for voidlinux
 help / color / mirror / Atom feed
From: dkwo <dkwo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] fwudp: change deps and config
Date: Sun, 12 Sep 2021 08:30:05 +0200	[thread overview]
Message-ID: <20210912063005.jbOo3VxwELwdgDPdL1VnAB8EWZ6tGHa4pIyT4zgcZtk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32932@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages fwupd
https://github.com/void-linux/void-packages/pull/32932

fwudp: change deps and config
drop dep on udisks2, add dep on dbus
drop -Dintrospection=true, which is default
built and checked on x86_64-musl

udisks2 brings in a lot of bloat, just to discover the ESP partition, but it actually does not do the job,
so it would be simpler to just let the user take care of that. (That's also what Alpine does btw.)
Notice even with udisks, I currently have to do
`mount -t efivarfs efivarfs /sys/firmware/efi/efivars`
otherwise fwupd does not find the bios to update.
Instead, dbus seems to be a needed dependency.

A patch file from https://github.com/void-linux/void-packages/pull/32932.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fwupd-32932.patch --]
[-- Type: text/x-diff, Size: 1377 bytes --]

From 6340a0cb500cb5b8fd51cbcec7026a5dd43be12c Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Sun, 12 Sep 2021 08:27:30 +0200
Subject: [PATCH] fwupd: change deps

udisks2 brings in a lot of bloat, just to discover the ESP partition,
but it actually does not do the job,
so it is simpler to let the user take care of that.
(That's also what Alpine does btw.)
Notice that even with udisks, I currently have to do
`mount -t efivarfs efivarfs /sys/firmware/efi/efivars'
otherwise fwupd does not find the bios to update.
Instead, dbus seems to be a needed dependency.
---
 srcpkgs/fwupd/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fwupd/template b/srcpkgs/fwupd/template
index afe369923922..ea1098368bef 100644
--- a/srcpkgs/fwupd/template
+++ b/srcpkgs/fwupd/template
@@ -1,7 +1,7 @@
 # Template file for 'fwupd'
 pkgname=fwupd
 version=1.6.3
-revision=1
+revision=2
 build_style=meson
 build_helper="gir"
 # tests require unpackaged umockdev
@@ -13,7 +13,7 @@ makedepends="libxmlb-devel cairo-devel colord-devel libarchive-devel
  gnutls-devel gpgme-devel json-glib-devel libgusb-devel polkit-devel
  sqlite-devel libsoup-devel gcab-devel pango-devel elogind-devel
  tpm2-tss-devel libjcat-devel libcurl-devel"
-depends="udisks2"
+depends="dbus"
 conf_files="
  /etc/fwupd/*.conf
  /etc/fwupd/remotes.d/*.conf"

  parent reply	other threads:[~2021-09-12  6:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11 15:18 [PR PATCH] " dkwo
2021-09-11 19:44 ` ericonr
2021-09-12  6:30 ` dkwo [this message]
2021-09-15  7:36 ` fwupd: change deps dkwo
2021-09-16  1:27 ` ericonr
2021-09-16 11:35 ` [PR PATCH] [Updated] " dkwo
2021-09-16 11:58 ` dkwo
2021-09-16 18:53 ` ericonr
2021-09-16 19:30 ` [PR PATCH] [Updated] " dkwo
2021-09-16 19:31 ` dkwo
2021-10-07  8:24 ` [PR PATCH] [Updated] " dkwo
2021-10-07  8:36 ` dkwo
2021-11-09 12:22 ` dkwo
2021-11-09 19:39 ` [PR PATCH] [Merged]: " ericonr
2021-11-09 19:40 ` ericonr
2021-11-10  8:59 ` dkwo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210912063005.jbOo3VxwELwdgDPdL1VnAB8EWZ6tGHa4pIyT4zgcZtk@z \
    --to=dkwo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).