[-- Attachment #1: Type: text/plain, Size: 1598 bytes --] There is a new pull request by mobinmob against master on the void-packages repository https://github.com/mobinmob/void-packages gptfdisk https://github.com/void-linux/void-packages/pull/32907 gptfdisk: update to 1.0.8. <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [X] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [X] I built this PR locally for my native architecture, (x86_64-glibc) - [X] I built this PR locally for these architectures (if supported. mark crossbuilds): - [X] aarch64-musl (crossbuild) - [X] x86_64-musl (crossbuild) A patch file from https://github.com/void-linux/void-packages/pull/32907.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-gptfdisk-32907.patch --] [-- Type: text/x-diff, Size: 1084 bytes --] From 6edd5fe79aef2fc6bc4370d46a56ac7fa06744f3 Mon Sep 17 00:00:00 2001 From: mobinmob <mobinmob@disroot.org> Date: Fri, 10 Sep 2021 19:16:16 +0300 Subject: [PATCH] gptfdisk: update to 1.0.8. --- srcpkgs/gptfdisk/template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/srcpkgs/gptfdisk/template b/srcpkgs/gptfdisk/template index e3b764911947..fdb843f75ead 100644 --- a/srcpkgs/gptfdisk/template +++ b/srcpkgs/gptfdisk/template @@ -1,6 +1,6 @@ # Template file for 'gptfdisk' pkgname=gptfdisk -version=1.0.6 +version=1.0.8 revision=1 build_style=gnu-makefile makedepends="ncurses-devel popt-devel icu-devel libuuid-devel" @@ -9,7 +9,7 @@ maintainer="Orphaned <orphan@voidlinux.org>" license="GPL-2.0-or-later" homepage="http://www.rodsbooks.com/gdisk/" distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz" -checksum=ddc551d643a53f0bd4440345d3ae32c49b04a797e9c01036ea460b6bb4168ca8 +checksum=95d19856f004dabc4b8c342b2612e8d0a9eebdd52004297188369f152e9dc6df pre_build() { sed -i 's#<ncursesw/ncurses.h>#<ncurses.h>#' gptcurses.cc
[-- Attachment #1: Type: text/plain, Size: 460 bytes --] New comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#issuecomment-917066536 Comment: I was taking a look at updating this, but you beat me to it :) I don't think the the icu dependency is necessary anymore, and it isn't used by default in the makefile anyways, so it can be safely removed. I had added `make_check_target=test` to have the checks work, and you could probably change `sed` to `vsed`
[-- Attachment #1: Type: text/plain, Size: 462 bytes --] New comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#issuecomment-917066536 Comment: I was taking a look at updating this also, but you were faster :) I don't think the the icu dependency is necessary anymore, and it isn't used by default in the makefile anyways, so it can be safely removed. I had added `make_check_target=test` to have the checks work, and you could probably change `sed` to `vsed`
[-- Attachment #1: Type: text/plain, Size: 221 bytes --] New review comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706348024 Comment: ```suggestion makedepends="ncurses-devel popt-devel libuuid-devel" ```
[-- Attachment #1: Type: text/plain, Size: 228 bytes --] New review comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706348203 Comment: ```suggestion vsed -i 's#<ncursesw/ncurses.h>#<ncurses.h>#' gptcurses.cc ```
[-- Attachment #1: Type: text/plain, Size: 272 bytes --] New review comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706349832 Comment: The icu dependency can be safely removed. It looks like it is optional and not enabled by default in the Makefile anyways.
[-- Attachment #1: Type: text/plain, Size: 217 bytes --] New review comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706348520 Comment: ```suggestion build_style=gnu-makefile make_check_target=test ```
[-- Attachment #1: Type: text/plain, Size: 158 bytes --] New review comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706350222 Comment: sed->vsed
[-- Attachment #1: Type: text/plain, Size: 195 bytes --] New review comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706350118 Comment: Just a suggestion if you want to run the tests
[-- Attachment #1: Type: text/plain, Size: 462 bytes --] New comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#issuecomment-917066536 Comment: I was taking a look at updating this also, but you were faster :) I don't think the the icu dependency is necessary anymore, and it isn't used by default in the makefile anyways, so it can be safely removed. I had added `make_check_target=test` to have the checks work, and you could probably change `sed` to `vsed`
[-- Attachment #1: Type: text/plain, Size: 262 bytes --] New comment by mtboehlke on void-packages repository https://github.com/void-linux/void-packages/pull/32907#issuecomment-917092641 Comment: I just left a couple of hopefully helpful reviews. I had taken a look at updating this one too, but you were faster :)
[-- Attachment #1: Type: text/plain, Size: 1603 bytes --] There is an updated pull request by mobinmob against master on the void-packages repository https://github.com/mobinmob/void-packages gptfdisk https://github.com/void-linux/void-packages/pull/32907 gptfdisk: update to 1.0.8. <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [X] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [X] I built this PR locally for my native architecture, (x86_64-glibc) - [X] I built this PR locally for these architectures (if supported. mark crossbuilds): - [X] aarch64-musl (crossbuild) - [X] x86_64-musl (crossbuild) A patch file from https://github.com/void-linux/void-packages/pull/32907.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-gptfdisk-32907.patch --] [-- Type: text/x-diff, Size: 1458 bytes --] From 3af24f10b1b7725350ae600694a2353fdd2eab40 Mon Sep 17 00:00:00 2001 From: mobinmob <mobinmob@disroot.org> Date: Fri, 10 Sep 2021 19:16:16 +0300 Subject: [PATCH] gptfdisk: update to 1.0.8. Also: - remove icu-devel (no longer needed) - add make_check_target=test to enable tests - use vsed instead of sed. All the improvements were contributed by @mtboehlke . --- srcpkgs/gptfdisk/template | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/srcpkgs/gptfdisk/template b/srcpkgs/gptfdisk/template index e3b764911947..c1278f5d47db 100644 --- a/srcpkgs/gptfdisk/template +++ b/srcpkgs/gptfdisk/template @@ -1,18 +1,19 @@ # Template file for 'gptfdisk' pkgname=gptfdisk -version=1.0.6 +version=1.0.8 revision=1 build_style=gnu-makefile -makedepends="ncurses-devel popt-devel icu-devel libuuid-devel" +make_check_target=test +makedepends="ncurses-devel popt-devel libuuid-devel" short_desc="GPT fdisk text-mode partitioning tool" maintainer="Orphaned <orphan@voidlinux.org>" license="GPL-2.0-or-later" homepage="http://www.rodsbooks.com/gdisk/" distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz" -checksum=ddc551d643a53f0bd4440345d3ae32c49b04a797e9c01036ea460b6bb4168ca8 +checksum=95d19856f004dabc4b8c342b2612e8d0a9eebdd52004297188369f152e9dc6df pre_build() { - sed -i 's#<ncursesw/ncurses.h>#<ncurses.h>#' gptcurses.cc + vsed -i 's#<ncursesw/ncurses.h>#<ncurses.h>#' gptcurses.cc } do_install() {
[-- Attachment #1: Type: text/plain, Size: 153 bytes --] New review comment by mobinmob on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706607520 Comment: Done.
[-- Attachment #1: Type: text/plain, Size: 153 bytes --] New review comment by mobinmob on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706607547 Comment: Done.
[-- Attachment #1: Type: text/plain, Size: 153 bytes --] New review comment by mobinmob on void-packages repository https://github.com/void-linux/void-packages/pull/32907#discussion_r706607557 Comment: Done.
[-- Attachment #1: Type: text/plain, Size: 201 bytes --] New comment by mobinmob on void-packages repository https://github.com/void-linux/void-packages/pull/32907#issuecomment-917399642 Comment: Thanks a lot @mtboehlke ! I added all your improvements :)
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --] There's a merged pull request on the void-packages repository gptfdisk: update to 1.0.8. https://github.com/void-linux/void-packages/pull/32907 Description: <!-- Mark items with [x] where applicable --> #### General - [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) #### Have the results of the proposed changes been tested? - [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me - [X] I generally don't use the affected packages but briefly tested this PR <!-- If GitHub CI cannot be used to validate the build result (for example, if the build is likely to take several hours), make sure to [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration). When skipping CI, uncomment and fill out the following section. Note: for builds that are likely to complete in less than 2 hours, it is not acceptable to skip CI. --> #### Does it build and run successfully? (Please choose at least one native build and, if supported, at least one cross build. More are better.) - [X] I built this PR locally for my native architecture, (x86_64-glibc) - [X] I built this PR locally for these architectures (if supported. mark crossbuilds): - [X] aarch64-musl (crossbuild) - [X] x86_64-musl (crossbuild)