Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libcdparanoia: byteswap null check
@ 2021-09-13 19:39 r-c-f
  2021-09-13 20:26 ` [PR PATCH] [Merged]: " q66
  0 siblings, 1 reply; 2+ messages in thread
From: r-c-f @ 2021-09-13 19:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

There is a new pull request by r-c-f against master on the void-packages repository

https://github.com/r-c-f/void-packages paranoia-be-fix
https://github.com/void-linux/void-packages/pull/32954

libcdparanoia: byteswap null check
From upstream r15356, fixes a segfault when attempting to read discs
on big-endian systems. 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ppc-musl)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [x] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/32954.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-paranoia-be-fix-32954.patch --]
[-- Type: text/x-diff, Size: 1661 bytes --]

From ca76b24b7dc60a537fd1212a440bdc79ccfbec17 Mon Sep 17 00:00:00 2001
From: Ryan Farley <ryan.farley@gmx.com>
Date: Wed, 21 Jul 2021 19:18:05 -0500
Subject: [PATCH] libcdparanoia: byteswap null check

From upstream r15356, fixes a segfault when attempting to read discs
---
 srcpkgs/cdparanoia/patches/byteswap-null-check.diff | 13 +++++++++++++
 srcpkgs/cdparanoia/template                         |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/cdparanoia/patches/byteswap-null-check.diff

diff --git a/srcpkgs/cdparanoia/patches/byteswap-null-check.diff b/srcpkgs/cdparanoia/patches/byteswap-null-check.diff
new file mode 100644
index 000000000000..77f61474a6a6
--- /dev/null
+++ b/srcpkgs/cdparanoia/patches/byteswap-null-check.diff
@@ -0,0 +1,13 @@
+Index: interface/interface.c
+===================================================================
+--- a/interface/interface.c	(revision 15338)
++++ b/interface/interface.c	(revision 15356)
+@@ -118,7 +118,7 @@
+ 	if(d->bigendianp==-1) /* not determined yet */
+ 	  d->bigendianp=data_bigendianp(d);
+ 	
+-	if(d->bigendianp!=bigendianp()){
++	if(buffer && d->bigendianp!=bigendianp()){
+ 	  int i;
+ 	  u_int16_t *p=(u_int16_t *)buffer;
+ 	  long els=sectors*CD_FRAMESIZE_RAW/2;
diff --git a/srcpkgs/cdparanoia/template b/srcpkgs/cdparanoia/template
index 3cf09587f215..3566b6a62e74 100644
--- a/srcpkgs/cdparanoia/template
+++ b/srcpkgs/cdparanoia/template
@@ -1,7 +1,7 @@
 # Template file for 'cdparanoia'
 pkgname=cdparanoia
 version=10.2
-revision=14
+revision=15
 wrksrc="${pkgname}-III-${version}"
 build_style=gnu-configure
 hostmakedepends="libtool automake"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: libcdparanoia: byteswap null check
  2021-09-13 19:39 [PR PATCH] libcdparanoia: byteswap null check r-c-f
@ 2021-09-13 20:26 ` q66
  0 siblings, 0 replies; 2+ messages in thread
From: q66 @ 2021-09-13 20:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

There's a merged pull request on the void-packages repository

libcdparanoia: byteswap null check
https://github.com/void-linux/void-packages/pull/32954

Description:
From upstream r15356, fixes a segfault when attempting to read discs
on big-endian systems. 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ppc-musl)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [x] armv7l
  - [ ] armv6l-musl


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-13 20:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 19:39 [PR PATCH] libcdparanoia: byteswap null check r-c-f
2021-09-13 20:26 ` [PR PATCH] [Merged]: " q66

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ https://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git