Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] httpie: update to 2.5.0.
@ 2021-09-10 13:24 BoboTiG
  2021-09-10 14:28 ` [PR REVIEW] " ericonr
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-10 13:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is a new pull request by BoboTiG against master on the void-packages repository

https://github.com/BoboTiG/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32905

httpie: update to 2.5.0.
None

A patch file from https://github.com/void-linux/void-packages/pull/32905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32905.patch --]
[-- Type: text/x-diff, Size: 1585 bytes --]

From 1316c82e54f478b30ffab8b5f324ec0003577cc0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Fri, 10 Sep 2021 15:23:00 +0200
Subject: [PATCH] httpie: update to 2.5.0.

---
 srcpkgs/httpie/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index 201e2af09b4e..3e3ba01fe6d2 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -1,17 +1,17 @@
 # Template file for 'httpie'
 pkgname=httpie
-version=2.2.0
-revision=2
+version=2.5.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-requests python3-Pygments"
+depends="python3-setuptools python3-requests python3-requests-toolbelt python3-pygments python3-socks python3-defusedxml"
 short_desc="Human-friendly command line HTTP client"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
 license="BSD-3-Clause"
-homepage="https://httpie.org/"
-changelog="https://raw.githubusercontent.com/jakubroztocil/httpie/master/CHANGELOG.rst"
-distfiles="https://github.com/jakubroztocil/httpie/archive/${version}.tar.gz"
-checksum=413894ad9d5d45a2a7839079dcdc0f23b0ea3586502d5014339b957de73d413e
+homepage="https://httpie.io/"
+changelog="https://raw.githubusercontent.com/httpie/httpie/master/CHANGELOG.md"
+distfiles="https://github.com/httpie/httpie/archive/${version}.tar.gz"
+checksum=66af56e0efc1ca6237323f1186ba34bca1be24e67a4319fd5df7228ab986faea
 
 post_install() {
 	vcompletion extras/httpie-completion.bash bash http

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
@ 2021-09-10 14:28 ` ericonr
  2021-09-10 14:28 ` ericonr
                   ` (21 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2021-09-10 14:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r706227322

Comment:
Please break at ~80 columns.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
  2021-09-10 14:28 ` [PR REVIEW] " ericonr
@ 2021-09-10 14:28 ` ericonr
  2021-09-10 14:32 ` [PR PATCH] [Updated] " BoboTiG
                   ` (20 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2021-09-10 14:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r706228305

Comment:
And `pygments` is wrong, `Pygments` was correct.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
  2021-09-10 14:28 ` [PR REVIEW] " ericonr
  2021-09-10 14:28 ` ericonr
@ 2021-09-10 14:32 ` BoboTiG
  2021-09-10 14:33 ` [PR REVIEW] " BoboTiG
                   ` (19 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-10 14:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

There is an updated pull request by BoboTiG against master on the void-packages repository

https://github.com/BoboTiG/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32905

httpie: update to 2.5.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32905.patch --]
[-- Type: text/x-diff, Size: 2558 bytes --]

From 1316c82e54f478b30ffab8b5f324ec0003577cc0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Fri, 10 Sep 2021 15:23:00 +0200
Subject: [PATCH 1/2] httpie: update to 2.5.0.

---
 srcpkgs/httpie/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index 201e2af09b4e..3e3ba01fe6d2 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -1,17 +1,17 @@
 # Template file for 'httpie'
 pkgname=httpie
-version=2.2.0
-revision=2
+version=2.5.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-requests python3-Pygments"
+depends="python3-setuptools python3-requests python3-requests-toolbelt python3-pygments python3-socks python3-defusedxml"
 short_desc="Human-friendly command line HTTP client"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
 license="BSD-3-Clause"
-homepage="https://httpie.org/"
-changelog="https://raw.githubusercontent.com/jakubroztocil/httpie/master/CHANGELOG.rst"
-distfiles="https://github.com/jakubroztocil/httpie/archive/${version}.tar.gz"
-checksum=413894ad9d5d45a2a7839079dcdc0f23b0ea3586502d5014339b957de73d413e
+homepage="https://httpie.io/"
+changelog="https://raw.githubusercontent.com/httpie/httpie/master/CHANGELOG.md"
+distfiles="https://github.com/httpie/httpie/archive/${version}.tar.gz"
+checksum=66af56e0efc1ca6237323f1186ba34bca1be24e67a4319fd5df7228ab986faea
 
 post_install() {
 	vcompletion extras/httpie-completion.bash bash http

From 398de0785f2eceeb44efd93fefe2a8d8f9714ff0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Fri, 10 Sep 2021 16:32:10 +0200
Subject: [PATCH 2/2] Fix Pygments name and break at 80 chars

---
 srcpkgs/httpie/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index 3e3ba01fe6d2..e2a02e0b595e 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -4,7 +4,8 @@ version=2.5.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-requests python3-requests-toolbelt python3-pygments python3-socks python3-defusedxml"
+depends="python3-setuptools python3-requests python3-requests-toolbelt
+ python3-Pygments python3-socks python3-defusedxml"
 short_desc="Human-friendly command line HTTP client"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
 license="BSD-3-Clause"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (2 preceding siblings ...)
  2021-09-10 14:32 ` [PR PATCH] [Updated] " BoboTiG
@ 2021-09-10 14:33 ` BoboTiG
  2021-09-10 15:56 ` BoboTiG
                   ` (18 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-10 14:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r706232673

Comment:
My bad. Thank you @ericonr this is now fixed.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (3 preceding siblings ...)
  2021-09-10 14:33 ` [PR REVIEW] " BoboTiG
@ 2021-09-10 15:56 ` BoboTiG
  2021-09-14  9:09 ` BoboTiG
                   ` (17 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-10 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r706232673

Comment:
My bad. Thank you @ericonr, this is now fixed.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (4 preceding siblings ...)
  2021-09-10 15:56 ` BoboTiG
@ 2021-09-14  9:09 ` BoboTiG
  2021-09-14  9:09 ` [PR PATCH] [Updated] " BoboTiG
                   ` (16 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-14  9:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r708071875

Comment:
```suggestion
hostmakedepends="python3-setuptools python3-pip python3-wheel"
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (5 preceding siblings ...)
  2021-09-14  9:09 ` BoboTiG
@ 2021-09-14  9:09 ` BoboTiG
  2021-09-14 12:26 ` [PR REVIEW] " ericonr
                   ` (15 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-14  9:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

There is an updated pull request by BoboTiG against master on the void-packages repository

https://github.com/BoboTiG/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32905

httpie: update to 2.5.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32905.patch --]
[-- Type: text/x-diff, Size: 3402 bytes --]

From 1316c82e54f478b30ffab8b5f324ec0003577cc0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Fri, 10 Sep 2021 15:23:00 +0200
Subject: [PATCH 1/3] httpie: update to 2.5.0.

---
 srcpkgs/httpie/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index 201e2af09b4e..3e3ba01fe6d2 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -1,17 +1,17 @@
 # Template file for 'httpie'
 pkgname=httpie
-version=2.2.0
-revision=2
+version=2.5.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-requests python3-Pygments"
+depends="python3-setuptools python3-requests python3-requests-toolbelt python3-pygments python3-socks python3-defusedxml"
 short_desc="Human-friendly command line HTTP client"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
 license="BSD-3-Clause"
-homepage="https://httpie.org/"
-changelog="https://raw.githubusercontent.com/jakubroztocil/httpie/master/CHANGELOG.rst"
-distfiles="https://github.com/jakubroztocil/httpie/archive/${version}.tar.gz"
-checksum=413894ad9d5d45a2a7839079dcdc0f23b0ea3586502d5014339b957de73d413e
+homepage="https://httpie.io/"
+changelog="https://raw.githubusercontent.com/httpie/httpie/master/CHANGELOG.md"
+distfiles="https://github.com/httpie/httpie/archive/${version}.tar.gz"
+checksum=66af56e0efc1ca6237323f1186ba34bca1be24e67a4319fd5df7228ab986faea
 
 post_install() {
 	vcompletion extras/httpie-completion.bash bash http

From 398de0785f2eceeb44efd93fefe2a8d8f9714ff0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Fri, 10 Sep 2021 16:32:10 +0200
Subject: [PATCH 2/3] Fix Pygments name and break at 80 chars

---
 srcpkgs/httpie/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index 3e3ba01fe6d2..e2a02e0b595e 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -4,7 +4,8 @@ version=2.5.0
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-requests python3-requests-toolbelt python3-pygments python3-socks python3-defusedxml"
+depends="python3-setuptools python3-requests python3-requests-toolbelt
+ python3-Pygments python3-socks python3-defusedxml"
 short_desc="Human-friendly command line HTTP client"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
 license="BSD-3-Clause"

From 6acab73eb4b5aab7c9ed0225061e73cedb93657b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Tue, 14 Sep 2021 11:09:55 +0200
Subject: [PATCH 3/3] Update srcpkgs/httpie/template

---
 srcpkgs/httpie/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index e2a02e0b595e..2e81a1b80db8 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -3,7 +3,7 @@ pkgname=httpie
 version=2.5.0
 revision=1
 build_style=python3-module
-hostmakedepends="python3-setuptools"
+hostmakedepends="python3-setuptools python3-pip python3-wheel"
 depends="python3-setuptools python3-requests python3-requests-toolbelt
  python3-Pygments python3-socks python3-defusedxml"
 short_desc="Human-friendly command line HTTP client"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (6 preceding siblings ...)
  2021-09-14  9:09 ` [PR PATCH] [Updated] " BoboTiG
@ 2021-09-14 12:26 ` ericonr
  2021-09-14 12:29 ` BoboTiG
                   ` (14 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: ericonr @ 2021-09-14 12:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r708215057

Comment:
Why are you bringing pip into this? System packages shouldn't use it

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (7 preceding siblings ...)
  2021-09-14 12:26 ` [PR REVIEW] " ericonr
@ 2021-09-14 12:29 ` BoboTiG
  2021-09-14 12:30 ` BoboTiG
                   ` (13 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-14 12:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r708217569

Comment:
I was trying to fix failing tests saying `pip not found`.
It seems there was progress, because now failing jobs are talking about missing `pytest`. But it should not be related to my changes, right?

Are failures expected for some configuration?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (8 preceding siblings ...)
  2021-09-14 12:29 ` BoboTiG
@ 2021-09-14 12:30 ` BoboTiG
  2021-09-14 16:22 ` paper42
                   ` (12 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-14 12:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r708217569

Comment:
I was trying to fix failing tests saying `pip not found`.
It seems there was progress, because now failing jobs are talking about missing `pytest`.  :thinking: 

Are failures expected for some jobs?

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (9 preceding siblings ...)
  2021-09-14 12:30 ` BoboTiG
@ 2021-09-14 16:22 ` paper42
  2021-09-14 16:22 ` paper42
                   ` (11 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-09-14 16:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r708436977

Comment:
pip is used to install packages that are missing. This means the environment in which the tests will run will **not** be similar to when a user installs this package, so it's useless to run tests like this. We should either specify the check dependencies in `$checkdepends` or disable tests.

In this case, if we add
```sh
checkdepends="python3-pytest $depends"
```
it will fail with
```
ImportError while loading conftest '/builddir/httpie-2.5.0/tests/conftest.py'.
tests/conftest.py:3: in <module>
    from pytest_httpbin import certs
E   ModuleNotFoundError: No module named 'pytest_httpbin'
```

pytest_httpbin is not packaged, let's disable tests and add a comment about this, so if we package it in the future, we can enable tests:

```sh
make_check=no # needs pytest_httpbin which is not packaged
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (10 preceding siblings ...)
  2021-09-14 16:22 ` paper42
@ 2021-09-14 16:22 ` paper42
  2021-09-14 16:24 ` paper42
                   ` (10 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-09-14 16:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#issuecomment-919309491

Comment:
Please squash the commits to one.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (11 preceding siblings ...)
  2021-09-14 16:22 ` paper42
@ 2021-09-14 16:24 ` paper42
  2021-09-15 10:06 ` [PR PATCH] [Updated] " BoboTiG
                   ` (9 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-09-14 16:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#issuecomment-919309491

Comment:
Please squash the commits to one and fill in the PR template.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (12 preceding siblings ...)
  2021-09-14 16:24 ` paper42
@ 2021-09-15 10:06 ` BoboTiG
  2021-09-15 10:07 ` [PR REVIEW] " BoboTiG
                   ` (8 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-15 10:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

There is an updated pull request by BoboTiG against master on the void-packages repository

https://github.com/BoboTiG/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32905

httpie: update to 2.5.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32905.patch --]
[-- Type: text/x-diff, Size: 1712 bytes --]

From 39b8a74b35cd2eb2c3e7ee368553d79e5f51a3b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Fri, 10 Sep 2021 15:23:00 +0200
Subject: [PATCH] httpie: update to 2.5.0.

---
 srcpkgs/httpie/template | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index 201e2af09b4e..90e89b98adfc 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -1,17 +1,19 @@
 # Template file for 'httpie'
 pkgname=httpie
-version=2.2.0
-revision=2
+version=2.5.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-requests python3-Pygments"
+depends="python3-setuptools python3-requests python3-requests-toolbelt
+ python3-Pygments python3-pysocks python3-defusedxml"
+make_check=no # needs pytest_httpbin which is not packaged
 short_desc="Human-friendly command line HTTP client"
-maintainer="Alessio Sergi <al3hex@gmail.com>"
+maintainer="Mickaël Schoentgen <mickael@apible.io>"
 license="BSD-3-Clause"
-homepage="https://httpie.org/"
-changelog="https://raw.githubusercontent.com/jakubroztocil/httpie/master/CHANGELOG.rst"
-distfiles="https://github.com/jakubroztocil/httpie/archive/${version}.tar.gz"
-checksum=413894ad9d5d45a2a7839079dcdc0f23b0ea3586502d5014339b957de73d413e
+homepage="https://httpie.io/"
+changelog="https://raw.githubusercontent.com/httpie/httpie/${version}/CHANGELOG.md"
+distfiles="https://github.com/httpie/httpie/archive/${version}.tar.gz"
+checksum=66af56e0efc1ca6237323f1186ba34bca1be24e67a4319fd5df7228ab986faea
 
 post_install() {
 	vcompletion extras/httpie-completion.bash bash http

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (13 preceding siblings ...)
  2021-09-15 10:06 ` [PR PATCH] [Updated] " BoboTiG
@ 2021-09-15 10:07 ` BoboTiG
  2021-09-15 10:08 ` BoboTiG
                   ` (7 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-15 10:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r709039786

Comment:
Thanks for the explanation @paper42.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (14 preceding siblings ...)
  2021-09-15 10:07 ` [PR REVIEW] " BoboTiG
@ 2021-09-15 10:08 ` BoboTiG
  2021-09-15 10:33 ` [PR PATCH] [Updated] " BoboTiG
                   ` (6 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-15 10:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#issuecomment-919883913

Comment:
Squashed, updated and tested with success.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (15 preceding siblings ...)
  2021-09-15 10:08 ` BoboTiG
@ 2021-09-15 10:33 ` BoboTiG
  2021-09-15 17:45 ` [PR REVIEW] " paper42
                   ` (5 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-15 10:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

There is an updated pull request by BoboTiG against master on the void-packages repository

https://github.com/BoboTiG/void-packages patch-1
https://github.com/void-linux/void-packages/pull/32905

httpie: update to 2.5.0.
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-32905.patch --]
[-- Type: text/x-diff, Size: 1712 bytes --]

From 1aba8708be8d8268387130070d92d790af58aaad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= <contact@tiger-222.fr>
Date: Fri, 10 Sep 2021 15:23:00 +0200
Subject: [PATCH] httpie: update to 2.5.0.

---
 srcpkgs/httpie/template | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/httpie/template b/srcpkgs/httpie/template
index 201e2af09b4e..1a9a418a42b0 100644
--- a/srcpkgs/httpie/template
+++ b/srcpkgs/httpie/template
@@ -1,17 +1,19 @@
 # Template file for 'httpie'
 pkgname=httpie
-version=2.2.0
-revision=2
+version=2.5.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-requests python3-Pygments"
+depends="python3-setuptools python3-requests python3-requests-toolbelt
+ python3-Pygments python3-pysocks python3-defusedxml"
 short_desc="Human-friendly command line HTTP client"
-maintainer="Alessio Sergi <al3hex@gmail.com>"
+maintainer="Mickaël Schoentgen <mickael@apible.io>"
 license="BSD-3-Clause"
-homepage="https://httpie.org/"
-changelog="https://raw.githubusercontent.com/jakubroztocil/httpie/master/CHANGELOG.rst"
-distfiles="https://github.com/jakubroztocil/httpie/archive/${version}.tar.gz"
-checksum=413894ad9d5d45a2a7839079dcdc0f23b0ea3586502d5014339b957de73d413e
+homepage="https://httpie.io/"
+changelog="https://raw.githubusercontent.com/httpie/httpie/${version}/CHANGELOG.md"
+distfiles="https://github.com/httpie/httpie/archive/${version}.tar.gz"
+checksum=66af56e0efc1ca6237323f1186ba34bca1be24e67a4319fd5df7228ab986faea
+make_check=no # needs pytest_httpbin which is not packaged
 
 post_install() {
 	vcompletion extras/httpie-completion.bash bash http

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (16 preceding siblings ...)
  2021-09-15 10:33 ` [PR PATCH] [Updated] " BoboTiG
@ 2021-09-15 17:45 ` paper42
  2021-09-15 20:51 ` BoboTiG
                   ` (4 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-09-15 17:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r709420773

Comment:
We should be able to remove setuptools from runtime dependencies, it's used only for building.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (17 preceding siblings ...)
  2021-09-15 17:45 ` [PR REVIEW] " paper42
@ 2021-09-15 20:51 ` BoboTiG
  2021-09-17 20:11 ` [PR PATCH] [Merged]: " paper42
                   ` (3 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-15 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r709563731

Comment:
Actually it is used at runtime too.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Merged]: httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (18 preceding siblings ...)
  2021-09-15 20:51 ` BoboTiG
@ 2021-09-17 20:11 ` paper42
  2021-09-17 20:13 ` [PR REVIEW] " paper42
                   ` (2 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-09-17 20:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

There's a merged pull request on the void-packages repository

httpie: update to 2.5.0.
https://github.com/void-linux/void-packages/pull/32905

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages on VoidLinux specifically, but tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (19 preceding siblings ...)
  2021-09-17 20:11 ` [PR PATCH] [Merged]: " paper42
@ 2021-09-17 20:13 ` paper42
  2021-09-17 20:44 ` BoboTiG
  2021-09-17 20:46 ` BoboTiG
  22 siblings, 0 replies; 24+ messages in thread
From: paper42 @ 2021-09-17 20:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r711324662

Comment:
Out of curiosity, could you point me where it is imported? Searching through the source code only reveals it used in setup.py.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (20 preceding siblings ...)
  2021-09-17 20:13 ` [PR REVIEW] " paper42
@ 2021-09-17 20:44 ` BoboTiG
  2021-09-17 20:46 ` BoboTiG
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-17 20:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r711340301

Comment:
Here: https://github.com/httpie/httpie/blob/e2ba214ac02905ab0ada72c582c9e95023c49496/httpie/plugins/manager.py#L5

FTR a similar problem was fixed on Alpine: https://github.com/httpie/httpie/issues/1092

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] httpie: update to 2.5.0.
  2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
                   ` (21 preceding siblings ...)
  2021-09-17 20:44 ` BoboTiG
@ 2021-09-17 20:46 ` BoboTiG
  22 siblings, 0 replies; 24+ messages in thread
From: BoboTiG @ 2021-09-17 20:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New review comment by BoboTiG on void-packages repository

https://github.com/void-linux/void-packages/pull/32905#discussion_r711340301

Comment:
Here: https://github.com/httpie/httpie/blob/e2ba214ac02905ab0ada72c582c9e95023c49496/httpie/plugins/manager.py#L5

FTR a similar problem was fixed on Alpine: https://github.com/httpie/httpie/issues/1092

We may improve the situation later by using `importlib` or something else though.

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2021-09-17 20:46 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 13:24 [PR PATCH] httpie: update to 2.5.0 BoboTiG
2021-09-10 14:28 ` [PR REVIEW] " ericonr
2021-09-10 14:28 ` ericonr
2021-09-10 14:32 ` [PR PATCH] [Updated] " BoboTiG
2021-09-10 14:33 ` [PR REVIEW] " BoboTiG
2021-09-10 15:56 ` BoboTiG
2021-09-14  9:09 ` BoboTiG
2021-09-14  9:09 ` [PR PATCH] [Updated] " BoboTiG
2021-09-14 12:26 ` [PR REVIEW] " ericonr
2021-09-14 12:29 ` BoboTiG
2021-09-14 12:30 ` BoboTiG
2021-09-14 16:22 ` paper42
2021-09-14 16:22 ` paper42
2021-09-14 16:24 ` paper42
2021-09-15 10:06 ` [PR PATCH] [Updated] " BoboTiG
2021-09-15 10:07 ` [PR REVIEW] " BoboTiG
2021-09-15 10:08 ` BoboTiG
2021-09-15 10:33 ` [PR PATCH] [Updated] " BoboTiG
2021-09-15 17:45 ` [PR REVIEW] " paper42
2021-09-15 20:51 ` BoboTiG
2021-09-17 20:11 ` [PR PATCH] [Merged]: " paper42
2021-09-17 20:13 ` [PR REVIEW] " paper42
2021-09-17 20:44 ` BoboTiG
2021-09-17 20:46 ` BoboTiG

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ https://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git