Re: [PR PATCH] [Updated] fwupd: change deps

[dkwo <dkwo@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages fwupd
https://github.com/void-linux/void-packages/pull/32932

fwupd: change deps
drop dep on udisks2, add dep on dbus
drop -Dintrospection=true, which is default
built and checked on x86_64-musl

udisks2 brings in a lot of bloat, just to discover the ESP partition, but it actually does not do the job,
so it would be simpler to just let the user take care of that. (That's also what Alpine does btw.)
Notice even with udisks, I currently have to do
`mount -t efivarfs efivarfs /sys/firmware/efi/efivars`
otherwise fwupd does not find the bios to update.
Instead, dbus seems to be a needed dependency.

A patch file from https://github.com/void-linux/void-packages/pull/32932.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fwupd-32932.patch --]
[-- Type: text/x-diff, Size: 1587 bytes --]

From 9aa1a36cc34faf501461c096070760655fb6177a Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Sun, 12 Sep 2021 08:27:30 +0200
Subject: [PATCH] fwupd: change deps, config

Drop dependency on udisks2, let user mount ESP.
Otherwise, to work it would also require elogind.
Add needed dbus dependency.
Drop plugin_altos=false config option, as suggested by upstream.
---
 srcpkgs/fwupd/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/fwupd/template b/srcpkgs/fwupd/template
index afe369923922..427b4eed730e 100644
--- a/srcpkgs/fwupd/template
+++ b/srcpkgs/fwupd/template
@@ -1,19 +1,19 @@
 # Template file for 'fwupd'
 pkgname=fwupd
 version=1.6.3
-revision=1
+revision=2
 build_style=meson
 build_helper="gir"
 # tests require unpackaged umockdev
-configure_args="-Dsupported_build=true -Dconsolekit=false -Dintrospection=true
- -Dsystemd=false -Dplugin_altos=false -Delogind=true -Dtests=false"
+configure_args="-Dsupported_build=true -Dconsolekit=false -Dsystemd=false -Delogind=true
+ -Dintrospection=true -Dtests=false"
 hostmakedepends="dejavu-fonts-ttf gnutls-tools pkg-config gcab gi-docgen
  vala glib-devel polkit gettext pango python3-gobject python3-Pillow"
 makedepends="libxmlb-devel cairo-devel colord-devel libarchive-devel
  gnutls-devel gpgme-devel json-glib-devel libgusb-devel polkit-devel
  sqlite-devel libsoup-devel gcab-devel pango-devel elogind-devel
  tpm2-tss-devel libjcat-devel libcurl-devel"
-depends="udisks2"
+depends="dbus"
 conf_files="
  /etc/fwupd/*.conf
  /etc/fwupd/remotes.d/*.conf"