From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: zellij-0.17.0
Date: Fri, 17 Sep 2021 15:40:02 +0200 [thread overview]
Message-ID: <20210917134002.uiBl8HkQ8n0nb7TXLxIXir94JDt50R2IJPx2EIooJSw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32990@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/32990#discussion_r711065119
Comment:
In general, negated `archs` lists are bad. `xbps-src` supports a lot more than the 9 official build architectures. Because `wasmer-vm` explicitly supports `x86_64`, `x86` and `aarch64`, you should do
```sh
archs="x86_64* aarch64* i686"
```
if you can't patch the crate to support more.
next prev parent reply other threads:[~2021-09-17 13:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 8:34 [PR PATCH] " kartikynwa
2021-09-17 9:23 ` [PR PATCH] [Updated] " kartikynwa
2021-09-17 9:39 ` kartikynwa
2021-09-17 12:45 ` kartikynwa
2021-09-17 13:17 ` kartikynwa
2021-09-17 13:40 ` ahesford [this message]
2021-09-17 13:52 ` kartikynwa
2021-09-17 13:55 ` [PR REVIEW] " kartikynwa
2021-09-17 13:56 ` [PR PATCH] [Updated] " kartikynwa
2021-09-17 14:20 ` kartikynwa
2021-09-17 14:40 ` [PR REVIEW] " kartikynwa
2021-09-18 5:06 ` [PR PATCH] [Updated] " kartikynwa
2021-09-18 5:48 ` kartikynwa
2021-09-19 20:24 ` kartikynwa
2021-09-19 21:29 ` Johnnynator
2021-09-19 21:49 ` [PR PATCH] [Updated] " kartikynwa
2021-09-19 21:50 ` kartikynwa
2021-09-19 21:55 ` kartikynwa
2021-09-19 23:41 ` [PR REVIEW] " ericonr
2021-09-20 3:12 ` [PR PATCH] [Updated] " kartikynwa
2021-09-20 3:33 ` [PR REVIEW] " kartikynwa
2021-10-01 16:16 ` [PR PATCH] [Updated] " kartikynwa
2021-10-22 17:17 ` [PR PATCH] [Updated] New package: zellij-0.18.1 kartikynwa
2021-10-22 17:18 ` [PR PATCH] [Updated] New package: zellij-0.19.0 kartikynwa
2021-11-12 18:27 ` kartikynwa
2021-11-12 18:35 ` New package: zellij-0.20.1 kartikynwa
2021-11-12 18:35 ` [PR PATCH] [Closed]: " kartikynwa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917134002.uiBl8HkQ8n0nb7TXLxIXir94JDt50R2IJPx2EIooJSw@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).