Re: [PR PATCH] [Updated] Math packages: givaro, fflas-ffpack, linbox

[tornaria <tornaria@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages math1
https://github.com/void-linux/void-packages/pull/29997

Math packages: givaro, fflas-ffpack, linbox
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

#### Notes

- This includes: `givaro`, `fflas-ffpack`, `linbox`.
- Everything is tested and check pass in x86_64, x86_64-musl, i686.
- Except `gf2x`, everything is nocross.
- I tried to make sure everything works with baseline x86_64 as defined [here](https://en.wikipedia.org/wiki/X86-64#Microarchitecture_Levels), essentially it means SSE2 is ok, but SSE3 is not.
- I added a general option `native`, which defaults to off. When turned on, it will let the libraries compile for the build machine which often results in significant improvements.

EDIT: split in smaller independent PR to ease review

A patch file from https://github.com/void-linux/void-packages/pull/29997.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-math1-29997.patch --]
[-- Type: text/x-diff, Size: 7880 bytes --]

From b7a2192d02d884fb2cc2b798fdb681fb04e2c65f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 9 Jan 2018 23:00:22 -0300
Subject: [PATCH 1/3] New package: givaro-4.1.1

---
 common/shlibs           |  1 +
 srcpkgs/givaro-devel    |  1 +
 srcpkgs/givaro/template | 37 +++++++++++++++++++++++++++++++++++++
 3 files changed, 39 insertions(+)
 create mode 120000 srcpkgs/givaro-devel
 create mode 100644 srcpkgs/givaro/template

diff --git a/common/shlibs b/common/shlibs
index 840fbc0b9a9f..75fbf05437b3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3991,6 +3991,7 @@ libopenaptx.so.0 libopenaptx-0.2.0_1
 libsimavr.so.1 simavr-1.6_2
 libsimavrparts.so.1 simavr-1.6_2
 libsword-1.8.1.so libsword-1.8.1_6
+libgivaro.so.9 givaro-4.1.1_1
 libpari-gmp.so.7 pari-2.13.0_1
 libpari-gmp-tls.so.7 pari-2.13.2_1
 libtree-sitter.so.0 tree-sitter-0.19.0_1
diff --git a/srcpkgs/givaro-devel b/srcpkgs/givaro-devel
new file mode 120000
index 000000000000..587339b2c069
--- /dev/null
+++ b/srcpkgs/givaro-devel
@@ -0,0 +1 @@
+givaro
\ No newline at end of file
diff --git a/srcpkgs/givaro/template b/srcpkgs/givaro/template
new file mode 100644
index 000000000000..9c16de5b1974
--- /dev/null
+++ b/srcpkgs/givaro/template
@@ -0,0 +1,37 @@
+# Template file for 'givaro'
+pkgname=givaro
+version=4.1.1
+revision=1
+build_style=gnu-configure
+makedepends="gmpxx-devel"
+short_desc="C++ library for arithmetic and algebraic computations"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="CECILL-B"
+homepage="https://github.com/linbox-team/givaro"
+distfiles="https://github.com/linbox-team/givaro/releases/download/v${version}/givaro-${version}.tar.gz"
+checksum=628049899386e91da245aee6cd446350fbca87e94863bc0d815066c08150487f
+nocross=yes
+
+build_options="native_build"
+
+if [ -z "$build_option_native_build" ]; then
+	configure_args="--enable-sse --enable-sse2
+	  --disable-sse3 --disable-ssse3 --disable-sse41 --disable-sse42
+	  --disable-avx --disable-avx2 --disable-fma --disable-fma4"
+fi
+
+post_install() {
+	vlicense "Licence_CeCILL-B_V1-en.txt"
+}
+
+givaro-devel_package() {
+	depends="${sourcepkg}>=${version}_${revision} ${makedepends}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove usr/lib/pkgconfig
+		vmove usr/bin
+	}
+}

From c7188b4f5a96384f41799553f7b2ab95089da22f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 9 Jan 2018 23:39:59 -0300
Subject: [PATCH 2/3] New package: fflas-ffpack-2.4.3

---
 srcpkgs/fflas-ffpack/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/fflas-ffpack/template

diff --git a/srcpkgs/fflas-ffpack/template b/srcpkgs/fflas-ffpack/template
new file mode 100644
index 000000000000..557c644c00a4
--- /dev/null
+++ b/srcpkgs/fflas-ffpack/template
@@ -0,0 +1,24 @@
+# Template file for 'fflas-ffpack'
+pkgname=fflas-ffpack
+version=2.4.3
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config"
+makedepends="givaro-devel openblas-devel"
+depends="${makedepends}"
+short_desc="Finite Field Linear Algebra Subroutines / Package"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="LGPL-2.1-or-later"
+homepage="http://linbox-team.github.io/fflas-ffpack/"
+distfiles="https://github.com/linbox-team/fflas-ffpack/releases/download/${version}/fflas-ffpack-${version}.tar.gz"
+checksum=f372783a17a9899ee9f88d4c9421d80facccb95556146dad7020d07a03791cc9
+nocross=yes
+
+build_options="native_build"
+
+if [ -z "$build_option_native_build" ]; then
+	configure_args="--enable-sse --enable-sse2
+	  --disable-sse3 --disable-ssse3 --disable-sse41 --disable-sse42
+	  --disable-avx --disable-avx2 --disable-fma --disable-fma4
+	  --disable-avx512f --disable-avx512dq --disable-avx512vl"
+fi

From 4fdf8204625e2145299cb97260b48767e29b80be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Wed, 10 Jan 2018 00:14:35 -0300
Subject: [PATCH 3/3] New package: linbox-1.6.3

---
 common/shlibs                                 |  1 +
 srcpkgs/linbox-devel                          |  1 +
 ...8adade10641f1f04f04b589753d928fb5443.patch | 35 +++++++++++++++++++
 srcpkgs/linbox/template                       | 35 +++++++++++++++++++
 4 files changed, 72 insertions(+)
 create mode 120000 srcpkgs/linbox-devel
 create mode 100644 srcpkgs/linbox/patches/892f8adade10641f1f04f04b589753d928fb5443.patch
 create mode 100644 srcpkgs/linbox/template

diff --git a/common/shlibs b/common/shlibs
index 75fbf05437b3..90eacdee64d1 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3992,6 +3992,7 @@ libsimavr.so.1 simavr-1.6_2
 libsimavrparts.so.1 simavr-1.6_2
 libsword-1.8.1.so libsword-1.8.1_6
 libgivaro.so.9 givaro-4.1.1_1
+liblinbox.so.0 linbox-1.6.3_1
 libpari-gmp.so.7 pari-2.13.0_1
 libpari-gmp-tls.so.7 pari-2.13.2_1
 libtree-sitter.so.0 tree-sitter-0.19.0_1
diff --git a/srcpkgs/linbox-devel b/srcpkgs/linbox-devel
new file mode 120000
index 000000000000..4b90ac79c1e7
--- /dev/null
+++ b/srcpkgs/linbox-devel
@@ -0,0 +1 @@
+linbox
\ No newline at end of file
diff --git a/srcpkgs/linbox/patches/892f8adade10641f1f04f04b589753d928fb5443.patch b/srcpkgs/linbox/patches/892f8adade10641f1f04f04b589753d928fb5443.patch
new file mode 100644
index 000000000000..5afa078ec7b8
--- /dev/null
+++ b/srcpkgs/linbox/patches/892f8adade10641f1f04f04b589753d928fb5443.patch
@@ -0,0 +1,35 @@
+From 892f8adade10641f1f04f04b589753d928fb5443 Mon Sep 17 00:00:00 2001
+From: Doug Torrance <dtorrance@piedmont.edu>
+Date: Sun, 9 May 2021 12:14:19 -0400
+Subject: [PATCH] Use std::ptrdiff_t for vector iterator difference type
+
+It was previously long (64-bit integers), but this will not be the
+case on 32-bit systems.
+
+Closes: #273
+---
+ linbox/vector/bit-vector.inl | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/linbox/vector/bit-vector.inl b/linbox/vector/bit-vector.inl
+index 5fa84b421..23a22ba47 100644
+--- a/linbox/vector/bit-vector.inl
++++ b/linbox/vector/bit-vector.inl
+@@ -46,7 +46,7 @@ namespace std
+ 		typedef LinBox::BitVector::reference reference;
+ 		typedef bool *pointer;
+ 		typedef bool value_type;
+-		typedef long difference_type;
++		typedef std::ptrdiff_t difference_type;
+ 	};
+ 
+ 	template <>
+@@ -56,7 +56,7 @@ namespace std
+ 		typedef LinBox::BitVector::const_reference reference;
+ 		typedef const bool *pointer;
+ 		typedef bool value_type;
+-		typedef long difference_type;
++		typedef std::ptrdiff_t difference_type;
+ 	};
+ }
+ 
diff --git a/srcpkgs/linbox/template b/srcpkgs/linbox/template
new file mode 100644
index 000000000000..3ea51f5dcce1
--- /dev/null
+++ b/srcpkgs/linbox/template
@@ -0,0 +1,35 @@
+# Template file for 'linbox'
+pkgname=linbox
+version=1.6.3
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config"
+makedepends="fflas-ffpack"
+short_desc="C++ library for exact, high-performance linear algebra"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="LGPL-2.1-or-later"
+homepage="https://linalg.org"
+distfiles="https://github.com/linbox-team/linbox/releases/download/v${version}/linbox-${version}.tar.gz"
+checksum=a58a188307b07c57964e844bceb99321d3043a8a4a1fccc082a54928bb9a0057
+nocross=yes
+
+build_options="native_build"
+
+if [ -z "$build_option_native_build" ]; then
+	configure_args="--enable-sse --enable-sse2
+	  --disable-sse3 --disable-ssse3 --disable-sse41 --disable-sse42
+	  --disable-avx --disable-avx2 --disable-fma --disable-fma4"
+fi
+
+linbox-devel_package() {
+	depends="${sourcepkg}>=${version}_${revision} ${makedepends}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove usr/lib/pkgconfig
+		vmove usr/bin
+		vmove usr/share
+	}
+}