Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [wip] extract distfiles to tmpdir, then move
Date: Fri, 17 Sep 2021 23:20:06 +0200	[thread overview]
Message-ID: <20210917212006.BGkZDv51EDXMtfJ0YILv0j8voyOWPtUvDQ1vzXr2iWU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33006@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/33006#issuecomment-922088123

Comment:
Here different semantics for the move step:
```
set -- "$extractdir"/*
if [ "$#" -eq 1 ] && [ -d "$1" ]; then
	mv -i "$1" -T "$wrksrc" ||
		msg_error "$pkgver: failed to move '$1' to '$wrksrc'"
else
	mkdir -p "$wrksrc" || msg_error "$pkgver: failed to create wrksrc.\n"
	mv -i "$@" -t "$wrksrc" ||
		msg_error "$pkgver: failed to move '$extractdir/*' into '$wrksrc'"
fi
```
More precisely:
 - if there's a single directory extracted, move that to XBPS_BUILDDIR renaming to `$wrksrc`
 - otherwise, move the whole tmpdir into XBPS_BUILDDIR with name `$wrksrc`.


  parent reply	other threads:[~2021-09-17 21:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 21:10 [PR PATCH] " tornaria
2021-09-17 21:18 ` tornaria
2021-09-17 21:20 ` tornaria [this message]
2021-09-17 22:10 ` q66
2021-09-30  2:12 ` tornaria
2021-09-30  2:12 ` [PR PATCH] [Closed]: " tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917212006.BGkZDv51EDXMtfJ0YILv0j8voyOWPtUvDQ1vzXr2iWU@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).