Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mgba 0.9.2
@ 2021-09-16 14:42 fanyx
  2021-09-17 15:41 ` ahesford
                   ` (16 more replies)
  0 siblings, 17 replies; 18+ messages in thread
From: fanyx @ 2021-09-16 14:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

There is a new pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages mgba-0.9.2
https://github.com/void-linux/void-packages/pull/32980

mgba 0.9.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32980.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mgba-0.9.2-32980.patch --]
[-- Type: text/x-diff, Size: 1755 bytes --]

From 5d7c63e49bccc11ec91adb125bdd7246f98074f7 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Thu, 16 Sep 2021 14:33:30 +0200
Subject: [PATCH 1/2] mgba: update to 0.9.2

---
 srcpkgs/mgba/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mgba/template b/srcpkgs/mgba/template
index 8a943c1d9951..0fcee63db539 100644
--- a/srcpkgs/mgba/template
+++ b/srcpkgs/mgba/template
@@ -1,6 +1,6 @@
 # Template file for 'mgba'
 pkgname=mgba
-version=0.8.4
+version=0.9.2
 revision=1
 build_style=cmake
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake desktop-file-utils"
@@ -12,7 +12,7 @@ license="MPL-2.0"
 homepage="https://www.mgba.io/"
 changelog="https://raw.githubusercontent.com/mgba-emu/mgba/master/CHANGES"
 distfiles="https://github.com/mgba-emu/${pkgname}/archive/${version}.tar.gz"
-checksum=6b94873dac9040fd6fd9f13f76dc48f342e954f3b4cf82717b59601c3a32b72c
+checksum=29ca22ebc56b26a4e7224efbb5fa12c9c006563d41990afb0874d048db76add4
 
 libmgba_package() {
 	short_desc+=" - shared library"

From abee629a24146e5a12a64bd2e128cc2ff5b36a3c Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Thu, 16 Sep 2021 15:08:18 +0200
Subject: [PATCH 2/2] common/shlibs: mgba

---
 common/shlibs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/shlibs b/common/shlibs
index 840fbc0b9a9f..6f250a63f5d0 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2566,7 +2566,7 @@ libfirm.so.1.22 libfirm-1.22.0_1
 libaudiofile.so.1 audiofile-0.3.6_1
 libbs2b.so.0 libbs2b-3.1.0_1
 libmunge.so.2 munge-libs-0.5.14_3
-libmgba.so.0.8 libmgba-0.8.1_1
+libmgba.so.0.9 libmgba-0.9.2_1
 libglabels-3.0.so.8 libglabels30-3.2.1_1
 libglbarcode-3.0.so.0 libglabels30-3.2.1_1
 libjim.so.0.80 jimtcl-0.80_1

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
@ 2021-09-17 15:41 ` ahesford
  2021-09-17 15:52 ` [PR PATCH] [Updated] " fanyx
                   ` (15 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: ahesford @ 2021-09-17 15:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#issuecomment-921896480

Comment:
Please squash these two commits into one.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
  2021-09-17 15:41 ` ahesford
@ 2021-09-17 15:52 ` fanyx
  2021-09-17 15:54 ` fanyx
                   ` (14 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-17 15:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages mgba-0.9.2
https://github.com/void-linux/void-packages/pull/32980

mgba 0.9.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32980.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mgba-0.9.2-32980.patch --]
[-- Type: text/x-diff, Size: 1530 bytes --]

From 0a903d911408a134254838c5cfa665de5ab4306d Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Thu, 16 Sep 2021 14:33:30 +0200
Subject: [PATCH] mgba: update to 0.9.2

---
 common/shlibs         | 2 +-
 srcpkgs/mgba/template | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 840fbc0b9a9f..6f250a63f5d0 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2566,7 +2566,7 @@ libfirm.so.1.22 libfirm-1.22.0_1
 libaudiofile.so.1 audiofile-0.3.6_1
 libbs2b.so.0 libbs2b-3.1.0_1
 libmunge.so.2 munge-libs-0.5.14_3
-libmgba.so.0.8 libmgba-0.8.1_1
+libmgba.so.0.9 libmgba-0.9.2_1
 libglabels-3.0.so.8 libglabels30-3.2.1_1
 libglbarcode-3.0.so.0 libglabels30-3.2.1_1
 libjim.so.0.80 jimtcl-0.80_1
diff --git a/srcpkgs/mgba/template b/srcpkgs/mgba/template
index 8a943c1d9951..0fcee63db539 100644
--- a/srcpkgs/mgba/template
+++ b/srcpkgs/mgba/template
@@ -1,6 +1,6 @@
 # Template file for 'mgba'
 pkgname=mgba
-version=0.8.4
+version=0.9.2
 revision=1
 build_style=cmake
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake desktop-file-utils"
@@ -12,7 +12,7 @@ license="MPL-2.0"
 homepage="https://www.mgba.io/"
 changelog="https://raw.githubusercontent.com/mgba-emu/mgba/master/CHANGES"
 distfiles="https://github.com/mgba-emu/${pkgname}/archive/${version}.tar.gz"
-checksum=6b94873dac9040fd6fd9f13f76dc48f342e954f3b4cf82717b59601c3a32b72c
+checksum=29ca22ebc56b26a4e7224efbb5fa12c9c006563d41990afb0874d048db76add4
 
 libmgba_package() {
 	short_desc+=" - shared library"

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
  2021-09-17 15:41 ` ahesford
  2021-09-17 15:52 ` [PR PATCH] [Updated] " fanyx
@ 2021-09-17 15:54 ` fanyx
  2021-09-17 17:43 ` ahesford
                   ` (13 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-17 15:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#issuecomment-921904379

Comment:
Squashed shlibs and package update into one commit

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (2 preceding siblings ...)
  2021-09-17 15:54 ` fanyx
@ 2021-09-17 17:43 ` ahesford
  2021-09-18  9:57 ` [PR PATCH] [Updated] " fanyx
                   ` (12 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: ahesford @ 2021-09-17 17:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#issuecomment-921971054

Comment:
Looks like armv6l fails because it needs `libatomic-devel`. See https://github.com/void-linux/void-packages/blob/master/srcpkgs/zfs/template#L25-L27 for the recommended mechanism here.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (3 preceding siblings ...)
  2021-09-17 17:43 ` ahesford
@ 2021-09-18  9:57 ` fanyx
  2021-09-18  9:57 ` fanyx
                   ` (11 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-18  9:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages mgba-0.9.2
https://github.com/void-linux/void-packages/pull/32980

mgba 0.9.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32980.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mgba-0.9.2-32980.patch --]
[-- Type: text/x-diff, Size: 1615 bytes --]

From 90f3855132a06051fdc0a3bdb9d14e9da810ac85 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Thu, 16 Sep 2021 14:33:30 +0200
Subject: [PATCH] mgba: update to 0.9.2

---
 common/shlibs         | 2 +-
 srcpkgs/mgba/template | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 840fbc0b9a9f..6f250a63f5d0 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2566,7 +2566,7 @@ libfirm.so.1.22 libfirm-1.22.0_1
 libaudiofile.so.1 audiofile-0.3.6_1
 libbs2b.so.0 libbs2b-3.1.0_1
 libmunge.so.2 munge-libs-0.5.14_3
-libmgba.so.0.8 libmgba-0.8.1_1
+libmgba.so.0.9 libmgba-0.9.2_1
 libglabels-3.0.so.8 libglabels30-3.2.1_1
 libglbarcode-3.0.so.0 libglabels30-3.2.1_1
 libjim.so.0.80 jimtcl-0.80_1
diff --git a/srcpkgs/mgba/template b/srcpkgs/mgba/template
index 8a943c1d9951..1b8de840bcd4 100644
--- a/srcpkgs/mgba/template
+++ b/srcpkgs/mgba/template
@@ -1,6 +1,6 @@
 # Template file for 'mgba'
 pkgname=mgba
-version=0.8.4
+version=0.9.2
 revision=1
 build_style=cmake
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake desktop-file-utils"
@@ -12,7 +12,11 @@ license="MPL-2.0"
 homepage="https://www.mgba.io/"
 changelog="https://raw.githubusercontent.com/mgba-emu/mgba/master/CHANGES"
 distfiles="https://github.com/mgba-emu/${pkgname}/archive/${version}.tar.gz"
-checksum=6b94873dac9040fd6fd9f13f76dc48f342e954f3b4cf82717b59601c3a32b72c
+checksum=29ca22ebc56b26a4e7224efbb5fa12c9c006563d41990afb0874d048db76add4
+
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+	makedepends+=" libatomic-devel"
+fi
 
 libmgba_package() {
 	short_desc+=" - shared library"

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (4 preceding siblings ...)
  2021-09-18  9:57 ` [PR PATCH] [Updated] " fanyx
@ 2021-09-18  9:57 ` fanyx
  2021-09-18 21:03 ` [PR PATCH] [Updated] " fanyx
                   ` (10 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-18  9:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#issuecomment-922251638

Comment:
implemented `libatomic-devel` for armv6l

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (5 preceding siblings ...)
  2021-09-18  9:57 ` fanyx
@ 2021-09-18 21:03 ` fanyx
  2021-09-19  3:06 ` [PR REVIEW] " ericonr
                   ` (9 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-18 21:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages mgba-0.9.2
https://github.com/void-linux/void-packages/pull/32980

mgba 0.9.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32980.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mgba-0.9.2-32980.patch --]
[-- Type: text/x-diff, Size: 1978 bytes --]

From 1ae646202ab4960e73b58919a04bb8b4cdee855b Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Thu, 16 Sep 2021 14:33:30 +0200
Subject: [PATCH] mgba: update to 0.9.2

---
 common/shlibs         |  2 +-
 srcpkgs/mgba/template | 11 +++++++----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 840fbc0b9a9f..6f250a63f5d0 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2566,7 +2566,7 @@ libfirm.so.1.22 libfirm-1.22.0_1
 libaudiofile.so.1 audiofile-0.3.6_1
 libbs2b.so.0 libbs2b-3.1.0_1
 libmunge.so.2 munge-libs-0.5.14_3
-libmgba.so.0.8 libmgba-0.8.1_1
+libmgba.so.0.9 libmgba-0.9.2_1
 libglabels-3.0.so.8 libglabels30-3.2.1_1
 libglbarcode-3.0.so.0 libglabels30-3.2.1_1
 libjim.so.0.80 jimtcl-0.80_1
diff --git a/srcpkgs/mgba/template b/srcpkgs/mgba/template
index 8a943c1d9951..885851674107 100644
--- a/srcpkgs/mgba/template
+++ b/srcpkgs/mgba/template
@@ -1,18 +1,21 @@
 # Template file for 'mgba'
 pkgname=mgba
-version=0.8.4
+version=0.9.2
 revision=1
 build_style=cmake
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake desktop-file-utils"
-makedepends="SDL2-devel ffmpeg-devel libedit-devel libepoxy-devel libmagick-devel
- libzip-devel qt5-multimedia-devel qt5-tools-devel"
+makedepends="SDL2-devel ffmpeg-devel libedit-devel libepoxy-devel libmagick-devel libzip-devel qt5-multimedia-devel qt5-tools-devel"
 short_desc="Game Boy Advance emulator written in C"
 maintainer="bra1nwave <bra1nwave@protonmail.com>"
 license="MPL-2.0"
 homepage="https://www.mgba.io/"
 changelog="https://raw.githubusercontent.com/mgba-emu/mgba/master/CHANGES"
 distfiles="https://github.com/mgba-emu/${pkgname}/archive/${version}.tar.gz"
-checksum=6b94873dac9040fd6fd9f13f76dc48f342e954f3b4cf82717b59601c3a32b72c
+checksum=29ca22ebc56b26a4e7224efbb5fa12c9c006563d41990afb0874d048db76add4
+
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+	makedepends+=" libatomic-devel"
+fi
 
 libmgba_package() {
 	short_desc+=" - shared library"

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (6 preceding siblings ...)
  2021-09-18 21:03 ` [PR PATCH] [Updated] " fanyx
@ 2021-09-19  3:06 ` ericonr
  2021-09-19  3:06 ` ericonr
                   ` (8 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: ericonr @ 2021-09-19  3:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711673841

Comment:
Please break at ~80 columns.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (7 preceding siblings ...)
  2021-09-19  3:06 ` [PR REVIEW] " ericonr
@ 2021-09-19  3:06 ` ericonr
  2021-09-19  8:15 ` fanyx
                   ` (7 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: ericonr @ 2021-09-19  3:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711673863

Comment:
```
/usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: qt/CMakeFiles/mgba-qt.dir/library/LibraryController.cpp.o: undefined reference to symbol '__atomic_compare_exchange_8'
/usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: /usr/arm-linux-musleabihf/usr/lib/libatomic.so.1: error adding symbols: DSO missing from command line
```

something goes wrong in building >.<

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (8 preceding siblings ...)
  2021-09-19  3:06 ` ericonr
@ 2021-09-19  8:15 ` fanyx
  2021-09-19  8:34 ` fanyx
                   ` (6 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-19  8:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711704838

Comment:
agh
and i only changed it cause i thought itd cause issues ^^"
will revert that one

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (9 preceding siblings ...)
  2021-09-19  8:15 ` fanyx
@ 2021-09-19  8:34 ` fanyx
  2021-09-19  8:36 ` fanyx
                   ` (5 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-19  8:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711707302

Comment:
looks like `/usr/arm-linux-musleabihf/usr/lib/libatomic.so.1` is missing from the compiler cli command

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (10 preceding siblings ...)
  2021-09-19  8:34 ` fanyx
@ 2021-09-19  8:36 ` fanyx
  2021-09-19  8:37 ` fanyx
                   ` (4 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-19  8:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711707302

Comment:
looks like `/usr/arm-linux-musleabihf/usr/lib/libatomic.so.1` is missing from the compiler cli command

is there some way to alter the LDFLAGS during build step?

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (11 preceding siblings ...)
  2021-09-19  8:36 ` fanyx
@ 2021-09-19  8:37 ` fanyx
  2021-09-19 13:31 ` ericonr
                   ` (3 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-19  8:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711707302

Comment:
looks like `/usr/arm-linux-musleabihf/usr/lib/libatomic.so.1` is missing from the compiler cli command

is there some way to alter the `LDFLAGS` during build step?

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (12 preceding siblings ...)
  2021-09-19  8:37 ` fanyx
@ 2021-09-19 13:31 ` ericonr
  2021-09-19 13:36 ` fanyx
                   ` (2 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: ericonr @ 2021-09-19 13:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711745691

Comment:
Just set `LDFLAGS=-latomic` in the template, but it might not be enough. Since it's cmake, check out how uhd does it:

```
	makedepends+=" libatomic-devel"
	configure_args+=" -DCMAKE_CXX_STANDARD_LIBRARIES=-latomic"
```

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR REVIEW] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (13 preceding siblings ...)
  2021-09-19 13:31 ` ericonr
@ 2021-09-19 13:36 ` fanyx
  2021-09-19 13:41 ` [PR PATCH] [Updated] " fanyx
  2021-09-20  1:49 ` [PR PATCH] [Merged]: " ericonr
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-19 13:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/32980#discussion_r711746193

Comment:
yeah, something like this looks good
let me try to implement it this way, or try other ways if it doesnt work

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Updated] mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (14 preceding siblings ...)
  2021-09-19 13:36 ` fanyx
@ 2021-09-19 13:41 ` fanyx
  2021-09-20  1:49 ` [PR PATCH] [Merged]: " ericonr
  16 siblings, 0 replies; 18+ messages in thread
From: fanyx @ 2021-09-19 13:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages mgba-0.9.2
https://github.com/void-linux/void-packages/pull/32980

mgba 0.9.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32980.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mgba-0.9.2-32980.patch --]
[-- Type: text/x-diff, Size: 1677 bytes --]

From 59ce724f59efdcca88fa3330afbbe6e8273cdebc Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@pm.me>
Date: Thu, 16 Sep 2021 14:33:30 +0200
Subject: [PATCH] mgba: update to 0.9.2

---
 common/shlibs         | 2 +-
 srcpkgs/mgba/template | 9 +++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 840fbc0b9a9f..6f250a63f5d0 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2566,7 +2566,7 @@ libfirm.so.1.22 libfirm-1.22.0_1
 libaudiofile.so.1 audiofile-0.3.6_1
 libbs2b.so.0 libbs2b-3.1.0_1
 libmunge.so.2 munge-libs-0.5.14_3
-libmgba.so.0.8 libmgba-0.8.1_1
+libmgba.so.0.9 libmgba-0.9.2_1
 libglabels-3.0.so.8 libglabels30-3.2.1_1
 libglbarcode-3.0.so.0 libglabels30-3.2.1_1
 libjim.so.0.80 jimtcl-0.80_1
diff --git a/srcpkgs/mgba/template b/srcpkgs/mgba/template
index 8a943c1d9951..bcaae0e64f36 100644
--- a/srcpkgs/mgba/template
+++ b/srcpkgs/mgba/template
@@ -1,6 +1,6 @@
 # Template file for 'mgba'
 pkgname=mgba
-version=0.8.4
+version=0.9.2
 revision=1
 build_style=cmake
 hostmakedepends="pkg-config qt5-host-tools qt5-qmake desktop-file-utils"
@@ -12,7 +12,12 @@ license="MPL-2.0"
 homepage="https://www.mgba.io/"
 changelog="https://raw.githubusercontent.com/mgba-emu/mgba/master/CHANGES"
 distfiles="https://github.com/mgba-emu/${pkgname}/archive/${version}.tar.gz"
-checksum=6b94873dac9040fd6fd9f13f76dc48f342e954f3b4cf82717b59601c3a32b72c
+checksum=29ca22ebc56b26a4e7224efbb5fa12c9c006563d41990afb0874d048db76add4
+
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+	makedepends+=" libatomic-devel"
+	configure_args+=" -DCMAKE_CXX_STANDARD_LIBRARIES=-latomic"
+fi
 
 libmgba_package() {
 	short_desc+=" - shared library"

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PR PATCH] [Merged]: mgba 0.9.2
  2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
                   ` (15 preceding siblings ...)
  2021-09-19 13:41 ` [PR PATCH] [Updated] " fanyx
@ 2021-09-20  1:49 ` ericonr
  16 siblings, 0 replies; 18+ messages in thread
From: ericonr @ 2021-09-20  1:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

There's a merged pull request on the void-packages repository

mgba 0.9.2
https://github.com/void-linux/void-packages/pull/32980

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2021-09-20  1:49 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 14:42 [PR PATCH] mgba 0.9.2 fanyx
2021-09-17 15:41 ` ahesford
2021-09-17 15:52 ` [PR PATCH] [Updated] " fanyx
2021-09-17 15:54 ` fanyx
2021-09-17 17:43 ` ahesford
2021-09-18  9:57 ` [PR PATCH] [Updated] " fanyx
2021-09-18  9:57 ` fanyx
2021-09-18 21:03 ` [PR PATCH] [Updated] " fanyx
2021-09-19  3:06 ` [PR REVIEW] " ericonr
2021-09-19  3:06 ` ericonr
2021-09-19  8:15 ` fanyx
2021-09-19  8:34 ` fanyx
2021-09-19  8:36 ` fanyx
2021-09-19  8:37 ` fanyx
2021-09-19 13:31 ` ericonr
2021-09-19 13:36 ` fanyx
2021-09-19 13:41 ` [PR PATCH] [Updated] " fanyx
2021-09-20  1:49 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).