Github messages for voidlinux
 help / color / mirror / Atom feed
From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: StyLua-0.11.0
Date: Tue, 21 Sep 2021 20:30:38 +0200	[thread overview]
Message-ID: <20210921183038.dd_LqkI0KappZOkkPBabNixOs0a0ax5B05RctSeY34I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32450@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/32450#discussion_r713314751

Comment:
You can just do `configure_args="$(vopt_if lua52 '--features lua52') $(vopt_if luau '--features luau')"` no need to mess around with additional `if`'s and concatenating variables

  parent reply	other threads:[~2021-09-21 18:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 21:44 [PR PATCH] New package: StyLua-0.10.1 ram02z
2021-08-15  0:22 ` [PR PATCH] [Updated] " ram02z
2021-09-16 21:25 ` ram02z
2021-09-21 18:30 ` [PR REVIEW] New package: StyLua-0.11.0 Johnnynator
2021-09-21 18:30 ` Johnnynator [this message]
2021-09-21 19:28 ` [PR PATCH] [Updated] " ram02z
2021-10-31 11:59 ` [PR PATCH] [Merged]: " Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210921183038.dd_LqkI0KappZOkkPBabNixOs0a0ax5B05RctSeY34I@z \
    --to=johnnynator@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).