[PR PATCH] higan: fix dead links

[PR PATCH] higan: fix dead links

[meator]

[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages higan
https://github.com/void-linux/void-packages/pull/32888

higan: fix dead links
<!-- Mark items with [x] where applicable -->
@Johnnynator I'm pinging you since you are the maintainer of `higan`. Do you have any comment on this?
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32888.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-higan-32888.patch --]
[-- Type: text/x-diff, Size: 1314 bytes --]

From 641b1d4672996011f5b66106a8c0d6fd8f25b714 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Thu, 9 Sep 2021 10:33:36 +0200
Subject: [PATCH] higan: fix dead links

---
 srcpkgs/higan/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/higan/template b/srcpkgs/higan/template
index 500c11f64aa4..1fcf144c6047 100644
--- a/srcpkgs/higan/template
+++ b/srcpkgs/higan/template
@@ -2,7 +2,6 @@
 pkgname=higan
 version=110
 revision=1
-wrksrc="higan_v${version}-source"
 build_wrksrc=higan
 build_style=gnu-makefile
 make_build_args='compiler=${CXX} platform=linux'
@@ -14,9 +13,9 @@ makedepends="gtk+-devel gtksourceview2-devel libgomp-devel
 short_desc="Multi-system emulator (SNES/Game Boy/Mega Drive/PC Engine/WonderSwan)"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later, ISC"
-homepage="https://byuu.org/emulation/higan/"
-distfiles="https://byuu.org/download/higan/higan_v${version}-source.zip"
-checksum=1b70d85454aaae557fd5ba5aaed9add8cb8c939f2b7a07a6d3734f971bb07ab7
+homepage="https://github.com/higan-emu/higan"
+distfiles="https://github.com/higan-emu/higan/archive/refs/tags/v${version}.tar.gz"
+checksum=18457ac2608ab548983c3266ae38e6397d1801773969a796a672e2d9c56c69c5
 
 build_options="icarus"
 build_options_default="icarus"

Re: [PR PATCH] [Updated] [WIP] higan: fix dead links

[meator]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages higan
https://github.com/void-linux/void-packages/pull/32888

[WIP] higan: fix dead links
<!-- Mark items with [x] where applicable -->
@Johnnynator I'm pinging you since you are the maintainer of `higan`. Do you have any comment on this?
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32888.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-higan-32888.patch --]
[-- Type: text/x-diff, Size: 2572 bytes --]

From a22f3a5fd0ca54fb53add02db0bfae9827832bac Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Thu, 9 Sep 2021 10:33:36 +0200
Subject: [PATCH] higan: fix dead links & fix lint

---
 srcpkgs/higan/patches/makefile-root.patch | 11 +++++++++++
 srcpkgs/higan/template                    | 13 ++++++++-----
 2 files changed, 19 insertions(+), 5 deletions(-)
 create mode 100644 srcpkgs/higan/patches/makefile-root.patch

diff --git a/srcpkgs/higan/patches/makefile-root.patch b/srcpkgs/higan/patches/makefile-root.patch
new file mode 100644
index 000000000000..c76e567cb0ff
--- /dev/null
+++ b/srcpkgs/higan/patches/makefile-root.patch
@@ -0,0 +1,11 @@
+--- a/higan/target-higan/GNUmakefile	2020-03-20 08:59:06.000000000 +0100
++++ b/higan/target-higan/GNUmakefile	2021-09-09 10:58:54.370975389 +0200
+@@ -37,8 +37,6 @@
+ ifeq ($(platform),windows)
+ 	mkdir -p $(prefix)/$(name)/
+ 	cp -R System/* $(prefix)/$(name)/
+-else ifeq ($(shell id -un),root)
+-	$(error "make install should not be run as root")
+ else ifeq ($(platform),macos)
+ 	mkdir -p ~/Library/Application\ Support\$(name)/
+ 	mkdir -p ~/Library/Application\ Support\$(name)/System/
diff --git a/srcpkgs/higan/template b/srcpkgs/higan/template
index 500c11f64aa4..85c84962cd14 100644
--- a/srcpkgs/higan/template
+++ b/srcpkgs/higan/template
@@ -2,25 +2,28 @@
 pkgname=higan
 version=110
 revision=1
-wrksrc="higan_v${version}-source"
 build_wrksrc=higan
 build_style=gnu-makefile
 make_build_args='compiler=${CXX} platform=linux'
 make_install_args='compiler=${CXX} platform=linux prefix=${DESTDIR}/usr'
 hostmakedepends="unzip pkg-config"
 makedepends="gtk+-devel gtksourceview2-devel libgomp-devel
- SDL2-devel MesaLib-devel libXv-devel libao-devel 
+ SDL2-devel MesaLib-devel libXv-devel libao-devel
  alsa-lib-devel libopenal-devel pulseaudio-devel"
 short_desc="Multi-system emulator (SNES/Game Boy/Mega Drive/PC Engine/WonderSwan)"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later, ISC"
-homepage="https://byuu.org/emulation/higan/"
-distfiles="https://byuu.org/download/higan/higan_v${version}-source.zip"
-checksum=1b70d85454aaae557fd5ba5aaed9add8cb8c939f2b7a07a6d3734f971bb07ab7
+homepage="https://github.com/higan-emu/higan"
+distfiles="https://github.com/higan-emu/higan/archive/refs/tags/v${version}.tar.gz"
+checksum=18457ac2608ab548983c3266ae38e6397d1801773969a796a672e2d9c56c69c5
 
 build_options="icarus"
 build_options_default="icarus"
 
+pre_install() {
+	vlocense LICENSE.txt
+}
+
 if [ "$build_option_icarus" ];then
 	post_build() {
 		cd $wrksrc/icarus

Re: [PR PATCH] [Updated] [WIP] higan: fix dead links

[meator]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages higan
https://github.com/void-linux/void-packages/pull/32888

[WIP] higan: fix dead links
<!-- Mark items with [x] where applicable -->
@Johnnynator I'm pinging you since you are the maintainer of `higan`. Do you have any comment on this?
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32888.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-higan-32888.patch --]
[-- Type: text/x-diff, Size: 2572 bytes --]

From 03a74763ecbf3cb702f4cb2e0b104815a7d6345d Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Thu, 9 Sep 2021 10:33:36 +0200
Subject: [PATCH] higan: fix dead links & fix lint

---
 srcpkgs/higan/patches/makefile-root.patch | 11 +++++++++++
 srcpkgs/higan/template                    | 13 ++++++++-----
 2 files changed, 19 insertions(+), 5 deletions(-)
 create mode 100644 srcpkgs/higan/patches/makefile-root.patch

diff --git a/srcpkgs/higan/patches/makefile-root.patch b/srcpkgs/higan/patches/makefile-root.patch
new file mode 100644
index 000000000000..c76e567cb0ff
--- /dev/null
+++ b/srcpkgs/higan/patches/makefile-root.patch
@@ -0,0 +1,11 @@
+--- a/higan/target-higan/GNUmakefile	2020-03-20 08:59:06.000000000 +0100
++++ b/higan/target-higan/GNUmakefile	2021-09-09 10:58:54.370975389 +0200
+@@ -37,8 +37,6 @@
+ ifeq ($(platform),windows)
+ 	mkdir -p $(prefix)/$(name)/
+ 	cp -R System/* $(prefix)/$(name)/
+-else ifeq ($(shell id -un),root)
+-	$(error "make install should not be run as root")
+ else ifeq ($(platform),macos)
+ 	mkdir -p ~/Library/Application\ Support\$(name)/
+ 	mkdir -p ~/Library/Application\ Support\$(name)/System/
diff --git a/srcpkgs/higan/template b/srcpkgs/higan/template
index 500c11f64aa4..e848a5a77854 100644
--- a/srcpkgs/higan/template
+++ b/srcpkgs/higan/template
@@ -2,25 +2,28 @@
 pkgname=higan
 version=110
 revision=1
-wrksrc="higan_v${version}-source"
 build_wrksrc=higan
 build_style=gnu-makefile
 make_build_args='compiler=${CXX} platform=linux'
 make_install_args='compiler=${CXX} platform=linux prefix=${DESTDIR}/usr'
 hostmakedepends="unzip pkg-config"
 makedepends="gtk+-devel gtksourceview2-devel libgomp-devel
- SDL2-devel MesaLib-devel libXv-devel libao-devel 
+ SDL2-devel MesaLib-devel libXv-devel libao-devel
  alsa-lib-devel libopenal-devel pulseaudio-devel"
 short_desc="Multi-system emulator (SNES/Game Boy/Mega Drive/PC Engine/WonderSwan)"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later, ISC"
-homepage="https://byuu.org/emulation/higan/"
-distfiles="https://byuu.org/download/higan/higan_v${version}-source.zip"
-checksum=1b70d85454aaae557fd5ba5aaed9add8cb8c939f2b7a07a6d3734f971bb07ab7
+homepage="https://github.com/higan-emu/higan"
+distfiles="https://github.com/higan-emu/higan/archive/refs/tags/v${version}.tar.gz"
+checksum=18457ac2608ab548983c3266ae38e6397d1801773969a796a672e2d9c56c69c5
 
 build_options="icarus"
 build_options_default="icarus"
 
+pre_install() {
+	vlicense LICENSE.txt
+}
+
 if [ "$build_option_icarus" ];then
 	post_build() {
 		cd $wrksrc/icarus

Re: [PR PATCH] [Updated] [WIP] higan: fix dead links

[meator]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages higan
https://github.com/void-linux/void-packages/pull/32888

[WIP] higan: fix dead links
<!-- Mark items with [x] where applicable -->
@Johnnynator I'm pinging you since you are the maintainer of `higan`. Do you have any comment on this?
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32888.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-higan-32888.patch --]
[-- Type: text/x-diff, Size: 2580 bytes --]

From 0325086bbb579509b96a489503140765b549a280 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Thu, 9 Sep 2021 10:33:36 +0200
Subject: [PATCH] higan: fix dead links & fix lint

---
 srcpkgs/higan/patches/makefile-root.patch | 11 +++++++++++
 srcpkgs/higan/template                    | 13 ++++++++-----
 2 files changed, 19 insertions(+), 5 deletions(-)
 create mode 100644 srcpkgs/higan/patches/makefile-root.patch

diff --git a/srcpkgs/higan/patches/makefile-root.patch b/srcpkgs/higan/patches/makefile-root.patch
new file mode 100644
index 000000000000..c76e567cb0ff
--- /dev/null
+++ b/srcpkgs/higan/patches/makefile-root.patch
@@ -0,0 +1,11 @@
+--- a/higan/target-higan/GNUmakefile	2020-03-20 08:59:06.000000000 +0100
++++ b/higan/target-higan/GNUmakefile	2021-09-09 10:58:54.370975389 +0200
+@@ -37,8 +37,6 @@
+ ifeq ($(platform),windows)
+ 	mkdir -p $(prefix)/$(name)/
+ 	cp -R System/* $(prefix)/$(name)/
+-else ifeq ($(shell id -un),root)
+-	$(error "make install should not be run as root")
+ else ifeq ($(platform),macos)
+ 	mkdir -p ~/Library/Application\ Support\$(name)/
+ 	mkdir -p ~/Library/Application\ Support\$(name)/System/
diff --git a/srcpkgs/higan/template b/srcpkgs/higan/template
index 500c11f64aa4..65e19810fba6 100644
--- a/srcpkgs/higan/template
+++ b/srcpkgs/higan/template
@@ -2,25 +2,28 @@
 pkgname=higan
 version=110
 revision=1
-wrksrc="higan_v${version}-source"
 build_wrksrc=higan
 build_style=gnu-makefile
 make_build_args='compiler=${CXX} platform=linux'
 make_install_args='compiler=${CXX} platform=linux prefix=${DESTDIR}/usr'
 hostmakedepends="unzip pkg-config"
 makedepends="gtk+-devel gtksourceview2-devel libgomp-devel
- SDL2-devel MesaLib-devel libXv-devel libao-devel 
+ SDL2-devel MesaLib-devel libXv-devel libao-devel
  alsa-lib-devel libopenal-devel pulseaudio-devel"
 short_desc="Multi-system emulator (SNES/Game Boy/Mega Drive/PC Engine/WonderSwan)"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later, ISC"
-homepage="https://byuu.org/emulation/higan/"
-distfiles="https://byuu.org/download/higan/higan_v${version}-source.zip"
-checksum=1b70d85454aaae557fd5ba5aaed9add8cb8c939f2b7a07a6d3734f971bb07ab7
+homepage="https://github.com/higan-emu/higan"
+distfiles="https://github.com/higan-emu/higan/archive/refs/tags/v${version}.tar.gz"
+checksum=18457ac2608ab548983c3266ae38e6397d1801773969a796a672e2d9c56c69c5
 
 build_options="icarus"
 build_options_default="icarus"
 
+pre_install() {
+	vlicense $wrksrc/LICENSE.txt
+}
+
 if [ "$build_option_icarus" ];then
 	post_build() {
 		cd $wrksrc/icarus

Re: [WIP] higan: fix dead links

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32888#issuecomment-916366641

Comment:
```
=> higan-110_1: running post_install ...
Linking out/icarus ...
GNUmakefile:50: *** "make install should not be run as root".  Stop.
=> ERROR: higan-110_1: post_install: 'make STRIP=true compiler=${CXX} platform=linux prefix=${DESTDIR}/usr install' exited with 2
```

the current patch doesn't seem to be enough?

Re: [WIP] higan: fix dead links

[meator]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/32888#issuecomment-916384703

Comment:
There is actually a significantly larger problem with this. I have asked people on their official discord and they said that higan can't be installed as root because `System/*` files need to be writable by the program. One of the devs wrote this:

> My recommendation for making a package would be not to run make install at all, but rather to have your package-build script just copy the Template files into /usr/share/higan, install the main binary as /usr/bin/higan.real, and have /usr/bin/higan be a shell-script that copies the template files from /usr/share/higan into the user's home directory if they don't already exist.

Re: [PR PATCH] [Updated] [WIP] higan: fix dead links

[meator]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages higan
https://github.com/void-linux/void-packages/pull/32888

[WIP] higan: fix dead links
<!-- Mark items with [x] where applicable -->
@Johnnynator I'm pinging you since you are the maintainer of `higan`. Do you have any comment on this?
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/32888.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-higan-32888.patch --]
[-- Type: text/x-diff, Size: 3132 bytes --]

From 6e2b009294c3ca8a641bf1760d7e157de896061a Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Thu, 9 Sep 2021 10:33:36 +0200
Subject: [PATCH] higan: fix dead links & fix lint

---
 srcpkgs/higan/patches/makefile-root.patch | 22 ++++++++++++++++++++++
 srcpkgs/higan/template                    | 15 +++++++++------
 2 files changed, 31 insertions(+), 6 deletions(-)
 create mode 100644 srcpkgs/higan/patches/makefile-root.patch

diff --git a/srcpkgs/higan/patches/makefile-root.patch b/srcpkgs/higan/patches/makefile-root.patch
new file mode 100644
index 000000000000..13fdcc8e7094
--- /dev/null
+++ b/srcpkgs/higan/patches/makefile-root.patch
@@ -0,0 +1,22 @@
+--- a/higan/target-higan/GNUmakefile	2020-03-20 08:59:06.000000000 +0100
++++ b/higan/target-higan/GNUmakefile	2021-09-09 10:58:54.370975389 +0200
+@@ -37,8 +37,6 @@
+ ifeq ($(platform),windows)
+ 	mkdir -p $(prefix)/$(name)/
+ 	cp -R System/* $(prefix)/$(name)/
+-else ifeq ($(shell id -un),root)
+-	$(error "make install should not be run as root")
+ else ifeq ($(platform),macos)
+ 	mkdir -p ~/Library/Application\ Support\$(name)/
+ 	mkdir -p ~/Library/Application\ Support\$(name)/System/
+--- a/icarus/GNUmakefile	2020-03-20 08:59:06.000000000 +0100
++++ b/icarus/GNUmakefile	2021-09-09 12:11:52.597265710 +0200
+@@ -46,8 +46,6 @@
+ 	mkdir -p $(prefix)/$(name)/Firmware/
+ 	cp -R Database/* $(prefix)/$(name)/Database/
+ 	cp -R Firmware/* $(prefix)/$(name)/Firmware/
+-else ifeq ($(shell id -un),root)
+-	$(error "make install should not be run as root")
+ else ifeq ($(platform),macos)
+ 	cp -R out/$(name).app /Applications/$(name).app
+ else ifneq ($(filter $(platform),linux bsd),)
diff --git a/srcpkgs/higan/template b/srcpkgs/higan/template
index 500c11f64aa4..05c5a981e4df 100644
--- a/srcpkgs/higan/template
+++ b/srcpkgs/higan/template
@@ -1,26 +1,29 @@
 # Template file for 'higan'
 pkgname=higan
 version=110
-revision=1
-wrksrc="higan_v${version}-source"
+revision=2
 build_wrksrc=higan
 build_style=gnu-makefile
 make_build_args='compiler=${CXX} platform=linux'
 make_install_args='compiler=${CXX} platform=linux prefix=${DESTDIR}/usr'
 hostmakedepends="unzip pkg-config"
 makedepends="gtk+-devel gtksourceview2-devel libgomp-devel
- SDL2-devel MesaLib-devel libXv-devel libao-devel 
+ SDL2-devel MesaLib-devel libXv-devel libao-devel
  alsa-lib-devel libopenal-devel pulseaudio-devel"
 short_desc="Multi-system emulator (SNES/Game Boy/Mega Drive/PC Engine/WonderSwan)"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later, ISC"
-homepage="https://byuu.org/emulation/higan/"
-distfiles="https://byuu.org/download/higan/higan_v${version}-source.zip"
-checksum=1b70d85454aaae557fd5ba5aaed9add8cb8c939f2b7a07a6d3734f971bb07ab7
+homepage="https://github.com/higan-emu/higan"
+distfiles="https://github.com/higan-emu/higan/archive/refs/tags/v${version}.tar.gz"
+checksum=18457ac2608ab548983c3266ae38e6397d1801773969a796a672e2d9c56c69c5
 
 build_options="icarus"
 build_options_default="icarus"
 
+pre_install() {
+	vlicense $wrksrc/LICENSE.txt
+}
+
 if [ "$build_option_icarus" ];then
 	post_build() {
 		cd $wrksrc/icarus

Re: higan: fix dead links

[meator]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/32888#issuecomment-922341187

Comment:
If I understand it correctly, all problems caused by running `make` as root are solved by `higan-paths.patch`, so pathing the root check out should be safe.

Re: higan: fix dead links

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/32888#issuecomment-922408079

Comment:
Looks about right, thanks.

@Johnnynator ok?

Re: higan: fix dead links

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/32888#issuecomment-924255917

Comment:
Should be okay for now. Will take a deeper look into the other quirks of the packages some time else, not much time for it right now.

Re: [PR PATCH] [Merged]: higan: fix dead links

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

There's a merged pull request on the void-packages repository

higan: fix dead links
https://github.com/void-linux/void-packages/pull/32888

Description:
<!-- Mark items with [x] where applicable -->
@Johnnynator I'm pinging you since you are the maintainer of `higan`. Do you have any comment on this?
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->