From: abenson <abenson@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New Package: NetworkManager-fortisslvpn-1.3.90
Date: Thu, 23 Sep 2021 06:43:39 +0200 [thread overview]
Message-ID: <20210923044339.KlRpyPkFDdcBDUy5Z1srGP0ySzvU8ki7ukrCskFDO3o@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33066@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
New review comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/33066#discussion_r714467407
Comment:
`_pppver` is never defined.
Also, you can probably drop all of `do_configure` and replace it with
configure_args="--libexecdir=/usr/lib/networkmanager --with-pppd-plugin-dir=/usr/lib/pppd/$_pppver"
next prev parent reply other threads:[~2021-09-23 4:43 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 4:39 [PR PATCH] " Twilighttony
2021-09-23 4:43 ` [PR REVIEW] " abenson
2021-09-23 4:43 ` abenson [this message]
2021-09-23 4:44 ` abenson
2021-09-23 4:51 ` cinerea0
2021-09-23 4:52 ` cinerea0
2021-09-23 4:53 ` Twilighttony
2021-09-23 5:10 ` [PR PATCH] [Updated] " Twilighttony
2021-09-23 5:22 ` Twilighttony
2021-09-23 5:23 ` [PR REVIEW] " Twilighttony
2021-09-23 16:53 ` cinerea0
2021-09-23 23:05 ` abenson
2021-09-23 23:14 ` [PR PATCH] [Updated] " Twilighttony
2021-09-24 21:29 ` Twilighttony
2021-09-24 23:58 ` [PR REVIEW] " Twilighttony
2021-09-25 3:05 ` abenson
2021-09-25 5:27 ` [PR PATCH] [Updated] " Twilighttony
2021-09-25 5:35 ` Twilighttony
2021-09-25 5:35 ` [PR REVIEW] " Twilighttony
2021-09-25 5:43 ` [PR PATCH] [Updated] " Twilighttony
2021-09-25 5:59 ` Twilighttony
2021-09-25 6:31 ` Twilighttony
2021-09-25 6:49 ` Twilighttony
2021-10-04 3:19 ` the-maldridge
2021-10-04 3:22 ` [PR PATCH] [Updated] " Twilighttony
2021-10-04 3:33 ` Twilighttony
2021-10-04 3:36 ` Twilighttony
2021-10-05 15:23 ` classabbyamp
2022-06-05 2:14 ` github-actions
2023-02-03 18:28 ` [PR REVIEW] " classabbyamp
2023-02-03 18:28 ` classabbyamp
2023-02-03 18:28 ` classabbyamp
2023-08-27 22:05 ` slimjimsoftware
2023-08-27 22:06 ` slimjimsoftware
2024-04-01 10:51 ` [PR REVIEW] " Eloitor
2024-04-01 10:51 ` Eloitor
2024-04-01 10:52 ` Eloitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923044339.KlRpyPkFDdcBDUy5Z1srGP0ySzvU8ki7ukrCskFDO3o@z \
--to=abenson@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).