From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: base-files: remove non-portable behaviour
Date: Fri, 24 Sep 2021 16:46:12 +0200 [thread overview]
Message-ID: <20210924144612.039c2AstZDp5jsqdIIl8y3hy1p53hLEJAlu2wkPO6tc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33088@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/33088#issuecomment-926685501
Comment:
Regardless of the availability of `install`, I generally prefer things like `mkdir` especially when the permissions are don't-care conditions. One can argue that `install` is preferable in the cases where you want specific permissions, but there are only two here and you've already shown that dropping `install` works around at least one issue.
You may want to set a umask in this function, since `install` guarantees a default mode of `755` but the `mkdir` might inherit a umask from the environment.
next prev parent reply other threads:[~2021-09-24 14:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 14:21 [PR PATCH] " paper42
2021-09-24 14:23 ` [PR REVIEW] " ericonr
2021-09-24 14:24 ` q66
2021-09-24 14:25 ` q66
2021-09-24 14:26 ` ericonr
2021-09-24 14:27 ` ericonr
2021-09-24 14:27 ` q66
2021-09-24 14:28 ` q66
2021-09-24 14:29 ` paper42
2021-09-24 14:31 ` q66
2021-09-24 14:34 ` [PR PATCH] [Updated] " paper42
2021-09-24 14:35 ` paper42
2021-09-24 14:37 ` ericonr
2021-09-24 14:39 ` [PR REVIEW] " q66
2021-09-24 14:39 ` q66
2021-09-24 14:46 ` ahesford
2021-09-24 14:46 ` ahesford [this message]
2021-09-24 14:59 ` paper42
2021-09-24 15:04 ` [PR REVIEW] " paper42
2021-09-24 15:06 ` ahesford
2021-09-24 15:10 ` [PR PATCH] [Updated] " paper42
2021-10-03 22:56 ` [PR REVIEW] " CameronNemo
2021-10-03 22:56 ` CameronNemo
2021-10-03 23:02 ` CameronNemo
2021-10-03 23:05 ` CameronNemo
2022-06-05 2:14 ` github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924144612.039c2AstZDp5jsqdIIl8y3hy1p53hLEJAlu2wkPO6tc@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).