Re: [PR PATCH] [Updated] [wip/rfc] perl: change config

[dkwo <dkwo@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages perl
https://github.com/void-linux/void-packages/pull/33089

[wip/rfc] perl: change config
At least when not cross-compiling, using `Configure` instead of `configure` gets rid of test errors on musl and i686.
Only one error left, the same for everybody:
```
Failed 1 test out of 2534, 99.96% okay.
	porting/checkcase.t
```
Do you think this is worth changing? @leahneukirchen 

A patch file from https://github.com/void-linux/void-packages/pull/33089.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-33089.patch --]
[-- Type: text/x-diff, Size: 1738 bytes --]

From c646c7bef9a3852400dcfd533f53a88d997da852 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Fri, 24 Sep 2021 15:07:06 +0200
Subject: [PATCH] perl: change config

---
 srcpkgs/perl/template | 32 +++++++++++++++++++-------------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/srcpkgs/perl/template b/srcpkgs/perl/template
index da223660988a..590936cf4328 100644
--- a/srcpkgs/perl/template
+++ b/srcpkgs/perl/template
@@ -160,10 +160,6 @@ do_configure() {
 		-Dman3dir=/usr/share/man/man3
 		-Dd_sockaddr_in6=define"
 
-	if [ "$CROSS_BUILD" ]; then
-		_args+=" --target=$XBPS_CROSS_TRIPLET"
-	fi
-
 	LDFLAGS+=" -Wl,-z,stack-size=2097152 -pthread"
 	export HOSTLDFLAGS+=" -pthread"
 
@@ -175,15 +171,25 @@ do_configure() {
 	fi
 
 	export LD="$CC"
-	./configure --prefix=/usr $_args \
-		-Dcccdlflags="-fPIC" \
-		-Doptimize=" -Wall ${CFLAGS} " -Dccflags=" ${CFLAGS} " \
-		-Dlddlflags="-shared ${LDFLAGS}" -Dldflags="${LDFLAGS}" \
-		-Dperl_static_inline='static __inline__' -Dd_static_inline ||
-	{
-		cat ./config.log
-		return 42
-	}
+	if [ "$CROSS_BUILD" ]; then
+		_args+=" --target=$XBPS_CROSS_TRIPLET"
+#		./configure --prefix=/usr $_args \
+#			-Dcccdlflags="-fPIC" \
+#			-Doptimize=" -Wall ${CFLAGS} " -Dccflags=" ${CFLAGS} " \
+#			-Dlddlflags="-shared ${LDFLAGS}" -Dldflags="${LDFLAGS}" \
+#			-Dperl_static_inline='static __inline__' -Dd_static_inline ||
+#		{
+#			cat ./config.log
+#			return 42
+#		}
+#	else
+fi
+		./Configure -des $_args \
+			-Dcccdlflags="-fPIC" \
+			-Doptimize=" -Wall ${CFLAGS} " -Dccflags=" ${CFLAGS} " \
+			-Dlddlflags="-shared ${LDFLAGS}" -Dldflags="${LDFLAGS}" \
+			-Dperl_static_inline='static __inline__' -Dd_static_inline
+#	fi
 }
 
 do_check() {