Github messages for voidlinux
 help / color / mirror / Atom feed
From: WitherCubes <WitherCubes@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] New package: nsxiv-27.1
Date: Sat, 25 Sep 2021 18:34:27 +0200	[thread overview]
Message-ID: <20210925163427.TvK71eR5ccL0cz--9QQmq17qf8f19nqKb7NctlMLj0A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33009@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

There is an updated pull request by WitherCubes against master on the void-packages repository

https://github.com/WitherCubes/void-packages master
https://github.com/void-linux/void-packages/pull/33009

New package: nsxiv-27.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33009.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-33009.patch --]
[-- Type: text/x-diff, Size: 3636 bytes --]

From cf20bff789a78e18a9a79425d223a54e50399de7 Mon Sep 17 00:00:00 2001
From: Sanjay Pavan <tsppavan7@gmail.com>
Date: Sat, 18 Sep 2021 11:48:37 +0530
Subject: [PATCH 1/2] New package: nsxiv-27.1

---
 .../nsxiv/patches/nsxiv-27.1-makefile.patch   | 31 +++++++++++++++++++
 srcpkgs/nsxiv/template                        | 22 +++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 srcpkgs/nsxiv/patches/nsxiv-27.1-makefile.patch
 create mode 100644 srcpkgs/nsxiv/template

diff --git a/srcpkgs/nsxiv/patches/nsxiv-27.1-makefile.patch b/srcpkgs/nsxiv/patches/nsxiv-27.1-makefile.patch
new file mode 100644
index 000000000000..83f09fe2d0f5
--- /dev/null
+++ b/srcpkgs/nsxiv/patches/nsxiv-27.1-makefile.patch
@@ -0,0 +1,31 @@
+--- a/Makefile	2021-09-22 17:00:05.123980000 +0530
++++ b/Makefile	2021-09-22 16:59:53.050646000 +0530
+@@ -86,7 +86,7 @@
+ 		>$(DESTDIR)$(MANPREFIX)/man1/nsxiv.1
+ 	chmod 644 $(DESTDIR)$(MANPREFIX)/man1/nsxiv.1
+ 	@echo "INSTALL share/nsxiv/"
+-	install -Dt $(DESTDIR)$(PREFIX)/share/nsxiv/exec exec/*
++	install -Dt $(DESTDIR)$(PREFIX)/share/doc/nsxiv/examples exec/*
+ 
+ uninstall:
+ 	@echo "REMOVE bin/nsxiv"
+--- a/nsxiv.1	2021-09-22 16:55:16.433967000 +0530
++++ b/nsxiv.1	2021-09-22 17:03:11.870655000 +0530
+@@ -428,7 +428,7 @@
+ 3) image height.
+ .P
+ There is also an example script installed together with nsxiv as
+-.IR PREFIX/share/nsxiv/exec/image-info .
++.IR PREFIX/share/doc/nsxiv/examples/image-info .
+ .SH EXTERNAL KEY HANDLER
+ Additional external keyboard commands can be defined using a handler program
+ located in
+@@ -446,7 +446,7 @@
+ keysym as listed in /usr/include/X11/keysymdef.h without the "XK_" prefix.
+ 
+ There is also an example script installed together with nsxiv as
+-.IR PREFIX/share/nsxiv/exec/key-handler .
++.IR PREFIX/share/doc/nsxiv/examples/key-handler .
+ .SH THUMBNAIL CACHING
+ nsxiv stores all thumbnails under
+ .IR $XDG_CACHE_HOME/nsxiv/ .
diff --git a/srcpkgs/nsxiv/template b/srcpkgs/nsxiv/template
new file mode 100644
index 000000000000..63c3786e2df6
--- /dev/null
+++ b/srcpkgs/nsxiv/template
@@ -0,0 +1,22 @@
+# Template file for 'nsxiv'
+pkgname=nsxiv
+version=27.1
+revision=1
+build_style=gnu-makefile
+makedepends="libX11-devel imlib2-devel giflib-devel libexif-devel libXft-devel"
+short_desc="Neo (or New or Not) Simple (or Small or Suckless) X Image Viewer"
+maintainer="Sanjay Pavan <tsppavan7@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/nsxiv/nsxiv"
+distfiles="https://github.com/nsxiv/nsxiv/archive/v${version}.tar.gz"
+checksum=416247c6930d2a5ba482010a7c095fc3e6fe0fe609f2bce0049f69bebd63e00c
+
+pre_build() {
+	[ -e ${FILESDIR}/config.h ] && cp ${FILESDIR}/config.h config.h ||:
+}
+
+post_install() {
+	vinstall nsxiv.desktop 644 usr/share/applications
+}
+
+CFLAGS="${XBPS_CROSS_BASE}/usr/include/freetype2"

From 717950b685314a7a06c78ffd30cb884fb15fa162 Mon Sep 17 00:00:00 2001
From: Sanjay Pavan <72592921+WitherCubes@users.noreply.github.com>
Date: Sat, 25 Sep 2021 22:04:25 +0530
Subject: [PATCH 2/2] Trying the Fix for failed checks

I will squash the commits and make them clean if this check passes

Co-authored-by: Michal Vasilek <michal@vasilek.cz>
---
 srcpkgs/nsxiv/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/nsxiv/template b/srcpkgs/nsxiv/template
index 63c3786e2df6..985d9302bbc1 100644
--- a/srcpkgs/nsxiv/template
+++ b/srcpkgs/nsxiv/template
@@ -19,4 +19,4 @@ post_install() {
 	vinstall nsxiv.desktop 644 usr/share/applications
 }
 
-CFLAGS="${XBPS_CROSS_BASE}/usr/include/freetype2"
+CFLAGS="-I${XBPS_CROSS_BASE}/usr/include/freetype2"

  parent reply	other threads:[~2021-09-25 16:34 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18  6:23 [PR PATCH] " WitherCubes
2021-09-21  1:29 ` WitherCubes
2021-09-21  7:05 ` paper42
2021-09-21  7:06 ` paper42
2021-09-21  7:16 ` paper42
2021-09-21 11:41 ` WitherCubes
2021-09-21 18:00 ` [PR REVIEW] " Johnnynator
2021-09-21 19:46 ` N-R-K
2021-09-21 19:53 ` paper42
2021-09-21 20:00 ` N-R-K
2021-09-21 20:04 ` paper42
2021-09-21 20:09 ` N-R-K
2021-09-21 20:09 ` N-R-K
2021-09-21 22:22 ` eylles
2021-09-21 23:08 ` N-R-K
2021-09-22 11:58 ` [PR PATCH] [Updated] " WitherCubes
2021-09-22 12:00 ` WitherCubes
2021-09-22 20:27 ` N-R-K
2021-09-24 14:54 ` [PR PATCH] [Updated] " WitherCubes
2021-09-24 14:56 ` [PR REVIEW] " WitherCubes
2021-09-24 15:27 ` paper42
2021-09-24 15:42 ` WitherCubes
2021-09-24 15:43 ` WitherCubes
2021-09-24 15:49 ` [PR PATCH] [Updated] " WitherCubes
2021-09-24 15:53 ` WitherCubes
2021-09-24 16:04 ` WitherCubes
2021-09-24 16:07 ` WitherCubes
2021-09-25 15:01 ` [PR REVIEW] " paper42
2021-09-25 16:34 ` WitherCubes [this message]
2021-09-25 16:53 ` WitherCubes
2021-09-25 17:06 ` [PR PATCH] [Updated] " WitherCubes
2021-09-25 17:07 ` WitherCubes
2021-09-25 17:28 ` [PR PATCH] [Updated] " WitherCubes
2021-09-28  9:44 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210925163427.TvK71eR5ccL0cz--9QQmq17qf8f19nqKb7NctlMLj0A@z \
    --to=withercubes@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).