From: mtboehlke <mtboehlke@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] xrdb: update to 1.2.1
Date: Thu, 30 Sep 2021 03:39:11 +0200 [thread overview]
Message-ID: <20210930013911.gBOTR0Wmt54hQUTsMTqaRBevHOGux1f-Z6g_4OVQIEY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33143@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
New review comment by mtboehlke on void-packages repository
https://github.com/void-linux/void-packages/pull/33143#discussion_r718995285
Comment:
I like the idea of including clang-cpp. I did some minimal testing with some `#include` and `#ifdef` directives, and made sure the `-I` and `-D` flags work, but as far as I can tell clang-cpp works too. I have cpp preferred first, since it is probably the expected default, then clang-cpp, and then use mcpp as fallback.
next prev parent reply other threads:[~2021-09-30 1:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33143@inbox.vuxu.org>
2021-09-27 1:05 ` mtboehlke
2021-09-29 22:25 ` ericonr
2021-09-30 1:33 ` [PR PATCH] [Updated] " mtboehlke
2021-09-30 1:39 ` mtboehlke [this message]
2021-09-30 1:39 ` [PR REVIEW] " mtboehlke
2021-09-30 1:44 ` mtboehlke
2021-09-30 1:44 ` mtboehlke
2021-10-01 8:26 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930013911.gBOTR0Wmt54hQUTsMTqaRBevHOGux1f-Z6g_4OVQIEY@z \
--to=mtboehlke@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).