From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: soju-0.2.1
Date: Mon, 04 Oct 2021 13:24:47 +0200 [thread overview]
Message-ID: <20211004112447.0QCJCuKjVs1ypNIUJGTcQnpBayK2zr5OF3ZgT3h98YU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33302@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33302#discussion_r721271017
Comment:
> Is it usually how go packages are built, even if developers provide a Makefile?
If you use the makefile, you will have to make sure it cross compiles properly and applies the correct flags which is not worth the added complexity. Not using the makefile is better, but not ideal. Some projects have a target in the makefile which doesn't touch the go part and installs only the config file, manpage etc.
> Does this mean I should ignore the flags recommend here for packaging go applications?
That's a guide for Arch Linux, I don't see why this is relevant here. The go build style will apply the flags we want.
next prev parent reply other threads:[~2021-10-04 11:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 21:43 [PR PATCH] " flupe
2021-10-03 22:52 ` Vaelatern
2021-10-04 8:12 ` [PR PATCH] [Updated] " flupe
2021-10-04 8:14 ` flupe
2021-10-04 11:14 ` [PR REVIEW] " flupe
2021-10-04 11:24 ` paper42 [this message]
2021-10-04 11:27 ` paper42
2021-10-04 12:41 ` [PR PATCH] [Updated] " flupe
2021-10-04 12:47 ` flupe
2021-10-04 16:31 ` Duncaen
2021-10-04 16:32 ` Duncaen
2021-10-04 18:13 ` flupe
2021-10-04 18:49 ` flupe
2021-10-04 19:28 ` [PR PATCH] [Updated] " flupe
2021-10-04 19:30 ` flupe
2021-10-04 19:39 ` Duncaen
2021-10-04 21:25 ` [PR PATCH] [Updated] " flupe
2021-10-04 21:26 ` flupe
2021-10-04 21:50 ` [PR REVIEW] " Duncaen
2021-10-04 22:52 ` flupe
2021-10-04 22:58 ` [PR PATCH] [Updated] " flupe
2021-10-04 23:33 ` [PR REVIEW] " Duncaen
2021-10-04 23:35 ` Duncaen
2021-10-04 23:35 ` Duncaen
2021-10-05 10:26 ` [PR PATCH] [Updated] " flupe
2021-11-20 22:57 ` Duncaen
2021-11-20 22:58 ` Duncaen
2021-11-21 8:42 ` [PR PATCH] [Updated] " flupe
2021-11-21 8:48 ` flupe
2021-11-21 8:53 ` New package: soju-0.3.0 flupe
2021-11-21 17:35 ` [PR PATCH] [Merged]: " Vaelatern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004112447.0QCJCuKjVs1ypNIUJGTcQnpBayK2zr5OF3ZgT3h98YU@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).