From: mobinmob <mobinmob@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: Ananicy
Date: Mon, 04 Oct 2021 20:08:16 +0200 [thread overview]
Message-ID: <20211004180816.vYVI7s9vMx8x9wZJqYeXiOfL0pRau_d9bMMjXvi0gGI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33301@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
New review comment by mobinmob on void-packages repository
https://github.com/void-linux/void-packages/pull/33301#discussion_r721599543
Comment:
I think that is a bad idea, because it leads to a service that does not really work ootb. The script currently follows what the [upstream systemd service](https://github.com/Nefelim4ag/Ananicy/blob/master/ananicy.service) does, but uses printf instead of sysctl as the later is not exactly suited for use in chainloading...
I cooperated with @linuxer in order to create and test an [ananicy service](https://github.com/mobinmob/void-66-services/blob/devel/usr/share/66/service/ananicy) for void-66-services. In an execline script sysctl is used in an if block. In a posix shell script, printf seems like a good choice.
next prev parent reply other threads:[~2021-10-04 18:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 20:28 [PR PATCH] " linuxergr
2021-10-04 11:19 ` [PR REVIEW] " paper42
2021-10-04 11:19 ` paper42
2021-10-04 11:19 ` paper42
2021-10-04 11:19 ` paper42
2021-10-04 15:29 ` Duncaen
2021-10-04 15:29 ` Duncaen
2021-10-04 17:52 ` linuxergr
2021-10-04 17:58 ` linuxergr
2021-10-04 18:08 ` mobinmob [this message]
2021-10-04 18:09 ` mobinmob
2021-10-04 18:10 ` mobinmob
2021-10-04 18:12 ` linuxergr
2021-10-04 18:16 ` mobinmob
2021-10-04 18:33 ` linuxergr
2021-10-04 19:21 ` [PR PATCH] [Updated] " linuxergr
2021-10-04 19:32 ` [PR REVIEW] " linuxergr
2021-10-06 7:54 ` paper42
2022-02-06 21:54 ` paper42
2022-02-06 21:54 ` paper42
2022-02-08 0:47 ` linuxergr
2022-02-16 6:47 ` [PR PATCH] [Updated] " linuxergr
2022-06-06 2:15 ` github-actions
2022-06-21 2:12 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004180816.vYVI7s9vMx8x9wZJqYeXiOfL0pRau_d9bMMjXvi0gGI@z \
--to=mobinmob@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).