Re: [PR PATCH] [Updated] cargo-about: update to 0.3.0.

Re: [PR PATCH] [Updated] cargo-about: update to 0.3.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages cargo-about-0.3.0_1
https://github.com/void-linux/void-packages/pull/30324

cargo-about: update to 0.3.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cargo-about-0.3.0_1-30324.patch --]
[-- Type: text/x-diff, Size: 1275 bytes --]

From faae996b3b587d8a016c1f3f9e71ed6b646486e2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Mon, 19 Apr 2021 14:06:42 +0200
Subject: [PATCH] cargo-about: update to 0.3.0.

---
 srcpkgs/cargo-about/template | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cargo-about/template b/srcpkgs/cargo-about/template
index 7018e3e92932..0ec3b2b69f44 100644
--- a/srcpkgs/cargo-about/template
+++ b/srcpkgs/cargo-about/template
@@ -1,6 +1,6 @@
 # Template file for 'cargo-about'
 pkgname=cargo-about
-version=0.2.3
+version=0.3.0
 revision=1
 build_style=cargo
 short_desc="Cargo plugin to generate list of all licenses for a crate"
@@ -8,7 +8,12 @@ maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT, Apache-2.0"
 homepage="https://github.com/EmbarkStudios/cargo-about"
 distfiles="https://github.com/EmbarkStudios/cargo-about/archive/${version}.tar.gz"
-checksum=e39528da6826ddb609165866858984578ebbf80819b136d66215e840c69621c7
+checksum=01c5c78e4486b6de5694c0f140cab4b0f6efb807736a64602636a2266e2f015b
+
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+	makedepends+=" libatomic-devel"
+	LDFLAGS+=" -latomic"
+fi
 
 post_install() {
 	vlicense LICENSE-APACHE

Re: cargo-about: update to 0.3.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/30324#issuecomment-826290617

Comment:
> Needs `libatomic-devel` and `LDFLAGS=-latomic` for `XBPS_TARGET_NO_ATOMIC8`.

@ericonr how did you figure that out? The failed build doesn't show any logs for me for some reason, so I couldn't see where it failed..

Re: cargo-about: update to 0.3.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/30324#issuecomment-826292363

Comment:
Oh, it still errors on armv6-musl..

Re: cargo-about: update to 0.3.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 2899 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30324#issuecomment-826343499

Comment:
```
stats.c:(.text.mi_stat_update.part.0+0xcc): undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: stats.c:(.text.mi_stat_update.part.0+0xe8): undefined reference to `__atomic_load_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: stats.c:(.text.mi_stat_update.part.0+0x11c): undefined reference to `__atomic_compare_exchange_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: stats.c:(.text.mi_stat_update.part.0+0x14c): undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: stats.c:(.text.mi_stat_update.part.0+0x16c): undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: /builddir/cargo-about-0.3.0/target/arm-unknown-linux-musleabihf/release/deps/liblibmimalloc_sys-707880f4e08a2449.rlib(stats.o): in function `mi_stat_add.constprop.0':
          stats.c:(.text.mi_stat_add.constprop.0+0x48): undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: stats.c:(.text.mi_stat_add.constprop.0+0x58): undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: stats.c:(.text.mi_stat_add.constprop.0+0x68): undefined reference to `__atomic_fetch_add_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: /builddir/cargo-about-0.3.0/target/arm-unknown-linux-musleabihf/release/deps/liblibmimalloc_sys-707880f4e08a2449.rlib(stats.o):stats.c:(.text.mi_stat_add.constprop.0+0x78): more undefined references to `__atomic_fetch_add_8' follow
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: /builddir/cargo-about-0.3.0/target/arm-unknown-linux-musleabihf/release/deps/liblibmimalloc_sys-707880f4e08a2449.rlib(stats.o): in function `mi_stat_process_info':
          stats.c:(.text.mi_stat_process_info+0xb4): undefined reference to `__atomic_load_8'
          /usr/lib/gcc/arm-linux-musleabihf/10.2.1/../../../../arm-linux-musleabihf/bin/ld: stats.c:(.text.mi_stat_process_info+0xc8): undefined reference to `__atomic_load_8'
          collect2: error: ld returned 1 exit status
          

error: aborting due to previous error

error: could not compile `cargo-about`

To learn more, run the command again with --verbose.
=> ERROR: cargo-about-0.3.0_1: do_build: '${make_cmd} build --release --target ${RUST_TARGET} ${configure_args}' exited with 101
```

Re: cargo-about: update to 0.3.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30324#issuecomment-873685814

Comment:
Ping

Re: cargo-about: update to 0.3.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/30324#issuecomment-897157661

Comment:
I can't seem to figure this out, sorry.. I don't think `LDFLAGS` is respected in the cargo build-style, and my attempts to pass `-latomic` to `ld` with a `.cargo/config.toml` seem to all fail. Any hints how to tackle this?

Re: cargo-about: update to 0.3.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30324#issuecomment-897220755

Comment:
There's a neat workaround called `broken="can't be made to link libatomic"` :p 

You can also inspect the code to try and find the place where it's unnecessarily using 64-bit atomics instead of `usize` atomics.

Re: [PR PATCH] [Updated] cargo-about: update to 0.3.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages cargo-about-0.3.0_1
https://github.com/void-linux/void-packages/pull/30324

cargo-about: update to 0.3.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cargo-about-0.3.0_1-30324.patch --]
[-- Type: text/x-diff, Size: 1268 bytes --]

From c5b54946793a7d25196441c0fd93c283e2ad53f1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Mon, 19 Apr 2021 14:06:42 +0200
Subject: [PATCH] cargo-about: update to 0.3.0.

---
 srcpkgs/cargo-about/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cargo-about/template b/srcpkgs/cargo-about/template
index 7018e3e92932..27eddbd2cfc4 100644
--- a/srcpkgs/cargo-about/template
+++ b/srcpkgs/cargo-about/template
@@ -1,6 +1,6 @@
 # Template file for 'cargo-about'
 pkgname=cargo-about
-version=0.2.3
+version=0.3.0
 revision=1
 build_style=cargo
 short_desc="Cargo plugin to generate list of all licenses for a crate"
@@ -8,7 +8,11 @@ maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT, Apache-2.0"
 homepage="https://github.com/EmbarkStudios/cargo-about"
 distfiles="https://github.com/EmbarkStudios/cargo-about/archive/${version}.tar.gz"
-checksum=e39528da6826ddb609165866858984578ebbf80819b136d66215e840c69621c7
+checksum=01c5c78e4486b6de5694c0f140cab4b0f6efb807736a64602636a2266e2f015b
+
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+	broken="broken on architectures without atomic8"
+fi
 
 post_install() {
 	vlicense LICENSE-APACHE

Re: [PR PATCH] [Updated] cargo-about: update to 0.3.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages cargo-about-0.3.0_1
https://github.com/void-linux/void-packages/pull/30324

cargo-about: update to 0.3.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cargo-about-0.3.0_1-30324.patch --]
[-- Type: text/x-diff, Size: 1268 bytes --]

From e5d4cd674480ce316123a26468fb7e9b092d636b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Mon, 19 Apr 2021 14:06:42 +0200
Subject: [PATCH] cargo-about: update to 0.3.0.

---
 srcpkgs/cargo-about/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/cargo-about/template b/srcpkgs/cargo-about/template
index 7018e3e92932..27eddbd2cfc4 100644
--- a/srcpkgs/cargo-about/template
+++ b/srcpkgs/cargo-about/template
@@ -1,6 +1,6 @@
 # Template file for 'cargo-about'
 pkgname=cargo-about
-version=0.2.3
+version=0.3.0
 revision=1
 build_style=cargo
 short_desc="Cargo plugin to generate list of all licenses for a crate"
@@ -8,7 +8,11 @@ maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT, Apache-2.0"
 homepage="https://github.com/EmbarkStudios/cargo-about"
 distfiles="https://github.com/EmbarkStudios/cargo-about/archive/${version}.tar.gz"
-checksum=e39528da6826ddb609165866858984578ebbf80819b136d66215e840c69621c7
+checksum=01c5c78e4486b6de5694c0f140cab4b0f6efb807736a64602636a2266e2f015b
+
+if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
+	broken="broken on architectures without atomic8"
+fi
 
 post_install() {
 	vlicense LICENSE-APACHE

Re: [PR PATCH] [Merged]: cargo-about: update to 0.3.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

There's a merged pull request on the void-packages repository

cargo-about: update to 0.3.0.
https://github.com/void-linux/void-packages/pull/30324

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->