From: CameronNemo <CameronNemo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: rockpro64-base and rockpro64-uboot
Date: Tue, 12 Oct 2021 19:01:29 +0200 [thread overview]
Message-ID: <20211012170129.vt8iqGdPZAm1GWmZVjtNa6qkIIJJFkwYBqQhzk25jkY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33494@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/33494#issuecomment-941199273
Comment:
>When building the packages I specified "-a aarch64" to "./xbps-src" to build the packages for arm64. I believe that makes it a crossbuild as it was not built on a native arm64 platform.
Yeah that was a cross build on glibc.
We like to have the commit messages have a specific format. Right now this branch has 8 commits with a lot of merge commits. You should only have two commits (in the same branch/PR), as I mentioned before. Always rebase commits on master, do not merge master into your branch. You should probably review the [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md) document in this repo.
next prev parent reply other threads:[~2021-10-12 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 7:53 [PR PATCH] " tiemenwerkman
2021-10-12 17:01 ` CameronNemo [this message]
2021-10-13 9:17 ` [PR PATCH] [Closed]: " tiemenwerkman
2021-10-13 16:00 ` CameronNemo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012170129.vt8iqGdPZAm1GWmZVjtNa6qkIIJJFkwYBqQhzk25jkY@z \
--to=cameronnemo@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).