Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-gmpy2: restore package
@ 2021-10-11 15:29 tornaria
  2021-10-11 15:31 ` [PR PATCH] [Updated] " tornaria
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: tornaria @ 2021-10-11 15:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages gmpy2
https://github.com/void-linux/void-packages/pull/33481

python3-gmpy2: restore package
Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt

A patch file from https://github.com/void-linux/void-packages/pull/33481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmpy2-33481.patch --]
[-- Type: text/x-diff, Size: 1993 bytes --]

From 2f41a6ce64a74046f2e6982a5f6816bcfa912465 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 10:55:20 -0300
Subject: [PATCH] python3-gmpy2: restore package

Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt
---
 srcpkgs/python3-gmpy2/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-gmpy2/template

diff --git a/srcpkgs/python3-gmpy2/template b/srcpkgs/python3-gmpy2/template
new file mode 100644
index 000000000000..80e85f1dadc4
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-gmpy2'
+pkgname=python3-gmpy2
+version=2.1.0rc1
+revision=1
+wrksrc="gmpy2-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel gmp-devel mpfr-devel libmpc-devel"
+short_desc="Python3 interface to GMP, MPFR and MPC libraries"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+homepage="https://github.com/aleaxit/gmpy"
+license="LGPL-3.0-or-later"
+distfiles="${PYPI_SITE}/g/gmpy2/gmpy2-${version}.tar.gz"
+checksum=86cb6d8e5837560c32c706d48d6ed25676be6b3c79e6aa5d245965b9e99231b9
+
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" \
+		python3 test/runtests.py
+}

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
@ 2021-10-11 15:31 ` tornaria
  2021-10-11 15:52 ` ahesford
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-11 15:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages gmpy2
https://github.com/void-linux/void-packages/pull/33481

python3-gmpy2: restore package
Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt

A patch file from https://github.com/void-linux/void-packages/pull/33481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmpy2-33481.patch --]
[-- Type: text/x-diff, Size: 1993 bytes --]

From 6040b587c09b9c70cd8b9c91453681f4f4193b92 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 10:55:20 -0300
Subject: [PATCH] python3-gmpy2: restore package

Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt
---
 srcpkgs/python3-gmpy2/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-gmpy2/template

diff --git a/srcpkgs/python3-gmpy2/template b/srcpkgs/python3-gmpy2/template
new file mode 100644
index 000000000000..c86a5639e25d
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-gmpy2'
+pkgname=python3-gmpy2
+version=2.1.0rc1
+revision=1
+wrksrc="gmpy2-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel gmp-devel mpfr-devel libmpc-devel"
+short_desc="Python3 interface to GMP, MPFR and MPC libraries"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="LGPL-3.0-or-later"
+homepage="https://github.com/aleaxit/gmpy"
+distfiles="${PYPI_SITE}/g/gmpy2/gmpy2-${version}.tar.gz"
+checksum=86cb6d8e5837560c32c706d48d6ed25676be6b3c79e6aa5d245965b9e99231b9
+
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" \
+		python3 test/runtests.py
+}

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
  2021-10-11 15:31 ` [PR PATCH] [Updated] " tornaria
@ 2021-10-11 15:52 ` ahesford
  2021-10-11 15:57 ` [PR PATCH] [Updated] " tornaria
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ahesford @ 2021-10-11 15:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-940149500

Comment:
No complaints from me about restoring the package. Please add a commit that drops the line from `removed-packages` as well. No need to revbump and it won't have any practical effect, but I think it avoids some confusion if people look at the list of `replaces` and don't find packages that still exist.

I'm on the fence about requiring it in `python3-mpmath`. On the one hand, it would be nice to know where the package is useful. On the other, removing the package doesn't break anything, just makes mpmath intolerably slow. I guess we should leave it out for now.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
  2021-10-11 15:31 ` [PR PATCH] [Updated] " tornaria
  2021-10-11 15:52 ` ahesford
@ 2021-10-11 15:57 ` tornaria
  2021-10-11 16:01 ` tornaria
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-11 15:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages gmpy2
https://github.com/void-linux/void-packages/pull/33481

python3-gmpy2: restore package
Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt

A patch file from https://github.com/void-linux/void-packages/pull/33481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmpy2-33481.patch --]
[-- Type: text/x-diff, Size: 3048 bytes --]

From 798728176ad8a389f3dab334d42c2a1fcdafa100 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 10:55:20 -0300
Subject: [PATCH 1/2] python3-gmpy2: restore package

Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt
---
 srcpkgs/python3-gmpy2/template | 19 +++++++++++++++++++
 srcpkgs/python3-gmpy2/update   |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 srcpkgs/python3-gmpy2/template
 create mode 100644 srcpkgs/python3-gmpy2/update

diff --git a/srcpkgs/python3-gmpy2/template b/srcpkgs/python3-gmpy2/template
new file mode 100644
index 000000000000..c86a5639e25d
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-gmpy2'
+pkgname=python3-gmpy2
+version=2.1.0rc1
+revision=1
+wrksrc="gmpy2-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel gmp-devel mpfr-devel libmpc-devel"
+short_desc="Python3 interface to GMP, MPFR and MPC libraries"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="LGPL-3.0-or-later"
+homepage="https://github.com/aleaxit/gmpy"
+distfiles="${PYPI_SITE}/g/gmpy2/gmpy2-${version}.tar.gz"
+checksum=86cb6d8e5837560c32c706d48d6ed25676be6b3c79e6aa5d245965b9e99231b9
+
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" \
+		python3 test/runtests.py
+}
diff --git a/srcpkgs/python3-gmpy2/update b/srcpkgs/python3-gmpy2/update
new file mode 100644
index 000000000000..b5703618d280
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/update
@@ -0,0 +1 @@
+ignore="*a[1-9] *b[1-9] *rc[1-9]"

From 04834bbd70bd97790fa35da33832f70f5b16e05a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 12:57:04 -0300
Subject: [PATCH 2/2] removed-packages: restore python3-gmpy2

---
 srcpkgs/removed-packages/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 3e1adba6f210..a912baf9bb6a 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -260,7 +260,6 @@ replaces="
  python3-SPARQLWrapper<=1.8.4_4
  python3-bluez<=0.23_2
  python3-grako<=3.99.9_7
- python3-gmpy2<=2.0.8_8
  python3-keepalive<=0.5_6
  python3-pyPEG2<=2.15.2_7
  python3-pyenet<=5.15.0_2

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (2 preceding siblings ...)
  2021-10-11 15:57 ` [PR PATCH] [Updated] " tornaria
@ 2021-10-11 16:01 ` tornaria
  2021-10-11 18:43 ` tornaria
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-11 16:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-940156589

Comment:
I changed the first commit to add a `update` file.

I added a second commit to remove python3-gmpy2 from `removed-packages`.

I agree there's no need for mpmath to depend on gmpy2. The functionality is all the same, except for slowdown when doing arithmetic with very large precision.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (3 preceding siblings ...)
  2021-10-11 16:01 ` tornaria
@ 2021-10-11 18:43 ` tornaria
  2021-10-11 21:00 ` [PR PATCH] [Updated] " tornaria
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-11 18:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-940356494

Comment:
BTW, there are some tests failing in `python3` for `x86_64-musl`:
```
6 tests failed:
    test__locale test_c_locale_coercion test_locale test_os test_re
    test_threading
```
Is it worth fixing? Ignoring?

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (4 preceding siblings ...)
  2021-10-11 18:43 ` tornaria
@ 2021-10-11 21:00 ` tornaria
  2021-10-12 18:57 ` ericonr
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-11 21:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages gmpy2
https://github.com/void-linux/void-packages/pull/33481

python3-gmpy2: restore package
Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt

A patch file from https://github.com/void-linux/void-packages/pull/33481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmpy2-33481.patch --]
[-- Type: text/x-diff, Size: 3048 bytes --]

From d4d35a7514e202b4675b14d26ea54e36dc7d097f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 10:55:20 -0300
Subject: [PATCH 1/2] python3-gmpy2: restore package

Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt
---
 srcpkgs/python3-gmpy2/template | 19 +++++++++++++++++++
 srcpkgs/python3-gmpy2/update   |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 srcpkgs/python3-gmpy2/template
 create mode 100644 srcpkgs/python3-gmpy2/update

diff --git a/srcpkgs/python3-gmpy2/template b/srcpkgs/python3-gmpy2/template
new file mode 100644
index 000000000000..c86a5639e25d
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-gmpy2'
+pkgname=python3-gmpy2
+version=2.1.0rc1
+revision=1
+wrksrc="gmpy2-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel gmp-devel mpfr-devel libmpc-devel"
+short_desc="Python3 interface to GMP, MPFR and MPC libraries"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="LGPL-3.0-or-later"
+homepage="https://github.com/aleaxit/gmpy"
+distfiles="${PYPI_SITE}/g/gmpy2/gmpy2-${version}.tar.gz"
+checksum=86cb6d8e5837560c32c706d48d6ed25676be6b3c79e6aa5d245965b9e99231b9
+
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" \
+		python3 test/runtests.py
+}
diff --git a/srcpkgs/python3-gmpy2/update b/srcpkgs/python3-gmpy2/update
new file mode 100644
index 000000000000..b5703618d280
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/update
@@ -0,0 +1 @@
+ignore="*a[1-9] *b[1-9] *rc[1-9]"

From 0c359fe7510cc9911e0911d5d045e99002e6ac6c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 12:57:04 -0300
Subject: [PATCH 2/2] removed-packages: restore python3-gmpy2

---
 srcpkgs/removed-packages/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 3e1adba6f210..a912baf9bb6a 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -260,7 +260,6 @@ replaces="
  python3-SPARQLWrapper<=1.8.4_4
  python3-bluez<=0.23_2
  python3-grako<=3.99.9_7
- python3-gmpy2<=2.0.8_8
  python3-keepalive<=0.5_6
  python3-pyPEG2<=2.15.2_7
  python3-pyenet<=5.15.0_2

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (5 preceding siblings ...)
  2021-10-11 21:00 ` [PR PATCH] [Updated] " tornaria
@ 2021-10-12 18:57 ` ericonr
  2021-10-12 19:19 ` [PR PATCH] [Updated] " tornaria
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-10-12 18:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-941297407

Comment:
> removed-packages: restore python3-gmpy2

I think the commit should be "remove python3-gmpy2" instead and the commit body should mention the package has been restored. Makes it clearer IMO.

Since ahesford was on the fence, I think `mpmath` should depend on `gmpy2`. It's a very reasonable default, and most people installing `mpmath` will have a huge python suite of scientific computing stuff already installed, so the size difference should be negible.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Updated] python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (6 preceding siblings ...)
  2021-10-12 18:57 ` ericonr
@ 2021-10-12 19:19 ` tornaria
  2021-10-12 19:32 ` tornaria
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-12 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages gmpy2
https://github.com/void-linux/void-packages/pull/33481

python3-gmpy2: restore package
Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt

A patch file from https://github.com/void-linux/void-packages/pull/33481.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmpy2-33481.patch --]
[-- Type: text/x-diff, Size: 3088 bytes --]

From d4d35a7514e202b4675b14d26ea54e36dc7d097f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 10:55:20 -0300
Subject: [PATCH 1/2] python3-gmpy2: restore package

Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt
---
 srcpkgs/python3-gmpy2/template | 19 +++++++++++++++++++
 srcpkgs/python3-gmpy2/update   |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 srcpkgs/python3-gmpy2/template
 create mode 100644 srcpkgs/python3-gmpy2/update

diff --git a/srcpkgs/python3-gmpy2/template b/srcpkgs/python3-gmpy2/template
new file mode 100644
index 000000000000..c86a5639e25d
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-gmpy2'
+pkgname=python3-gmpy2
+version=2.1.0rc1
+revision=1
+wrksrc="gmpy2-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+makedepends="python3-devel gmp-devel mpfr-devel libmpc-devel"
+short_desc="Python3 interface to GMP, MPFR and MPC libraries"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="LGPL-3.0-or-later"
+homepage="https://github.com/aleaxit/gmpy"
+distfiles="${PYPI_SITE}/g/gmpy2/gmpy2-${version}.tar.gz"
+checksum=86cb6d8e5837560c32c706d48d6ed25676be6b3c79e6aa5d245965b9e99231b9
+
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" \
+		python3 test/runtests.py
+}
diff --git a/srcpkgs/python3-gmpy2/update b/srcpkgs/python3-gmpy2/update
new file mode 100644
index 000000000000..b5703618d280
--- /dev/null
+++ b/srcpkgs/python3-gmpy2/update
@@ -0,0 +1 @@
+ignore="*a[1-9] *b[1-9] *rc[1-9]"

From 5253446a910e95d3d93c91e1a7b97786468c9c60 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 12:57:04 -0300
Subject: [PATCH 2/2] removed-packages: remove python3-gmpy2

... since the package has been restored.
---
 srcpkgs/removed-packages/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 3e1adba6f210..a912baf9bb6a 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -260,7 +260,6 @@ replaces="
  python3-SPARQLWrapper<=1.8.4_4
  python3-bluez<=0.23_2
  python3-grako<=3.99.9_7
- python3-gmpy2<=2.0.8_8
  python3-keepalive<=0.5_6
  python3-pyPEG2<=2.15.2_7
  python3-pyenet<=5.15.0_2

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (7 preceding siblings ...)
  2021-10-12 19:19 ` [PR PATCH] [Updated] " tornaria
@ 2021-10-12 19:32 ` tornaria
  2021-10-12 19:52 ` ericonr
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-12 19:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-941356325

Comment:
> I think the commit should be "remove python3-gmpy2" instead and the commit body should mention the package has been restored. Makes it clearer IMO.

Done.

> Since ahesford was on the fence, I think `mpmath` should depend on `gmpy2`. It's a very reasonable default, and most people installing `mpmath` will have a huge python suite of scientific computing stuff already installed, so the size difference should be negible.

Should we also make it depend on python3-matplotlib, as that enables plotting, as in
```
>>> from mpmath import *
>>> plot([cos,sin],[-4,4])
```
Note installing python3-matplotlib also improves plotting in sympy.

I almost miss the "recommends" and "suggests" entries in debian packages.



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (8 preceding siblings ...)
  2021-10-12 19:32 ` tornaria
@ 2021-10-12 19:52 ` ericonr
  2021-10-12 20:11 ` tornaria
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2021-10-12 19:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-941391172

Comment:
I find sympy's terminal plotting charming, and in that case what's missing is pretty clear. Missing performance, otoh, isn't as clear.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (9 preceding siblings ...)
  2021-10-12 19:52 ` ericonr
@ 2021-10-12 20:11 ` tornaria
  2021-10-13 18:38 ` [PR PATCH] [Closed]: " ahesford
  2021-10-13 18:39 ` ahesford
  12 siblings, 0 replies; 14+ messages in thread
From: tornaria @ 2021-10-12 20:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-941443311

Comment:
> I find sympy's terminal plotting charming, and in that case what's missing is pretty clear.

Indeed. And although mpmath doesn't have ascii art plotting, it gives a clear error message (```No module named 'pylab'```, which is easy to trace back to matplotlib using xlocate).

> Missing performance, otoh, isn't as clear.

Fair enough; I can do a PR for mpmath later (unless you prefer it to be here).

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PR PATCH] [Closed]: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (10 preceding siblings ...)
  2021-10-12 20:11 ` tornaria
@ 2021-10-13 18:38 ` ahesford
  2021-10-13 18:39 ` ahesford
  12 siblings, 0 replies; 14+ messages in thread
From: ahesford @ 2021-10-13 18:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

There's a closed pull request on the void-packages repository

python3-gmpy2: restore package
https://github.com/void-linux/void-packages/pull/33481

Description:
Upstream 2.1.0rc1 builds on python3.10.

This package is used by python3-mpmath for multiprecission arithmetic.
If not installed, mpmath defaults to python bigints which are very slow.

For example: compute 1M digits of pi using sympy:

$ isympy	# without python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 49.4 s, sys: 2.96 ms, total: 49.4 s
Wall time: 49.4 s

vs.

$ isympy	# with python3-gmpy2
In [1]: %time a=pi.n(1_000_000)
CPU times: user 632 ms, sys: 5.99 ms, total: 638 ms
Wall time: 639 ms

Note that just installing python3-gmpy2 brings this improvement.
Arguably python3-gmpy2 could be made a dependency of python3-mpmath.

This reverts commit f91cea99ddace872a5cdf0ae5d93fcc15b2f3191.

Also:
 - fix hostmakedepends
 - make tests work
 - adopt

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: python3-gmpy2: restore package
  2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
                   ` (11 preceding siblings ...)
  2021-10-13 18:38 ` [PR PATCH] [Closed]: " ahesford
@ 2021-10-13 18:39 ` ahesford
  12 siblings, 0 replies; 14+ messages in thread
From: ahesford @ 2021-10-13 18:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/33481#issuecomment-942606816

Comment:
I made two minor changes: 1) add `python3` to depends, and 2) add the updated version to the commit subject line.

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-10-13 18:39 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 15:29 [PR PATCH] python3-gmpy2: restore package tornaria
2021-10-11 15:31 ` [PR PATCH] [Updated] " tornaria
2021-10-11 15:52 ` ahesford
2021-10-11 15:57 ` [PR PATCH] [Updated] " tornaria
2021-10-11 16:01 ` tornaria
2021-10-11 18:43 ` tornaria
2021-10-11 21:00 ` [PR PATCH] [Updated] " tornaria
2021-10-12 18:57 ` ericonr
2021-10-12 19:19 ` [PR PATCH] [Updated] " tornaria
2021-10-12 19:32 ` tornaria
2021-10-12 19:52 ` ericonr
2021-10-12 20:11 ` tornaria
2021-10-13 18:38 ` [PR PATCH] [Closed]: " ahesford
2021-10-13 18:39 ` ahesford

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ https://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git