Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: ThemeChanger-0.10.1
@ 2021-10-12  0:57 ALEX11BR
  2021-10-14 16:40 ` Chocimier
  2021-10-21 17:59 ` [PR PATCH] [Closed]: " ALEX11BR
  0 siblings, 2 replies; 3+ messages in thread
From: ALEX11BR @ 2021-10-12  0:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2171 bytes --]

There is a new pull request by ALEX11BR against master on the void-packages repository

https://github.com/ALEX11BR/void-packages ThemeChanger-0.10.1
https://github.com/void-linux/void-packages/pull/33491

New package: ThemeChanger-0.10.1
<!-- Mark items with [x] where applicable -->
So here I come again, trying to get my app added to your repos, this time a slightly newer version.
For the previous attempt I made the suggested change in regards to checksums. While I also received a suggestion of moving the library files to /usr/lib, the library file present under /usr/share/... is actually a Python C module that the app uses, and I think it should stay there with its other regular Python module buddies. An observed issue is that Python C modules cross-compilation is broken under meson (https://github.com/mesonbuild/meson/issues/7049)...
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->



A patch file from https://github.com/void-linux/void-packages/pull/33491.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ThemeChanger-0.10.1-33491.patch --]
[-- Type: text/x-diff, Size: 1368 bytes --]

From 1f7a106f2aedbfd167df68245d4045e61f313eec Mon Sep 17 00:00:00 2001
From: Popa Ioan Alexandru <alexioanpopa11@gmail.com>
Date: Tue, 12 Oct 2021 03:04:14 +0300
Subject: [PATCH] New package: ThemeChanger-0.10.1

---
 srcpkgs/ThemeChanger/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/ThemeChanger/template

diff --git a/srcpkgs/ThemeChanger/template b/srcpkgs/ThemeChanger/template
new file mode 100644
index 000000000000..b7a8278dc08f
--- /dev/null
+++ b/srcpkgs/ThemeChanger/template
@@ -0,0 +1,17 @@
+# Template file for 'ThemeChanger'
+pkgname=ThemeChanger
+version=0.10.1
+revision=1
+build_style=meson
+hostmakedepends="pkg-config python3 glib-devel"
+makedepends="gdk-pixbuf-devel libXcursor-devel python3-devel python3-gobject-devel"
+depends="gtk+3 python3-gobject"
+short_desc="Theme changing utility for Linux"
+maintainer="Popa Ioan Alexandru <alexioanpopa11@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/ALEX11BR/ThemeChanger"
+distfiles="https://github.com/ALEX11BR/ThemeChanger/archive/refs/tags/v${version}.tar.gz"
+checksum="2a99bbfe25a6a9e954663fe01b5758490b3d0bdcdf872c957b9a1e50f3f444ad"
+nocross="Meson can't properly cross-compile Python C modules (https://github.com/mesonbuild/meson/issues/7049)"
+python_version=3
+ignore_elf_dirs="/usr/share/themechanger/themechanger"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New package: ThemeChanger-0.10.1
  2021-10-12  0:57 [PR PATCH] New package: ThemeChanger-0.10.1 ALEX11BR
@ 2021-10-14 16:40 ` Chocimier
  2021-10-21 17:59 ` [PR PATCH] [Closed]: " ALEX11BR
  1 sibling, 0 replies; 3+ messages in thread
From: Chocimier @ 2021-10-14 16:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33491#issuecomment-943530515

Comment:
> it should stay there with its other regular Python module buddies

No, all modules should be moved to /usr/lib then. Redefine datadir or patch to use libdir or whatever would work here.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: New package: ThemeChanger-0.10.1
  2021-10-12  0:57 [PR PATCH] New package: ThemeChanger-0.10.1 ALEX11BR
  2021-10-14 16:40 ` Chocimier
@ 2021-10-21 17:59 ` ALEX11BR
  1 sibling, 0 replies; 3+ messages in thread
From: ALEX11BR @ 2021-10-21 17:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

There's a closed pull request on the void-packages repository

New package: ThemeChanger-0.10.1
https://github.com/void-linux/void-packages/pull/33491

Description:
<!-- Mark items with [x] where applicable -->
So here I come again, trying to get my app added to your repos, this time a slightly newer version.
For the previous attempt I made the suggested change in regards to checksums. While I also received a suggestion of moving the library files to /usr/lib, the library file present under /usr/share/... is actually a Python C module that the app uses, and I think it should stay there with its other regular Python module buddies. An observed issue is that Python C modules cross-compilation is broken under meson (https://github.com/mesonbuild/meson/issues/7049)...
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-21 17:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12  0:57 [PR PATCH] New package: ThemeChanger-0.10.1 ALEX11BR
2021-10-14 16:40 ` Chocimier
2021-10-21 17:59 ` [PR PATCH] [Closed]: " ALEX11BR

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).