Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] sof-firmware: update to 1.9.
@ 2021-10-04 16:13 kkga
  2021-10-04 16:15 ` kkga
                   ` (25 more replies)
  0 siblings, 26 replies; 27+ messages in thread
From: kkga @ 2021-10-04 16:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

There is a new pull request by kkga against master on the void-packages repository

https://github.com/kkga/void-packages update-sof-firmware
https://github.com/void-linux/void-packages/pull/33318

sof-firmware: update to 1.9.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-sof-firmware-33318.patch --]
[-- Type: text/x-diff, Size: 1325 bytes --]

From 56c553fb5fb288571035ce8c653cd29d15cdd29e Mon Sep 17 00:00:00 2001
From: Gadzhi Kharkharov <me@kkga.me>
Date: Mon, 4 Oct 2021 19:12:02 +0300
Subject: [PATCH] sof-firmware: update to 1.9.

---
 srcpkgs/sof-firmware/template | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 65a4f4f0317f..bfa46fd61269 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,6 +1,6 @@
 # Template file for 'sof-firmware'
 pkgname=sof-firmware
-version=1.8
+version=1.9
 revision=1
 archs="i686* x86_64*"
 wrksrc="sof-bin-${version}"
@@ -11,7 +11,7 @@ maintainer="cinerea0 <cinerea0@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://thesofproject.github.io/latest/index.html"
 distfiles="https://github.com/thesofproject/sof-bin/archive/refs/tags/v${version}.tar.gz"
-checksum=1d4ac18db8d2ec3046fdb56b4155f1c14d69644743b7c0324ba9b02f4308ab22
+checksum=633bff2cc1490146de66796e52e06c7a608591a328c0bfc6f3fc30114640803a
 
 do_install() {
 	vmkdir usr/lib/firmware/intel/sof
@@ -24,8 +24,6 @@ do_install() {
 
 sof-tools_package() {
 	pkg_install() {
-		vbin "v${version}.x/tools-v${version}/sof-ctl"
 		vbin "v${version}.x/tools-v${version}/sof-logger"
-		vbin "v${version}.x/tools-v${version}/sof-probes"
 	}
 }

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
@ 2021-10-04 16:15 ` kkga
  2021-10-04 16:44 ` kkga
                   ` (24 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-04 16:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New comment by kkga on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-933639928

Comment:
@cinerea0 Some of the tools are missing in this release: https://github.com/thesofproject/sof-bin/tree/main/v1.9.x/tools-v1.9, so I removed them from template.

I asked upstream whether it's intended, but no response for now: https://github.com/thesofproject/sof-bin/issues/60

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
  2021-10-04 16:15 ` kkga
@ 2021-10-04 16:44 ` kkga
  2021-10-04 19:16 ` cinerea0
                   ` (23 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-04 16:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by kkga on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-933663689

Comment:
Unfortunately, looks like this release still didn't resolve the issues on my X1 Carbon 9 :/
The sof-related errors from dmesg are gone, but the occasional hangs with pipewire are still there...

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
  2021-10-04 16:15 ` kkga
  2021-10-04 16:44 ` kkga
@ 2021-10-04 19:16 ` cinerea0
  2021-10-04 23:01 ` kkga
                   ` (22 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-04 19:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-933779083

Comment:
Upstream is really bad about creating consistent releases, so chances are they just forgot. I don't know if anyone actually uses those tools, so they should be fine to leave out for this update. I can confirm that this release works for me.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (2 preceding siblings ...)
  2021-10-04 19:16 ` cinerea0
@ 2021-10-04 23:01 ` kkga
  2021-10-08 13:42 ` [PR REVIEW] " ericonr
                   ` (21 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-04 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New comment by kkga on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-933663689

Comment:
~Unfortunately, looks like this release still didn't resolve the issues on my X1 Carbon 9 :/
The sof-related errors from dmesg are gone, but the occasional hangs with pipewire are still there...~

my problem is actually unrelated...

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (3 preceding siblings ...)
  2021-10-04 23:01 ` kkga
@ 2021-10-08 13:42 ` ericonr
  2021-10-14 18:45 ` cinerea0
                   ` (20 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-08 13:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#discussion_r725023062

Comment:
Hmm, am I reading this right that we use the binary as pre-compiled by them? I think that should be fixed either way... Then we can still include all of them.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (4 preceding siblings ...)
  2021-10-08 13:42 ` [PR REVIEW] " ericonr
@ 2021-10-14 18:45 ` cinerea0
  2021-10-14 18:46 ` [PR REVIEW] " cinerea0
                   ` (19 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-14 18:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943625748

Comment:
Here's a template file for `sof-tools`:

```sh
# Template file for 'sof-tools'
pkgname=sof-tools
version=1.9
revision=1
archs="i686* x86_64*"
wrksrc="sof-${version}"
build_wrksrc="tools"
build_style=cmake
hostmakedepends="alsa-utils m4"
makedepends="alsa-lib-devel"
short_desc="Sound Open Firmware and topology binaries - development tools"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="BSD-3-Clause"
homepage="https://thesofproject.github.io/latest/index.html"
distfiles="https://github.com/thesofproject/sof/archive/refs/tags/v${version}.tar.gz"
checksum=29b83a63720ace3a9173073f12c4dfae5ece841773483cb025623506cd02eccb

post_install() {
	vlicense ../LICENCE
}
```

With this you can get rid of the `sof-tools` subpackage in `sof-firmware`.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (5 preceding siblings ...)
  2021-10-14 18:45 ` cinerea0
@ 2021-10-14 18:46 ` cinerea0
  2021-10-14 20:55 ` [PR PATCH] [Updated] " kkga
                   ` (18 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-14 18:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#discussion_r729251240

Comment:
I've included a template for compiling the binaries below.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (6 preceding siblings ...)
  2021-10-14 18:46 ` [PR REVIEW] " cinerea0
@ 2021-10-14 20:55 ` kkga
  2021-10-14 20:59 ` kkga
                   ` (17 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-14 20:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

There is an updated pull request by kkga against master on the void-packages repository

https://github.com/kkga/void-packages update-sof-firmware
https://github.com/void-linux/void-packages/pull/33318

sof-firmware: update to 1.9.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-sof-firmware-33318.patch --]
[-- Type: text/x-diff, Size: 2581 bytes --]

From 3938ee791327a83a425d46e53c5c5e28d7a2d7d6 Mon Sep 17 00:00:00 2001
From: Gadzhi Kharkharov <me@kkga.me>
Date: Mon, 4 Oct 2021 19:12:02 +0300
Subject: [PATCH] sof-firmware: update to 1.9.

---
 srcpkgs/sof-firmware/template | 12 ++----------
 srcpkgs/sof-tools             |  1 -
 srcpkgs/sof-tools/template    | 20 ++++++++++++++++++++
 3 files changed, 22 insertions(+), 11 deletions(-)
 delete mode 120000 srcpkgs/sof-tools
 create mode 100644 srcpkgs/sof-tools/template

diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 65a4f4f0317f..5e866cb448f7 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,6 +1,6 @@
 # Template file for 'sof-firmware'
 pkgname=sof-firmware
-version=1.8
+version=1.9
 revision=1
 archs="i686* x86_64*"
 wrksrc="sof-bin-${version}"
@@ -11,7 +11,7 @@ maintainer="cinerea0 <cinerea0@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://thesofproject.github.io/latest/index.html"
 distfiles="https://github.com/thesofproject/sof-bin/archive/refs/tags/v${version}.tar.gz"
-checksum=1d4ac18db8d2ec3046fdb56b4155f1c14d69644743b7c0324ba9b02f4308ab22
+checksum=633bff2cc1490146de66796e52e06c7a608591a328c0bfc6f3fc30114640803a
 
 do_install() {
 	vmkdir usr/lib/firmware/intel/sof
@@ -21,11 +21,3 @@ do_install() {
 
 	vlicense LICENCE.NXP
 }
-
-sof-tools_package() {
-	pkg_install() {
-		vbin "v${version}.x/tools-v${version}/sof-ctl"
-		vbin "v${version}.x/tools-v${version}/sof-logger"
-		vbin "v${version}.x/tools-v${version}/sof-probes"
-	}
-}
diff --git a/srcpkgs/sof-tools b/srcpkgs/sof-tools
deleted file mode 120000
index 438798503c9c..000000000000
--- a/srcpkgs/sof-tools
+++ /dev/null
@@ -1 +0,0 @@
-sof-firmware
\ No newline at end of file
diff --git a/srcpkgs/sof-tools/template b/srcpkgs/sof-tools/template
new file mode 100644
index 000000000000..4ecdf2bb6b43
--- /dev/null
+++ b/srcpkgs/sof-tools/template
@@ -0,0 +1,20 @@
+# Template file for 'sof-tools'
+pkgname=sof-tools
+version=1.9
+revision=1
+archs="i686* x86_64*"
+wrksrc="sof-${version}"
+build_wrksrc="tools"
+build_style=cmake
+hostmakedepends="alsa-utils m4"
+makedepends="alsa-lib-devel"
+short_desc="Sound Open Firmware and topology binaries - development tools"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://thesofproject.github.io/latest/index.html"
+distfiles="https://github.com/thesofproject/sof/archive/refs/tags/v${version}.tar.gz"
+checksum=29b83a63720ace3a9173073f12c4dfae5ece841773483cb025623506cd02eccb
+
+post_install() {
+	vlicense ../LICENCE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (7 preceding siblings ...)
  2021-10-14 20:55 ` [PR PATCH] [Updated] " kkga
@ 2021-10-14 20:59 ` kkga
  2021-10-14 23:22 ` kkga
                   ` (16 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-14 20:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New comment by kkga on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943727964

Comment:
@cinerea0 great, thanks! 

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (8 preceding siblings ...)
  2021-10-14 20:59 ` kkga
@ 2021-10-14 23:22 ` kkga
  2021-10-15  4:03 ` ericonr
                   ` (15 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-14 23:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by kkga on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943835153

Comment:
It's building locally for me, but not here. Any ideas? :grimacing: 

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (9 preceding siblings ...)
  2021-10-14 23:22 ` kkga
@ 2021-10-15  4:03 ` ericonr
  2021-10-15  4:04 ` ericonr
                   ` (14 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-15  4:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943967084

Comment:
Hm, any reason it can't be the same package? Use cmake build style, install firmware in `post_install` (but do something to avoid overwriting the newly installed ones - can even do rm and remove the pre-built ones completely) and vmove things out like usual. Since the version for both should technically remain the same, I feel like that's simpler.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (10 preceding siblings ...)
  2021-10-15  4:03 ` ericonr
@ 2021-10-15  4:04 ` ericonr
  2021-10-15  4:38 ` cinerea0
                   ` (13 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-15  4:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943967378

Comment:
```
 ALSA lib parser.c:213:(tplg_load_config) failed to parse topology
Unable to load configuration: Invalid argument
```

Have you built it on musl? Looks like there's something wonky.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (11 preceding siblings ...)
  2021-10-15  4:04 ` ericonr
@ 2021-10-15  4:38 ` cinerea0
  2021-10-15  4:39 ` cinerea0
                   ` (12 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-15  4:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943989565

Comment:
@ericonr 
> Hm, any reason it can't be the same package?
According to earlier discussions (that I think took place on IRC) the consensus was that it would be best to install pre-built firmware binaries instead of building them manually. As such, the firmware would come from the `sof-bin` repo and the tools would come from the `sof` repo. Unless you're suggesting using two distfiles in one package?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (12 preceding siblings ...)
  2021-10-15  4:38 ` cinerea0
@ 2021-10-15  4:39 ` cinerea0
  2021-10-15  4:43 ` cinerea0
                   ` (11 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-15  4:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943989565

Comment:
@ericonr 
> Hm, any reason it can't be the same package?

According to earlier discussions (that I think took place on IRC) the consensus was that it would be best to install pre-built firmware binaries instead of building them manually. As such, the firmware would come from the `sof-bin` repo and the tools would come from the `sof` repo. Unless you're suggesting using two distfiles in one package?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (13 preceding siblings ...)
  2021-10-15  4:39 ` cinerea0
@ 2021-10-15  4:43 ` cinerea0
  2021-10-15  4:55 ` cinerea0
                   ` (10 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-15  4:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943989565

Comment:
@ericonr 
> Hm, any reason it can't be the same package?

According to earlier discussions (that I think took place on IRC) the consensus was that it would be best to install pre-built firmware binaries instead of building them manually. As such, if we're building the tools from source, the firmware would come from the `sof-bin` repo and the tools would come from the `sof` repo. Unless you're suggesting using two distfiles in one package?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (14 preceding siblings ...)
  2021-10-15  4:43 ` cinerea0
@ 2021-10-15  4:55 ` cinerea0
  2021-10-15  5:29 ` ericonr
                   ` (9 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-15  4:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-943989565

Comment:
@ericonr 
> Hm, any reason it can't be the same package?

According to earlier discussions (that I think took place on IRC) the consensus was that it would be best to install pre-built firmware binaries instead of building them manually. As such, if we're building the tools from source, the firmware would come from the `sof-bin` repo and the tools would come from the `sof` repo. Unless you're suggesting using two distfiles in one package?

Also, regarding that musl error, that parsing step is performed by a tool from `alsa-utils`. Unless we have examples of that working correctly on musl in other circumstances, it is equally likely to be the fault of their topologies as it is that tool.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (15 preceding siblings ...)
  2021-10-15  4:55 ` cinerea0
@ 2021-10-15  5:29 ` ericonr
  2021-10-25  0:54 ` ericonr
                   ` (8 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-15  5:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-944014544

Comment:
Oh, I missed that they were different repos! Sorry. As is is great then.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (16 preceding siblings ...)
  2021-10-15  5:29 ` ericonr
@ 2021-10-25  0:54 ` ericonr
  2021-10-25  1:58 ` cinerea0
                   ` (7 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-25  0:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-950436044

Comment:
So, there are some clear issues with `sof-tools`. I'd rather fully remove them from `sof-firmware` from now, and we can fix them later, so we can merge this update. Alternatively, restricting to `x86_64` / glibc is also an option, given that the current package only really works there anyway (it can't even be installed on musl).

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (17 preceding siblings ...)
  2021-10-25  0:54 ` ericonr
@ 2021-10-25  1:58 ` cinerea0
  2021-10-25  2:02 ` ericonr
                   ` (6 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-25  1:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-950459673

Comment:
> the current package only really works there anyway (it can't even be installed on musl)

To clarify, do you mean that `sof-firmware` can't be installed on x86_64-musl systems? If that's the case, then I'd be in favor of removing `sof-tools` from the `sof-firmware` template and marking `sof-tools` as x86_64 only.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (18 preceding siblings ...)
  2021-10-25  1:58 ` cinerea0
@ 2021-10-25  2:02 ` ericonr
  2021-10-25  3:23 ` cinerea0
                   ` (5 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-25  2:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-950461266

Comment:
No, I mean `sof-tools`. `sof-firmware` contains only firmware and is installeable anywhere. It's a bug in our build system, but building packages for musl which depend on glibc doesn't error out (which is the case for `sof-tools`). Given that it's only compatible with glibc x86_64, I think it's ok to restrict building the separate package for now, then we can try to fix in the future (link the issue above the `archs=` line).

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (19 preceding siblings ...)
  2021-10-25  2:02 ` ericonr
@ 2021-10-25  3:23 ` cinerea0
  2021-10-25  7:57 ` [PR PATCH] [Updated] " kkga
                   ` (4 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: cinerea0 @ 2021-10-25  3:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-950492523

Comment:
That makes sense. @kkga since this is your PR, could you please use this version of the `sof-tools` template:

```bash
# Template file for 'sof-tools'
pkgname=sof-tools
version=1.9
revision=1
# https://github.com/thesofproject/sof/issues/4902
archs="x86_64"
wrksrc="sof-${version}"
build_wrksrc="tools"
build_style=cmake
hostmakedepends="alsa-utils m4"
makedepends="alsa-lib-devel"
short_desc="Sound Open Firmware and topology binaries - development tools"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="BSD-3-Clause"
homepage="https://thesofproject.github.io/latest/index.html"
distfiles="https://github.com/thesofproject/sof/archive/refs/tags/v${version}.tar.gz"
checksum=29b83a63720ace3a9173073f12c4dfae5ece841773483cb025623506cd02eccb

post_install() {
	vlicense ../LICENCE
}
```

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (20 preceding siblings ...)
  2021-10-25  3:23 ` cinerea0
@ 2021-10-25  7:57 ` kkga
  2021-10-25 13:21 ` ericonr
                   ` (3 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-25  7:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

There is an updated pull request by kkga against master on the void-packages repository

https://github.com/kkga/void-packages update-sof-firmware
https://github.com/void-linux/void-packages/pull/33318

sof-firmware: update to 1.9.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-sof-firmware-33318.patch --]
[-- Type: text/x-diff, Size: 2627 bytes --]

From ef442a0320cf89a1c875eeded5e1b7e828fc8cf3 Mon Sep 17 00:00:00 2001
From: Gadzhi Kharkharov <me@kkga.me>
Date: Mon, 4 Oct 2021 19:12:02 +0300
Subject: [PATCH] sof-firmware: update to 1.9.

---
 srcpkgs/sof-firmware/template | 12 ++----------
 srcpkgs/sof-tools             |  1 -
 srcpkgs/sof-tools/template    | 21 +++++++++++++++++++++
 3 files changed, 23 insertions(+), 11 deletions(-)
 delete mode 120000 srcpkgs/sof-tools
 create mode 100644 srcpkgs/sof-tools/template

diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 65a4f4f0317f..5e866cb448f7 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,6 +1,6 @@
 # Template file for 'sof-firmware'
 pkgname=sof-firmware
-version=1.8
+version=1.9
 revision=1
 archs="i686* x86_64*"
 wrksrc="sof-bin-${version}"
@@ -11,7 +11,7 @@ maintainer="cinerea0 <cinerea0@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://thesofproject.github.io/latest/index.html"
 distfiles="https://github.com/thesofproject/sof-bin/archive/refs/tags/v${version}.tar.gz"
-checksum=1d4ac18db8d2ec3046fdb56b4155f1c14d69644743b7c0324ba9b02f4308ab22
+checksum=633bff2cc1490146de66796e52e06c7a608591a328c0bfc6f3fc30114640803a
 
 do_install() {
 	vmkdir usr/lib/firmware/intel/sof
@@ -21,11 +21,3 @@ do_install() {
 
 	vlicense LICENCE.NXP
 }
-
-sof-tools_package() {
-	pkg_install() {
-		vbin "v${version}.x/tools-v${version}/sof-ctl"
-		vbin "v${version}.x/tools-v${version}/sof-logger"
-		vbin "v${version}.x/tools-v${version}/sof-probes"
-	}
-}
diff --git a/srcpkgs/sof-tools b/srcpkgs/sof-tools
deleted file mode 120000
index 438798503c9c..000000000000
--- a/srcpkgs/sof-tools
+++ /dev/null
@@ -1 +0,0 @@
-sof-firmware
\ No newline at end of file
diff --git a/srcpkgs/sof-tools/template b/srcpkgs/sof-tools/template
new file mode 100644
index 000000000000..e10c8afe210f
--- /dev/null
+++ b/srcpkgs/sof-tools/template
@@ -0,0 +1,21 @@
+# Template file for 'sof-tools'
+pkgname=sof-tools
+version=1.9
+revision=1
+# https://github.com/thesofproject/sof/issues/4902
+archs="x86_64"
+wrksrc="sof-${version}"
+build_wrksrc="tools"
+build_style=cmake
+hostmakedepends="alsa-utils m4"
+makedepends="alsa-lib-devel"
+short_desc="Sound Open Firmware and topology binaries - development tools"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://thesofproject.github.io/latest/index.html"
+distfiles="https://github.com/thesofproject/sof/archive/refs/tags/v${version}.tar.gz"
+checksum=29b83a63720ace3a9173073f12c4dfae5ece841773483cb025623506cd02eccb
+
+post_install() {
+	vlicense ../LICENCE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (21 preceding siblings ...)
  2021-10-25  7:57 ` [PR PATCH] [Updated] " kkga
@ 2021-10-25 13:21 ` ericonr
  2021-10-25 13:21 ` ericonr
                   ` (2 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-25 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-950923845

Comment:
Please document what was done in the commit: `split sof-tools as a separate package, since the package was previously using pre-built binaries for x86_64. It can't be built for archs other than x86_64 glibc yet, but that's not a problem, since the package was only usable there...`

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (22 preceding siblings ...)
  2021-10-25 13:21 ` ericonr
@ 2021-10-25 13:21 ` ericonr
  2021-10-25 19:31 ` [PR PATCH] [Updated] " kkga
  2021-10-29  3:31 ` [PR PATCH] [Merged]: " ericonr
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-25 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33318#issuecomment-950923845

Comment:
Please document what was done in the commit: `split sof-tools as a separate package, since the package was previously using pre-built binaries for x86_64. It can't be built for archs other than x86_64 glibc yet, but that's not a problem, since the package was only usable there.`

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (23 preceding siblings ...)
  2021-10-25 13:21 ` ericonr
@ 2021-10-25 19:31 ` kkga
  2021-10-29  3:31 ` [PR PATCH] [Merged]: " ericonr
  25 siblings, 0 replies; 27+ messages in thread
From: kkga @ 2021-10-25 19:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

There is an updated pull request by kkga against master on the void-packages repository

https://github.com/kkga/void-packages update-sof-firmware
https://github.com/void-linux/void-packages/pull/33318

sof-firmware: update to 1.9.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-sof-firmware-33318.patch --]
[-- Type: text/x-diff, Size: 2860 bytes --]

From 533fc2b7124beaa8328b13d76b08dd9216703fdc Mon Sep 17 00:00:00 2001
From: Gadzhi Kharkharov <me@kkga.me>
Date: Mon, 4 Oct 2021 19:12:02 +0300
Subject: [PATCH] sof-firmware: update to 1.9.

split sof-tools as a separate package, since the package was previously
using pre-built binaries for x86_64. It can't be built for archs other
than x86_64 glibc yet, but that's not a problem, since the package was
only usable there.
---
 srcpkgs/sof-firmware/template | 12 ++----------
 srcpkgs/sof-tools             |  1 -
 srcpkgs/sof-tools/template    | 21 +++++++++++++++++++++
 3 files changed, 23 insertions(+), 11 deletions(-)
 delete mode 120000 srcpkgs/sof-tools
 create mode 100644 srcpkgs/sof-tools/template

diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 65a4f4f0317f..5e866cb448f7 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,6 +1,6 @@
 # Template file for 'sof-firmware'
 pkgname=sof-firmware
-version=1.8
+version=1.9
 revision=1
 archs="i686* x86_64*"
 wrksrc="sof-bin-${version}"
@@ -11,7 +11,7 @@ maintainer="cinerea0 <cinerea0@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://thesofproject.github.io/latest/index.html"
 distfiles="https://github.com/thesofproject/sof-bin/archive/refs/tags/v${version}.tar.gz"
-checksum=1d4ac18db8d2ec3046fdb56b4155f1c14d69644743b7c0324ba9b02f4308ab22
+checksum=633bff2cc1490146de66796e52e06c7a608591a328c0bfc6f3fc30114640803a
 
 do_install() {
 	vmkdir usr/lib/firmware/intel/sof
@@ -21,11 +21,3 @@ do_install() {
 
 	vlicense LICENCE.NXP
 }
-
-sof-tools_package() {
-	pkg_install() {
-		vbin "v${version}.x/tools-v${version}/sof-ctl"
-		vbin "v${version}.x/tools-v${version}/sof-logger"
-		vbin "v${version}.x/tools-v${version}/sof-probes"
-	}
-}
diff --git a/srcpkgs/sof-tools b/srcpkgs/sof-tools
deleted file mode 120000
index 438798503c9c..000000000000
--- a/srcpkgs/sof-tools
+++ /dev/null
@@ -1 +0,0 @@
-sof-firmware
\ No newline at end of file
diff --git a/srcpkgs/sof-tools/template b/srcpkgs/sof-tools/template
new file mode 100644
index 000000000000..e10c8afe210f
--- /dev/null
+++ b/srcpkgs/sof-tools/template
@@ -0,0 +1,21 @@
+# Template file for 'sof-tools'
+pkgname=sof-tools
+version=1.9
+revision=1
+# https://github.com/thesofproject/sof/issues/4902
+archs="x86_64"
+wrksrc="sof-${version}"
+build_wrksrc="tools"
+build_style=cmake
+hostmakedepends="alsa-utils m4"
+makedepends="alsa-lib-devel"
+short_desc="Sound Open Firmware and topology binaries - development tools"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://thesofproject.github.io/latest/index.html"
+distfiles="https://github.com/thesofproject/sof/archive/refs/tags/v${version}.tar.gz"
+checksum=29b83a63720ace3a9173073f12c4dfae5ece841773483cb025623506cd02eccb
+
+post_install() {
+	vlicense ../LICENCE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Merged]: sof-firmware: update to 1.9.
  2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
                   ` (24 preceding siblings ...)
  2021-10-25 19:31 ` [PR PATCH] [Updated] " kkga
@ 2021-10-29  3:31 ` ericonr
  25 siblings, 0 replies; 27+ messages in thread
From: ericonr @ 2021-10-29  3:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

There's a merged pull request on the void-packages repository

sof-firmware: update to 1.9.
https://github.com/void-linux/void-packages/pull/33318

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2021-10-29  3:31 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 16:13 [PR PATCH] sof-firmware: update to 1.9 kkga
2021-10-04 16:15 ` kkga
2021-10-04 16:44 ` kkga
2021-10-04 19:16 ` cinerea0
2021-10-04 23:01 ` kkga
2021-10-08 13:42 ` [PR REVIEW] " ericonr
2021-10-14 18:45 ` cinerea0
2021-10-14 18:46 ` [PR REVIEW] " cinerea0
2021-10-14 20:55 ` [PR PATCH] [Updated] " kkga
2021-10-14 20:59 ` kkga
2021-10-14 23:22 ` kkga
2021-10-15  4:03 ` ericonr
2021-10-15  4:04 ` ericonr
2021-10-15  4:38 ` cinerea0
2021-10-15  4:39 ` cinerea0
2021-10-15  4:43 ` cinerea0
2021-10-15  4:55 ` cinerea0
2021-10-15  5:29 ` ericonr
2021-10-25  0:54 ` ericonr
2021-10-25  1:58 ` cinerea0
2021-10-25  2:02 ` ericonr
2021-10-25  3:23 ` cinerea0
2021-10-25  7:57 ` [PR PATCH] [Updated] " kkga
2021-10-25 13:21 ` ericonr
2021-10-25 13:21 ` ericonr
2021-10-25 19:31 ` [PR PATCH] [Updated] " kkga
2021-10-29  3:31 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).