[PR PATCH] Gmic

[PR PATCH] Gmic

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 4575 bytes --]

There is a new pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages gmic
https://github.com/void-linux/void-packages/pull/33545

Gmic
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

closes #33534

- Successfully built for x86_64, i686, armv7l-musl locally.
- ZArt isn’t included in the gmic source tarball anymore so I added it as a separate distfile. However, there is no release, yet, so I chose to use the latest commit.
- There is a new plugin for krita.
- The problem is that it is a mixed build style (gnu-makefile/qmake).
In a custom `do_build()` function the non-qt and qt targets are now built separately. For some reason it doesn’t seem to work otherwise.
The qt targets get their flags from the qmake build helper (the main `Makefile` calls `qmake`).
However, I had to make a small change to the qmake build helper or else the hardening flags wouldn’t get picked up.
@sgn can you please have a look at it (you committed that part) if you agree? I haven’t tested that change with other packages, though.
- When running `do_install()` gimp’s plug-in-dir is determined via the `gimptool-2.0` command, but it fails in cross builds. So I hardcoded the directory via a sed substitution.
- There are some compiler warnings on 32-bit targets like
```
CImg.h:59420: warning: argument 1 value '4294967295' exceeds maximum object size 2147483647 [-Walloc-size-larger-than=]
```
and
```
../src/CImg.h:6862:15: warning: comparison is always true due to limited range of data type [-Wtype-limits]
 6862 |       return c>=0 && (unsigned char)c<=' ';
```

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33545.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmic-33545.patch --]
[-- Type: text/x-diff, Size: 4683 bytes --]

From c410fe6cedf44e81845d74ebd7eb8a440bff9b6c Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Thu, 14 Oct 2021 21:05:10 +0200
Subject: [PATCH 1/2] common/build-helper/qmake.sh: also quote flags in

native builds
---
 common/build-helper/qmake.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/build-helper/qmake.sh b/common/build-helper/qmake.sh
index d2a38703b300..7d768e45033a 100644
--- a/common/build-helper/qmake.sh
+++ b/common/build-helper/qmake.sh
@@ -66,7 +66,8 @@ _EOF
 	# makes sense together with the qmake build-helper
 	# and not to interfere with e.g. the qmake build-style
 	#
-	# XXX: Intentionally quote {C,CXX,LD}FLAGS here but not in native.
+	# XXX: Intentionally quote {C,CXX,LD}FLAGS here and
+	#      {C,CXX}FLAGS in native.
 	# - Cross Build:
 	#   + base flags will be picked up from QMAKE_{C,CXX,LD}FLAGS
 	#   + hardening flags will be picked up from environment variables
@@ -91,8 +92,8 @@ exec /usr/lib/qt5/bin/qmake \
 	LIB=/usr/lib \
 	QMAKE_CC=$CC QMAKE_CXX=$CXX \
 	QMAKE_LINK=$CXX QMAKE_LINK_C=$CC \
-	QMAKE_CFLAGS+="${CFLAGS}" \
-	QMAKE_CXXFLAGS+="${CXXFLAGS}" \
+	QMAKE_CFLAGS+="\${CFLAGS}" \
+	QMAKE_CXXFLAGS+="\${CXXFLAGS}" \
 	QMAKE_LFLAGS+="${LDFLAGS}" \
 	CONFIG+=no_qt_rpath
 _EOF

From db209375041a1613d27907d085084ba867fe99e9 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Thu, 14 Oct 2021 21:02:25 +0200
Subject: [PATCH 2/2] gmic: update to 2.9.9

---
 srcpkgs/gmic-krita    |  1 +
 srcpkgs/gmic/template | 47 ++++++++++++++++++++++++++++++++++++-------
 2 files changed, 41 insertions(+), 7 deletions(-)
 create mode 120000 srcpkgs/gmic-krita

diff --git a/srcpkgs/gmic-krita b/srcpkgs/gmic-krita
new file mode 120000
index 000000000000..433883885ce6
--- /dev/null
+++ b/srcpkgs/gmic-krita
@@ -0,0 +1 @@
+gmic
\ No newline at end of file
diff --git a/srcpkgs/gmic/template b/srcpkgs/gmic/template
index 6d6f4ec13ba2..8c1fa6962d8d 100644
--- a/srcpkgs/gmic/template
+++ b/srcpkgs/gmic/template
@@ -1,7 +1,8 @@
 # Template file for 'gmic'
 pkgname=gmic
-version=2.8.0
+version=2.9.9
 revision=1
+_zart_hash=939cf381c5871e506aabd066037acf2b55143c1d
 build_wrksrc="src"
 build_style=gnu-makefile
 build_helper=qmake
@@ -13,20 +14,39 @@ short_desc="GREYC's Magic for Image Computing (image processing framework)"
 maintainer="Jakub Skrzypnik <jot.skrzyp@gmail.com>"
 license="CECILL-2.1"
 homepage="http://gmic.eu/"
-distfiles="http://gmic.eu/files/source/gmic_${version}.tar.gz"
-checksum=d1ca5c726f7570af3a6f0bca27eeb66ef1e6a1b6a17bdaeaf0d59be40b9cd075
+distfiles="http://gmic.eu/files/source/gmic_${version}.tar.gz
+ https://github.com/c-koi/zart/archive/${_zart_hash}.tar.gz"
+checksum="9f053338752ec96a6b619718037767682c5fd58e2471c08f3740fdb070605bc0
+ eec47cc9b572cb3e3c26b424381948e12161e129f3d0d3ceca87ff4a8f99fe5d"
 disable_parallel_build="yes"
 
+post_extract() {
+	mv ../zart-${_zart_hash} zart
+}
+
 post_patch() {
-	vsed -i -e "s,-I[\$](USR),-I$XBPS_CROSS_BASE/usr,g" Makefile
-	# Fix library names for openexr-2.4.0
-	vsed -i Makefile -e "s;-lIlmImf -lHalf;-lIlmImf-2_4 -lHalf-2_4;"
+	vsed -i Makefile -e "s,-I[\$](USR),-I$XBPS_CROSS_BASE/usr,g"
+	vsed -i Makefile -e "s/-Ofast/-O2/g"
+	# uses gimptool-2.0 to determine PLUGINDIR which fails in cross builds
+	vsed -i Makefile -e "s,^PLUGINDIR = .*,PLUGINDIR = /usr/lib/gimp/2\.0/plug-ins,g"
+	vsed -i ../gmic-qt/gmic_qt.pro -e "s/-Ofast/-O2/g"
 	# Not supported on ppc but we already compile for baselines
 	case "$XBPS_TARGET_MACHINE" in
 		ppc*) vsed -i Makefile -e 's;-mtune=generic;;' ;;
 	esac
 }
 
+do_build() {
+	make CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" \
+		CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" \
+		CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" \
+		cli lib libc
+
+	for _target in gimp krita gmic_qt zart; do
+		make $_target
+	done
+}
+
 post_install() {
 	vlicense ../COPYING
 }
@@ -38,18 +58,31 @@ gmic-gimp_package() {
 		vmove usr/lib/gimp
 	}
 }
+
+gmic-krita_package() {
+	short_desc+=" - Krita plugin"
+	depends="krita ${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/bin/gmic_krita_qt
+	}
+}
+
 gmic-zart_package() {
 	short_desc+=" - ZArt tool"
 	depends="${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/bin/zart
+		vmove usr/share/applications/zart.desktop
+		vmove usr/share/icons/hicolor/48x48/apps/zart.png
+		vmove usr/share/icons/hicolor/scalable/apps/zart.svg
 	}
 }
+
 gmic-devel_package() {
 	short_desc+=" - development files"
 	depends="${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/include
-		vmove usr/lib/*.so
+		vmove "usr/lib/*.so"
 	}
 }

Re: gmic: update to 2.9.9

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-943687900

Comment:
@sgn please review the `qmake` helper changes.

Re: gmic: update to 2.9.9

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-944274646

Comment:
I built all packages using the qmake helper (except x2goclient where I couldn’t fetch the distfile, because the host seems to be down atm) and everything went through.

**build ok:**
abGate
djview
gmic
gpsbabel
mkvtoolnix
muse
projectM
qbittorrent
qsynth
qtractor
recoll
smplayer
ttfautohint
uim

**to check:**
x2goclient

Re: gmic: update to 2.9.9

[sgn]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-944279226

Comment:
`djview` misses debug symbol with this change.

Stepping back a bit, I think it's a problem in build system for `djview` though,

Re: gmic: update to 2.9.9

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-944274646

Comment:
I built all packages using the qmake helper <s>(except x2goclient where I couldn’t fetch the distfile, because the host seems to be down atm)</s> and everything went through.

**build ok:**
abGate
djview
gmic
gpsbabel
mkvtoolnix
muse
projectM
qbittorrent
qsynth
qtractor
recoll
smplayer
ttfautohint
uim
x2goclient

Re: gmic: update to 2.9.9

[sgn]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-952923635

Comment:
@ahesford  I think it's fine to change the build-helper. It's djview problem.

Re: [PR PATCH] [Updated] gmic: update to 2.9.9

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 4597 bytes --]

There is an updated pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages gmic
https://github.com/void-linux/void-packages/pull/33545

gmic: update to 2.9.9
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

closes #33534

- Successfully built for x86_64, i686, armv7l-musl locally.
- ZArt isn’t included in the gmic source tarball anymore so I added it as a separate distfile. However, there is no release, yet, so I chose to use the latest commit.
- There is a new plugin for krita.
- The problem is that it is a mixed build style (gnu-makefile/qmake).
In a custom `do_build()` function the non-qt and qt targets are now built separately. For some reason it doesn’t seem to work otherwise.
The qt targets get their flags from the qmake build helper (the main `Makefile` calls `qmake`).
However, I had to make a small change to the qmake build helper or else the hardening flags wouldn’t get picked up.
@sgn can you please have a look at it (you committed that part) if you agree? I haven’t tested that change with other packages, though.
- When running `do_install()` gimp’s plug-in-dir is determined via the `gimptool-2.0` command, but it fails in cross builds. So I hardcoded the directory via a sed substitution.
- There are some compiler warnings on 32-bit targets like
```
CImg.h:59420: warning: argument 1 value '4294967295' exceeds maximum object size 2147483647 [-Walloc-size-larger-than=]
```
and
```
../src/CImg.h:6862:15: warning: comparison is always true due to limited range of data type [-Wtype-limits]
 6862 |       return c>=0 && (unsigned char)c<=' ';
```

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33545.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmic-33545.patch --]
[-- Type: text/x-diff, Size: 4683 bytes --]

From 6b0375851b3ab4a8405d8a23d92f6caf16700448 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Thu, 14 Oct 2021 21:05:10 +0200
Subject: [PATCH 1/2] common/build-helper/qmake.sh: also quote flags in

native builds
---
 common/build-helper/qmake.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/build-helper/qmake.sh b/common/build-helper/qmake.sh
index d2a38703b300..7d768e45033a 100644
--- a/common/build-helper/qmake.sh
+++ b/common/build-helper/qmake.sh
@@ -66,7 +66,8 @@ _EOF
 	# makes sense together with the qmake build-helper
 	# and not to interfere with e.g. the qmake build-style
 	#
-	# XXX: Intentionally quote {C,CXX,LD}FLAGS here but not in native.
+	# XXX: Intentionally quote {C,CXX,LD}FLAGS here and
+	#      {C,CXX}FLAGS in native.
 	# - Cross Build:
 	#   + base flags will be picked up from QMAKE_{C,CXX,LD}FLAGS
 	#   + hardening flags will be picked up from environment variables
@@ -91,8 +92,8 @@ exec /usr/lib/qt5/bin/qmake \
 	LIB=/usr/lib \
 	QMAKE_CC=$CC QMAKE_CXX=$CXX \
 	QMAKE_LINK=$CXX QMAKE_LINK_C=$CC \
-	QMAKE_CFLAGS+="${CFLAGS}" \
-	QMAKE_CXXFLAGS+="${CXXFLAGS}" \
+	QMAKE_CFLAGS+="\${CFLAGS}" \
+	QMAKE_CXXFLAGS+="\${CXXFLAGS}" \
 	QMAKE_LFLAGS+="${LDFLAGS}" \
 	CONFIG+=no_qt_rpath
 _EOF

From d413de49e6435726d197f26634709734066b25d3 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Thu, 14 Oct 2021 21:02:25 +0200
Subject: [PATCH 2/2] gmic: update to 2.9.9

---
 srcpkgs/gmic-krita    |  1 +
 srcpkgs/gmic/template | 47 ++++++++++++++++++++++++++++++++++++-------
 2 files changed, 41 insertions(+), 7 deletions(-)
 create mode 120000 srcpkgs/gmic-krita

diff --git a/srcpkgs/gmic-krita b/srcpkgs/gmic-krita
new file mode 120000
index 000000000000..433883885ce6
--- /dev/null
+++ b/srcpkgs/gmic-krita
@@ -0,0 +1 @@
+gmic
\ No newline at end of file
diff --git a/srcpkgs/gmic/template b/srcpkgs/gmic/template
index 6d6f4ec13ba2..8c1fa6962d8d 100644
--- a/srcpkgs/gmic/template
+++ b/srcpkgs/gmic/template
@@ -1,7 +1,8 @@
 # Template file for 'gmic'
 pkgname=gmic
-version=2.8.0
+version=2.9.9
 revision=1
+_zart_hash=939cf381c5871e506aabd066037acf2b55143c1d
 build_wrksrc="src"
 build_style=gnu-makefile
 build_helper=qmake
@@ -13,20 +14,39 @@ short_desc="GREYC's Magic for Image Computing (image processing framework)"
 maintainer="Jakub Skrzypnik <jot.skrzyp@gmail.com>"
 license="CECILL-2.1"
 homepage="http://gmic.eu/"
-distfiles="http://gmic.eu/files/source/gmic_${version}.tar.gz"
-checksum=d1ca5c726f7570af3a6f0bca27eeb66ef1e6a1b6a17bdaeaf0d59be40b9cd075
+distfiles="http://gmic.eu/files/source/gmic_${version}.tar.gz
+ https://github.com/c-koi/zart/archive/${_zart_hash}.tar.gz"
+checksum="9f053338752ec96a6b619718037767682c5fd58e2471c08f3740fdb070605bc0
+ eec47cc9b572cb3e3c26b424381948e12161e129f3d0d3ceca87ff4a8f99fe5d"
 disable_parallel_build="yes"
 
+post_extract() {
+	mv ../zart-${_zart_hash} zart
+}
+
 post_patch() {
-	vsed -i -e "s,-I[\$](USR),-I$XBPS_CROSS_BASE/usr,g" Makefile
-	# Fix library names for openexr-2.4.0
-	vsed -i Makefile -e "s;-lIlmImf -lHalf;-lIlmImf-2_4 -lHalf-2_4;"
+	vsed -i Makefile -e "s,-I[\$](USR),-I$XBPS_CROSS_BASE/usr,g"
+	vsed -i Makefile -e "s/-Ofast/-O2/g"
+	# uses gimptool-2.0 to determine PLUGINDIR which fails in cross builds
+	vsed -i Makefile -e "s,^PLUGINDIR = .*,PLUGINDIR = /usr/lib/gimp/2\.0/plug-ins,g"
+	vsed -i ../gmic-qt/gmic_qt.pro -e "s/-Ofast/-O2/g"
 	# Not supported on ppc but we already compile for baselines
 	case "$XBPS_TARGET_MACHINE" in
 		ppc*) vsed -i Makefile -e 's;-mtune=generic;;' ;;
 	esac
 }
 
+do_build() {
+	make CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" \
+		CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" \
+		CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" \
+		cli lib libc
+
+	for _target in gimp krita gmic_qt zart; do
+		make $_target
+	done
+}
+
 post_install() {
 	vlicense ../COPYING
 }
@@ -38,18 +58,31 @@ gmic-gimp_package() {
 		vmove usr/lib/gimp
 	}
 }
+
+gmic-krita_package() {
+	short_desc+=" - Krita plugin"
+	depends="krita ${sourcepkg}>=${version}_${revision}"
+	pkg_install() {
+		vmove usr/bin/gmic_krita_qt
+	}
+}
+
 gmic-zart_package() {
 	short_desc+=" - ZArt tool"
 	depends="${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/bin/zart
+		vmove usr/share/applications/zart.desktop
+		vmove usr/share/icons/hicolor/48x48/apps/zart.png
+		vmove usr/share/icons/hicolor/scalable/apps/zart.svg
 	}
 }
+
 gmic-devel_package() {
 	short_desc+=" - development files"
 	depends="${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/include
-		vmove usr/lib/*.so
+		vmove "usr/lib/*.so"
 	}
 }

Re: gmic: update to 2.9.9

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-955577443

Comment:
@sgn or @newbluemoon , what do you think about including a djview fix here?

Re: gmic: update to 2.9.9

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-955584522

Comment:
Is there a specific symbol missing or all? Because when I build the djview-dbg package there are symbols. So I’m not sure what is supposed to be missing.

Re: [PR REVIEW] gmic: update to 2.9.9

[newbluemoon]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by newbluemoon on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#discussion_r739692262

Comment:
This should probably be `\${LDFLAGS}` then, too.

Re: gmic: update to 2.9.9

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33545#issuecomment-967772575

Comment:
@sgn ping?

Re: [PR PATCH] [Closed]: gmic: update to 2.9.9

[sgn]

[-- Attachment #1: Type: text/plain, Size: 4436 bytes --]

There's a closed pull request on the void-packages repository

gmic: update to 2.9.9
https://github.com/void-linux/void-packages/pull/33545

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

closes #33534

- Successfully built for x86_64, i686, armv7l-musl locally.
- ZArt isn’t included in the gmic source tarball anymore so I added it as a separate distfile. However, there is no release, yet, so I chose to use the latest commit.
- There is a new plugin for krita.
- The problem is that it is a mixed build style (gnu-makefile/qmake).
In a custom `do_build()` function the non-qt and qt targets are now built separately. For some reason it doesn’t seem to work otherwise.
The qt targets get their flags from the qmake build helper (the main `Makefile` calls `qmake`).
However, I had to make a small change to the qmake build helper or else the hardening flags wouldn’t get picked up.
@sgn can you please have a look at it (you committed that part) if you agree? I haven’t tested that change with other packages, though.
- When running `do_install()` gimp’s plug-in-dir is determined via the `gimptool-2.0` command, but it fails in cross builds. So I hardcoded the directory via a sed substitution.
- There are some compiler warnings on 32-bit targets like
```
CImg.h:59420: warning: argument 1 value '4294967295' exceeds maximum object size 2147483647 [-Walloc-size-larger-than=]
```
and
```
../src/CImg.h:6862:15: warning: comparison is always true due to limited range of data type [-Wtype-limits]
 6862 |       return c>=0 && (unsigned char)c<=' ';
```

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->