From: not-chicken <not-chicken@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] legendary: update to 0.20.16.
Date: Sat, 16 Oct 2021 08:43:30 +0200 [thread overview]
Message-ID: <20211016064330.7fXGoDN2jMA6vCz-1gHVzTzvMnd7_lkNBWVRA8FWEKo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33571@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
New review comment by not-chicken on void-packages repository
https://github.com/void-linux/void-packages/pull/33571#discussion_r730221581
Comment:
Don't know tbh. It is mentioned as a runtime dependency along with `setuptools` in [setup.py](https://github.com/derrod/legendary/blob/e6bb6/setup.py#L40), which does seem wrong as readme mentions:
>Requirements
PyPI packages: requests, **optionally setuptools and wheel for setup/building**
Perhaps `wheel` is only relevant for installation through `pip` from PyPi, which supports `wheel` format.
next prev parent reply other threads:[~2021-10-16 6:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 15:56 [PR PATCH] " not-chicken
2021-10-15 21:53 ` [PR REVIEW] " paper42
2021-10-16 6:43 ` not-chicken [this message]
2021-10-16 12:21 ` paper42
2021-10-16 16:40 ` not-chicken
2021-10-16 16:41 ` [PR PATCH] [Updated] " not-chicken
2021-10-16 18:57 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016064330.7fXGoDN2jMA6vCz-1gHVzTzvMnd7_lkNBWVRA8FWEKo@z \
--to=not-chicken@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).