Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] legendary: update to 0.20.16.
@ 2021-10-15 15:56 not-chicken
  2021-10-15 21:53 ` [PR REVIEW] " paper42
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: not-chicken @ 2021-10-15 15:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages legendary
https://github.com/void-linux/void-packages/pull/33571

legendary: update to 0.20.16.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33571.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-legendary-33571.patch --]
[-- Type: text/x-diff, Size: 1114 bytes --]

From ba5a007b6b9b4ff3eb1a65362adc757a681ba7af Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 15 Oct 2021 21:21:33 +0530
Subject: [PATCH] legendary: update to 0.20.16.

---
 srcpkgs/legendary/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/legendary/template b/srcpkgs/legendary/template
index e19b04603006..9c3112c41cd5 100644
--- a/srcpkgs/legendary/template
+++ b/srcpkgs/legendary/template
@@ -1,7 +1,7 @@
 # Template file for 'legendary'
 pkgname=legendary
-version=0.20.12
-revision=2
+version=0.20.16
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-requests python3-wheel"
@@ -10,5 +10,5 @@ maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/derrod/legendary"
 distfiles="https://github.com/derrod/legendary/archive/${version}.tar.gz"
-checksum=7b73c50a00092896e3b77eb3a693dfb6e258a804fde92dc7b9b402ebc92f99d7
+checksum=116efe7455a8e40235862912fbe1d532db8a1b3fa23c1e8b3628bde42aee89dd
 make_check=no # doesn't contain any tests

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] legendary: update to 0.20.16.
  2021-10-15 15:56 [PR PATCH] legendary: update to 0.20.16 not-chicken
@ 2021-10-15 21:53 ` paper42
  2021-10-16  6:43 ` not-chicken
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2021-10-15 21:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33571#discussion_r730143475

Comment:
Do you know why is the python3-wheel dependency necessary?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] legendary: update to 0.20.16.
  2021-10-15 15:56 [PR PATCH] legendary: update to 0.20.16 not-chicken
  2021-10-15 21:53 ` [PR REVIEW] " paper42
@ 2021-10-16  6:43 ` not-chicken
  2021-10-16 12:21 ` paper42
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: not-chicken @ 2021-10-16  6:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

New review comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/33571#discussion_r730221581

Comment:
Don't know tbh. It is mentioned as a runtime dependency along with `setuptools` in [setup.py](https://github.com/derrod/legendary/blob/e6bb6/setup.py#L40), which does seem wrong as readme mentions:
>Requirements
    PyPI packages: requests, **optionally setuptools and wheel for setup/building**

Perhaps `wheel` is only relevant for installation through `pip` from PyPi, which supports `wheel` format.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] legendary: update to 0.20.16.
  2021-10-15 15:56 [PR PATCH] legendary: update to 0.20.16 not-chicken
  2021-10-15 21:53 ` [PR REVIEW] " paper42
  2021-10-16  6:43 ` not-chicken
@ 2021-10-16 12:21 ` paper42
  2021-10-16 16:40 ` not-chicken
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2021-10-16 12:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33571#discussion_r730256368

Comment:
`wheel` is only required for build and not for us. It's not imported anywhere in the source.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] legendary: update to 0.20.16.
  2021-10-15 15:56 [PR PATCH] legendary: update to 0.20.16 not-chicken
                   ` (2 preceding siblings ...)
  2021-10-16 12:21 ` paper42
@ 2021-10-16 16:40 ` not-chicken
  2021-10-16 16:41 ` [PR PATCH] [Updated] " not-chicken
  2021-10-16 18:57 ` [PR PATCH] [Merged]: " paper42
  5 siblings, 0 replies; 7+ messages in thread
From: not-chicken @ 2021-10-16 16:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/33571#discussion_r730285208

Comment:
I see, removed it.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] legendary: update to 0.20.16.
  2021-10-15 15:56 [PR PATCH] legendary: update to 0.20.16 not-chicken
                   ` (3 preceding siblings ...)
  2021-10-16 16:40 ` not-chicken
@ 2021-10-16 16:41 ` not-chicken
  2021-10-16 18:57 ` [PR PATCH] [Merged]: " paper42
  5 siblings, 0 replies; 7+ messages in thread
From: not-chicken @ 2021-10-16 16:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages legendary
https://github.com/void-linux/void-packages/pull/33571

legendary: update to 0.20.16.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33571.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-legendary-33571.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]

From bea2a2f31804ed3364ed2d5c9fe60eb6ab03a498 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Fri, 15 Oct 2021 21:21:33 +0530
Subject: [PATCH] legendary: update to 0.20.16.

---
 srcpkgs/legendary/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/legendary/template b/srcpkgs/legendary/template
index e19b04603006..ae35ba48ccae 100644
--- a/srcpkgs/legendary/template
+++ b/srcpkgs/legendary/template
@@ -1,14 +1,14 @@
 # Template file for 'legendary'
 pkgname=legendary
-version=0.20.12
-revision=2
+version=0.20.16
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-requests python3-wheel"
+depends="python3-requests"
 short_desc="Free and open-source replacement for the Epic Games Launcher"
 maintainer="Lorem <notloremipsum@protonmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/derrod/legendary"
 distfiles="https://github.com/derrod/legendary/archive/${version}.tar.gz"
-checksum=7b73c50a00092896e3b77eb3a693dfb6e258a804fde92dc7b9b402ebc92f99d7
+checksum=116efe7455a8e40235862912fbe1d532db8a1b3fa23c1e8b3628bde42aee89dd
 make_check=no # doesn't contain any tests

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: legendary: update to 0.20.16.
  2021-10-15 15:56 [PR PATCH] legendary: update to 0.20.16 not-chicken
                   ` (4 preceding siblings ...)
  2021-10-16 16:41 ` [PR PATCH] [Updated] " not-chicken
@ 2021-10-16 18:57 ` paper42
  5 siblings, 0 replies; 7+ messages in thread
From: paper42 @ 2021-10-16 18:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

There's a merged pull request on the void-packages repository

legendary: update to 0.20.16.
https://github.com/void-linux/void-packages/pull/33571

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-10-16 18:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 15:56 [PR PATCH] legendary: update to 0.20.16 not-chicken
2021-10-15 21:53 ` [PR REVIEW] " paper42
2021-10-16  6:43 ` not-chicken
2021-10-16 12:21 ` paper42
2021-10-16 16:40 ` not-chicken
2021-10-16 16:41 ` [PR PATCH] [Updated] " not-chicken
2021-10-16 18:57 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).