From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-ipython_ipykernel: update to 6.4.1.
Date: Sat, 16 Oct 2021 23:40:30 +0200 [thread overview]
Message-ID: <20211016214030.0fxwkyDnMNMz8rg1x6OpBNEEGYn4LhLypSspCKfMzlE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33592@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/33592#discussion_r730316912
Comment:
* wrap at 80 columns
* there are 2 spaces between python3-importlib_metadata and python3-argcomplete
according to setup.py:
```
"ipython_genutils",
'importlib-metadata<5;python_version<"3.8.0"',
'argcomplete>=1.12.3;python_version<"3.8.0"',
'debugpy>=1.0.0,<2.0',
'ipython>=7.23.1,<8.0',
'traitlets>=4.1.0,<6.0',
'jupyter_client<8.0',
'tornado>=4.2,<7.0',
'matplotlib-inline>=0.1.0,<0.2.0',
'appnope;platform_system=="Darwin"',
```
* you don't need to include importlib-metadata and argcomplete in dependencies since they are required only for python 3.8 and older
* debugpy and tornado are missing
next prev parent reply other threads:[~2021-10-16 21:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 21:00 [PR PATCH] " DragonGhost7
2021-10-16 21:40 ` paper42 [this message]
2021-10-16 23:05 ` [PR REVIEW] " DragonGhost7
2021-11-13 3:02 ` ericonr
2021-11-30 23:17 ` [PR PATCH] [Updated] " DragonGhost7
2021-11-30 23:20 ` DragonGhost7
2021-12-15 23:07 ` paper42
2021-12-17 2:43 ` [PR PATCH] [Updated] " DragonGhost7
2021-12-17 2:45 ` DragonGhost7
2021-12-17 6:50 ` DragonGhost7
2021-12-17 6:54 ` DragonGhost7
2021-12-19 4:26 ` [PR REVIEW] " ericonr
2022-06-09 2:12 ` github-actions
2022-06-23 2:15 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016214030.0fxwkyDnMNMz8rg1x6OpBNEEGYn4LhLypSspCKfMzlE@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).