Re: [PR PATCH] [Updated] New package: ncspot-0.9.0

[ram02z <ram02z@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages ncspot
https://github.com/void-linux/void-packages/pull/33600

New package: ncspot-0.9.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Using the termion as the backend instead of ncurses which doesn't crosscompile. See https://github.com/void-linux/void-packages/pull/23415

Opted to optimize the binary size (taken from alpine's APKBUILD).

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
#### Does it build and run successfully? 
- [x] I built this PR locally for my native architecture, (x86_64)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64
-->

A patch file from https://github.com/void-linux/void-packages/pull/33600.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-33600.patch --]
[-- Type: text/x-diff, Size: 2642 bytes --]

From da19572e47478ee322738bf7d34e322e704cde84 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 17 Oct 2021 10:38:19 +0100
Subject: [PATCH] New package: ncspot-0.9.0

---
 .../patches/0001-remove-pancurses.patch       | 14 ++++++++
 srcpkgs/ncspot/template                       | 35 +++++++++++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 srcpkgs/ncspot/patches/0001-remove-pancurses.patch
 create mode 100644 srcpkgs/ncspot/template

diff --git a/srcpkgs/ncspot/patches/0001-remove-pancurses.patch b/srcpkgs/ncspot/patches/0001-remove-pancurses.patch
new file mode 100644
index 000000000000..b86abab05490
--- /dev/null
+++ b/srcpkgs/ncspot/patches/0001-remove-pancurses.patch
@@ -0,0 +1,14 @@
+pancurses pulls ncurses-rs which breaks cross (termion used instead)
+
+diff --git a/Cargo.toml b/Cargo.toml
+index 576332a..8023123 100644
+--- a/Cargo.toml
++++ b/Cargo.toml
+@@ -47,7 +47,6 @@ strum_macros = "0.22.0"
+ regex = "1"
+ ioctl-rs = { version = "0.2", optional = true }
+ serde_cbor = "0.11.2"
+-pancurses = { version = "0.17.0", features = ["win32"] }
+
+ [dependencies.cursive]
+ version = "0.16.3"
diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
new file mode 100644
index 000000000000..1d74fbc0c028
--- /dev/null
+++ b/srcpkgs/ncspot/template
@@ -0,0 +1,35 @@
+# Template file for 'ncspot'
+pkgname=ncspot
+version=0.9.0
+revision=1
+build_style=cargo
+configure_args="--no-default-features"
+hostmakedepends="pkg-config python3"
+makedepends="openssl-devel $(vopt_if libxcb libxcb-devel)
+$(vopt_if dbus dbus-devel) $(vopt_if alsa alsa-lib-devel)
+$(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Cross-platform ncurses Spotify client"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/hrkfdn/ncspot"
+distfiles="https://github.com/hrkfdn/ncspot/archive/v${version}.tar.gz"
+checksum=81655d9fab4903c6ac22321f1a6801aaedfbd88d4f5f768ae8303104fa904a53
+
+build_options="libxcb dbus alsa pulseaudio notify cover"
+build_options_default="libxcb dbus alsa pulseaudio notify"
+desc_option_libxcb="Enable support for X clipboard access"
+desc_option_cover="Enable support for cover art"
+
+_features="cursive/termion-backend"
+_features+="$(vopt_if libxcb ',share_clipboard,share_selection')"
+_features+="$(vopt_if dbus ',mpris')"
+_features+="$(vopt_if alsa ',alsa_backend')"
+_features+="$(vopt_if pulseaudio ',pulseaudio_backend')"
+_features+="$(vopt_if notify ',notify')"
+_features+="$(vopt_if cover ',cover')"
+
+configure_args+=" --features $_features"
+
+post_install() {
+	vlicense LICENSE
+}