Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt
@ 2021-10-18 19:49 mvf
  2021-10-18 20:25 ` [PR REVIEW] " ericonr
                   ` (21 more replies)
  0 siblings, 22 replies; 23+ messages in thread
From: mvf @ 2021-10-18 19:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is a new pull request by mvf against master on the void-packages repository

https://github.com/mvf/void-packages pr/qtractor
https://github.com/void-linux/void-packages/pull/33623

qtractor: update to 0.9.24, enable VST3 support, adopt
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr/qtractor-33623.patch --]
[-- Type: text/x-diff, Size: 3463 bytes --]

From 9aca551f58d863ee38aa85fb6d99215a5af3d8d3 Mon Sep 17 00:00:00 2001
From: Matthias von Faber <mvf@gmx.eu>
Date: Mon, 18 Oct 2021 21:33:41 +0200
Subject: [PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt

---
 srcpkgs/qtractor/template | 59 +++++++++++++++++++++++++++++----------
 1 file changed, 45 insertions(+), 14 deletions(-)

diff --git a/srcpkgs/qtractor/template b/srcpkgs/qtractor/template
index 8ea7f5fcd6e2..1435600aea2b 100644
--- a/srcpkgs/qtractor/template
+++ b/srcpkgs/qtractor/template
@@ -1,25 +1,56 @@
 # Template file for 'qtractor'
 pkgname=qtractor
-version=0.9.21
+version=0.9.24
 revision=1
 wrksrc="qtractor-qtractor_${version//./_}"
-build_style=gnu-configure
-build_helper=qmake
-configure_args="--enable-debug ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake
- ac_cv_libsuil_gtk2_in_qt5=yes ac_cv_libsuil_x11_in_qt5=yes"
-hostmakedepends="automake pkg-config qt5-qmake qt5-host-tools"
-makedepends="dssi-devel jack-devel ladspa-sdk liblo-devel libmad-devel
- libsamplerate-devel lilv-devel qt5-tools-devel qt5-x11extras-devel
- rubberband-devel sratom-devel suil-devel vamp-plugin-sdk-devel"
+create_wrksrc=yes
+build_wrksrc="$wrksrc"
+build_style=cmake
+configure_args="$(vopt_if vst3 -DCONFIG_VST3SDK=$XBPS_BUILDDIR/$build_wrksrc/vst3sdk)"
+hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
+makedepends="aubio-devel dssi-devel jack-devel ladspa-sdk liblo-devel
+ libmad-devel libsamplerate-devel libsndfile-devel libvorbis-devel lilv-devel
+ qt5-tools-devel qt5-x11extras-devel rubberband-devel sratom-devel suil-devel "
 depends="desktop-file-utils dssi hicolor-icon-theme jack lv2"
 short_desc="Audio/MIDI multi-track sequencer application written in C++/Qt"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Matthias von Faber <mvf@gmx.eu>"
 license="GPL-2.0-or-later"
 homepage="http://qtractor.org"
 changelog="https://raw.githubusercontent.com/rncbc/qtractor/master/ChangeLog"
 distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz"
-checksum=3e8c89d6d6a7a8d84280b5254020515640ef61b8ec356d8aaa3e0da118738daa
+checksum=724b80587f844cfc7c58c22d69d6ff1cd30c7752c2116e55837f468edb6bf4d1
 
-pre_configure() {
-	autoreconf -if
-}
+build_options="vst3"
+desc_option_vst3="Enable VST3 plugin support"
+build_options_default="vst3"
+
+if [ "$build_option_vst3" ]; then
+	_vst3sdk_tag=3.7.3_build_20
+	distfiles+="
+	 https://github.com/steinbergmedia/vst3sdk/archive/v$_vst3sdk_tag.tar.gz>vst3sdk.tar.gz
+	 https://github.com/steinbergmedia/vst3_base/archive/v$_vst3sdk_tag.tar.gz>vst3_base.tar.gz
+	 https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v$_vst3sdk_tag.tar.gz>vst3_pluginterfaces.tar.gz
+	 https://github.com/steinbergmedia/vst3_public_sdk/archive/v$_vst3sdk_tag.tar.gz>vst3_public_sdk.tar.gz
+	"
+	checksum+="
+	 815e51e84e6ed900f6103f00e847bee175c2dc95b16a73ae60719daa0e24ad95
+	 d69d28a6a932d3c946749c9aeb6220b028d7af7ab10f83e4e732e760347fe796
+	 313f3e8c8f080d514763b3e88964a0820851d81f1159219628e1ed188fdb7303
+	 63cd7e3bf0be8ec9b3934ebdc145e13af84004c988071ecbed1aa5c8f8277d80
+	"
+
+	post_extract() {
+		cd $wrksrc
+		ln -s vst3sdk-$_vst3sdk_tag vst3sdk
+		for src_dest in \
+		 vst3_base-$_vst3sdk_tag:vst3sdk/base \
+		 vst3_pluginterfaces-$_vst3sdk_tag:vst3sdk/pluginterfaces \
+		 vst3_public_sdk-$_vst3sdk_tag:vst3sdk/public.sdk \
+		; do
+			_src=${src_dest%:*}
+			_dst=${src_dest#*:}
+			rmdir $_dst
+			ln -sr $wrksrc/$_src $_dst
+		done
+	}
+fi

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
@ 2021-10-18 20:25 ` ericonr
  2021-10-18 20:25 ` ericonr
                   ` (20 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-18 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r731289043

Comment:
Please move the version to below `revision` in the main part of the template

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
  2021-10-18 20:25 ` [PR REVIEW] " ericonr
@ 2021-10-18 20:25 ` ericonr
  2021-10-18 20:25 ` ericonr
                   ` (19 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-18 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r731290046

Comment:
Could it be made a proper package we link against?

If not, can you think of a reason people would want to disable it? Simplifying dependency fetching can be worth it because it allows `xgensum` to actually replace the checksums cleanly for you.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
  2021-10-18 20:25 ` [PR REVIEW] " ericonr
  2021-10-18 20:25 ` ericonr
@ 2021-10-18 20:25 ` ericonr
  2021-10-19 15:57 ` [PR PATCH] [Updated] " mvf
                   ` (18 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-18 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r731290360

Comment:
```suggestion
		 vst3_public_sdk-$_vst3sdk_tag:vst3sdk/public.sdk
		do
```

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Updated] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (2 preceding siblings ...)
  2021-10-18 20:25 ` ericonr
@ 2021-10-19 15:57 ` mvf
  2021-10-19 15:59 ` [PR REVIEW] " mvf
                   ` (17 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-19 15:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by mvf against master on the void-packages repository

https://github.com/mvf/void-packages pr/qtractor
https://github.com/void-linux/void-packages/pull/33623

qtractor: update to 0.9.24, enable VST3 support, adopt
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr/qtractor-33623.patch --]
[-- Type: text/x-diff, Size: 3359 bytes --]

From 9eb8545ac1be15b1b248d92391b98fd0864ccf67 Mon Sep 17 00:00:00 2001
From: Matthias von Faber <mvf@gmx.eu>
Date: Mon, 18 Oct 2021 21:33:41 +0200
Subject: [PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt

---
 srcpkgs/qtractor/template | 50 +++++++++++++++++++++++++++------------
 1 file changed, 35 insertions(+), 15 deletions(-)

diff --git a/srcpkgs/qtractor/template b/srcpkgs/qtractor/template
index 8ea7f5fcd6e2..5479637c794b 100644
--- a/srcpkgs/qtractor/template
+++ b/srcpkgs/qtractor/template
@@ -1,25 +1,45 @@
 # Template file for 'qtractor'
 pkgname=qtractor
-version=0.9.21
+version=0.9.24
 revision=1
+_vst3sdk_tag=3.7.3_build_20
 wrksrc="qtractor-qtractor_${version//./_}"
-build_style=gnu-configure
-build_helper=qmake
-configure_args="--enable-debug ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake
- ac_cv_libsuil_gtk2_in_qt5=yes ac_cv_libsuil_x11_in_qt5=yes"
-hostmakedepends="automake pkg-config qt5-qmake qt5-host-tools"
-makedepends="dssi-devel jack-devel ladspa-sdk liblo-devel libmad-devel
- libsamplerate-devel lilv-devel qt5-tools-devel qt5-x11extras-devel
- rubberband-devel sratom-devel suil-devel vamp-plugin-sdk-devel"
+create_wrksrc=yes
+build_wrksrc="$wrksrc"
+build_style=cmake
+configure_args="-DCONFIG_VST3SDK=$XBPS_BUILDDIR/$build_wrksrc/vst3sdk"
+hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
+makedepends="aubio-devel dssi-devel jack-devel ladspa-sdk liblo-devel
+ libmad-devel libsamplerate-devel libsndfile-devel libvorbis-devel lilv-devel
+ qt5-tools-devel qt5-x11extras-devel rubberband-devel sratom-devel suil-devel"
 depends="desktop-file-utils dssi hicolor-icon-theme jack lv2"
 short_desc="Audio/MIDI multi-track sequencer application written in C++/Qt"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Matthias von Faber <mvf@gmx.eu>"
 license="GPL-2.0-or-later"
-homepage="http://qtractor.org"
+homepage="https://qtractor.org"
 changelog="https://raw.githubusercontent.com/rncbc/qtractor/master/ChangeLog"
-distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz"
-checksum=3e8c89d6d6a7a8d84280b5254020515640ef61b8ec356d8aaa3e0da118738daa
+distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz
+ https://github.com/steinbergmedia/vst3sdk/archive/v$_vst3sdk_tag.tar.gz>vst3sdk.tar.gz
+ https://github.com/steinbergmedia/vst3_base/archive/v$_vst3sdk_tag.tar.gz>vst3_base.tar.gz
+ https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v$_vst3sdk_tag.tar.gz>vst3_pluginterfaces.tar.gz
+ https://github.com/steinbergmedia/vst3_public_sdk/archive/v$_vst3sdk_tag.tar.gz>vst3_public_sdk.tar.gz"
+checksum="724b80587f844cfc7c58c22d69d6ff1cd30c7752c2116e55837f468edb6bf4d1
+ 815e51e84e6ed900f6103f00e847bee175c2dc95b16a73ae60719daa0e24ad95
+ d69d28a6a932d3c946749c9aeb6220b028d7af7ab10f83e4e732e760347fe796
+ 313f3e8c8f080d514763b3e88964a0820851d81f1159219628e1ed188fdb7303
+ 63cd7e3bf0be8ec9b3934ebdc145e13af84004c988071ecbed1aa5c8f8277d80"
 
-pre_configure() {
-	autoreconf -if
+post_extract() {
+	cd $wrksrc
+	ln -s vst3sdk-$_vst3sdk_tag vst3sdk
+	for src_dest in \
+	 vst3_base-$_vst3sdk_tag:vst3sdk/base \
+	 vst3_pluginterfaces-$_vst3sdk_tag:vst3sdk/pluginterfaces \
+	 vst3_public_sdk-$_vst3sdk_tag:vst3sdk/public.sdk
+	do
+		_src=${src_dest%:*}
+		_dst=${src_dest#*:}
+		rmdir $_dst
+		ln -sr $wrksrc/$_src $_dst
+	done
 }

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (3 preceding siblings ...)
  2021-10-19 15:57 ` [PR PATCH] [Updated] " mvf
@ 2021-10-19 15:59 ` mvf
  2021-10-19 19:38 ` ericonr
                   ` (16 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-19 15:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732021229

Comment:
> Could it be made a proper package we link against?

I'd prefer that too, but this would require major surgery. The SDK has no clean separation into interface and implementation and no install rules. As-is, it can pretty much only be used from source. `qtractor` directly compiles source files from the SDK directory.

> If not, can you think of a reason people would want to disable it? Simplifying dependency fetching can be worth it because it allows xgensum to actually replace the checksums cleanly for you.

Now that you mention it, there's no real reason to disable VST3. There are no downsides, and without it `qtractor` is significantly less useful. I made it a mandatory dep.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (4 preceding siblings ...)
  2021-10-19 15:59 ` [PR REVIEW] " mvf
@ 2021-10-19 19:38 ` ericonr
  2021-10-19 19:38 ` ericonr
                   ` (15 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-19 19:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732185695

Comment:
Ok, I just noticed this... If possible, it'd be better not to rename the distfiles. Otherwise your cache can get confused and think the checksums are the same, despite you changing the version.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (5 preceding siblings ...)
  2021-10-19 19:38 ` ericonr
@ 2021-10-19 19:38 ` ericonr
  2021-10-19 20:15 ` [PR PATCH] [Updated] " mvf
                   ` (14 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-19 19:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732186055

Comment:
Please spell it out fully.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Updated] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (6 preceding siblings ...)
  2021-10-19 19:38 ` ericonr
@ 2021-10-19 20:15 ` mvf
  2021-10-19 20:17 ` [PR REVIEW] " mvf
                   ` (13 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-19 20:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by mvf against master on the void-packages repository

https://github.com/mvf/void-packages pr/qtractor
https://github.com/void-linux/void-packages/pull/33623

qtractor: update to 0.9.24, enable VST3 support, adopt
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr/qtractor-33623.patch --]
[-- Type: text/x-diff, Size: 3427 bytes --]

From b9578a8b733998c35ac328bb157a7aa21bbe74dc Mon Sep 17 00:00:00 2001
From: Matthias von Faber <mvf@gmx.eu>
Date: Mon, 18 Oct 2021 21:33:41 +0200
Subject: [PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt

---
 srcpkgs/qtractor/template | 50 +++++++++++++++++++++++++++------------
 1 file changed, 35 insertions(+), 15 deletions(-)

diff --git a/srcpkgs/qtractor/template b/srcpkgs/qtractor/template
index 8ea7f5fcd6e2..944375219acf 100644
--- a/srcpkgs/qtractor/template
+++ b/srcpkgs/qtractor/template
@@ -1,25 +1,45 @@
 # Template file for 'qtractor'
 pkgname=qtractor
-version=0.9.21
+version=0.9.24
 revision=1
+_vst3sdk_tag=3.7.3_build_20
 wrksrc="qtractor-qtractor_${version//./_}"
-build_style=gnu-configure
-build_helper=qmake
-configure_args="--enable-debug ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake
- ac_cv_libsuil_gtk2_in_qt5=yes ac_cv_libsuil_x11_in_qt5=yes"
-hostmakedepends="automake pkg-config qt5-qmake qt5-host-tools"
-makedepends="dssi-devel jack-devel ladspa-sdk liblo-devel libmad-devel
- libsamplerate-devel lilv-devel qt5-tools-devel qt5-x11extras-devel
- rubberband-devel sratom-devel suil-devel vamp-plugin-sdk-devel"
+create_wrksrc=yes
+build_wrksrc="$wrksrc"
+build_style=cmake
+configure_args="-DCONFIG_VST3SDK=$XBPS_BUILDDIR/$build_wrksrc/vst3sdk"
+hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
+makedepends="aubio-devel dssi-devel jack-devel ladspa-sdk liblo-devel
+ libmad-devel libsamplerate-devel libsndfile-devel libvorbis-devel lilv-devel
+ qt5-tools-devel qt5-x11extras-devel rubberband-devel sratom-devel suil-devel"
 depends="desktop-file-utils dssi hicolor-icon-theme jack lv2"
 short_desc="Audio/MIDI multi-track sequencer application written in C++/Qt"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Matthias von Faber <mvf@gmx.eu>"
 license="GPL-2.0-or-later"
-homepage="http://qtractor.org"
+homepage="https://qtractor.org"
 changelog="https://raw.githubusercontent.com/rncbc/qtractor/master/ChangeLog"
-distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz"
-checksum=3e8c89d6d6a7a8d84280b5254020515640ef61b8ec356d8aaa3e0da118738daa
+distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz
+ https://github.com/steinbergmedia/vst3sdk/archive/v$_vst3sdk_tag.tar.gz>vst3sdk-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_base/archive/v$_vst3sdk_tag.tar.gz>vst3_base-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v$_vst3sdk_tag.tar.gz>vst3_pluginterfaces-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_public_sdk/archive/v$_vst3sdk_tag.tar.gz>vst3_public_sdk-v${_vst3sdk_tag}.tar.gz"
+checksum="724b80587f844cfc7c58c22d69d6ff1cd30c7752c2116e55837f468edb6bf4d1
+ 815e51e84e6ed900f6103f00e847bee175c2dc95b16a73ae60719daa0e24ad95
+ d69d28a6a932d3c946749c9aeb6220b028d7af7ab10f83e4e732e760347fe796
+ 313f3e8c8f080d514763b3e88964a0820851d81f1159219628e1ed188fdb7303
+ 63cd7e3bf0be8ec9b3934ebdc145e13af84004c988071ecbed1aa5c8f8277d80"
 
-pre_configure() {
-	autoreconf -if
+post_extract() {
+	cd $wrksrc
+	ln -s vst3sdk-$_vst3sdk_tag vst3sdk
+	for src_dest in \
+	 vst3_base-$_vst3sdk_tag:vst3sdk/base \
+	 vst3_pluginterfaces-$_vst3sdk_tag:vst3sdk/pluginterfaces \
+	 vst3_public_sdk-$_vst3sdk_tag:vst3sdk/public.sdk
+	do
+		_src=${src_dest%:*}
+		_dst=${src_dest#*:}
+		rmdir $_dst
+		ln -sr $wrksrc/$_src $_dst
+	done
 }

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (7 preceding siblings ...)
  2021-10-19 20:15 ` [PR PATCH] [Updated] " mvf
@ 2021-10-19 20:17 ` mvf
  2021-10-19 20:18 ` mvf
                   ` (12 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-19 20:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732211653

Comment:
Hm, not sure I understand. How does repeating the bash substitution from `wrksrc` improve things? They have to be the same, so why not use the same variable?

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (8 preceding siblings ...)
  2021-10-19 20:17 ` [PR REVIEW] " mvf
@ 2021-10-19 20:18 ` mvf
  2021-10-20  1:05 ` ericonr
                   ` (11 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-19 20:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732212837

Comment:
Hm, without renaming them they definitely have the same checksum because there will only be one file called `v$_vst3sdk_tag.tar.gz`. I went with putting the tag into the filename.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (9 preceding siblings ...)
  2021-10-19 20:18 ` mvf
@ 2021-10-20  1:05 ` ericonr
  2021-10-20  1:07 ` ericonr
                   ` (10 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-20  1:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732344886

Comment:
That works too, I hadn't noticed that part of the issue :)

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (10 preceding siblings ...)
  2021-10-20  1:05 ` ericonr
@ 2021-10-20  1:07 ` ericonr
  2021-10-20  1:07 ` ericonr
                   ` (9 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-20  1:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732345428

Comment:
`wrksrc` has a specific meaning (usually), as a directory in `/builddir/$workdir`. I'd rather avoid conflating the meaning, even if the substitution is the same.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (11 preceding siblings ...)
  2021-10-20  1:07 ` ericonr
@ 2021-10-20  1:07 ` ericonr
  2021-10-20  8:37 ` [PR PATCH] [Updated] " mvf
                   ` (8 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-20  1:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r732345428

Comment:
`wrksrc` has a specific meaning (usually), as a directory in `/builddir/$wrksrc`. I'd rather avoid conflating the meaning, even if the substitution is the same.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Updated] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (12 preceding siblings ...)
  2021-10-20  1:07 ` ericonr
@ 2021-10-20  8:37 ` mvf
  2021-10-20 23:01 ` [PR REVIEW] " ericonr
                   ` (7 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-20  8:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by mvf against master on the void-packages repository

https://github.com/mvf/void-packages pr/qtractor
https://github.com/void-linux/void-packages/pull/33623

qtractor: update to 0.9.24, enable VST3 support, adopt
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr/qtractor-33623.patch --]
[-- Type: text/x-diff, Size: 3453 bytes --]

From e7369ed9df0254ead5fce788ce53a396d794f5e2 Mon Sep 17 00:00:00 2001
From: Matthias von Faber <mvf@gmx.eu>
Date: Mon, 18 Oct 2021 21:33:41 +0200
Subject: [PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt

---
 srcpkgs/qtractor/template | 50 +++++++++++++++++++++++++++------------
 1 file changed, 35 insertions(+), 15 deletions(-)

diff --git a/srcpkgs/qtractor/template b/srcpkgs/qtractor/template
index 8ea7f5fcd6e2..b7bbbce91af9 100644
--- a/srcpkgs/qtractor/template
+++ b/srcpkgs/qtractor/template
@@ -1,25 +1,45 @@
 # Template file for 'qtractor'
 pkgname=qtractor
-version=0.9.21
+version=0.9.24
 revision=1
+_vst3sdk_tag=3.7.3_build_20
 wrksrc="qtractor-qtractor_${version//./_}"
-build_style=gnu-configure
-build_helper=qmake
-configure_args="--enable-debug ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake
- ac_cv_libsuil_gtk2_in_qt5=yes ac_cv_libsuil_x11_in_qt5=yes"
-hostmakedepends="automake pkg-config qt5-qmake qt5-host-tools"
-makedepends="dssi-devel jack-devel ladspa-sdk liblo-devel libmad-devel
- libsamplerate-devel lilv-devel qt5-tools-devel qt5-x11extras-devel
- rubberband-devel sratom-devel suil-devel vamp-plugin-sdk-devel"
+create_wrksrc=yes
+build_wrksrc="qtractor-qtractor_${version//./_}"
+build_style=cmake
+configure_args="-DCONFIG_VST3SDK=$XBPS_BUILDDIR/$build_wrksrc/vst3sdk"
+hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
+makedepends="aubio-devel dssi-devel jack-devel ladspa-sdk liblo-devel
+ libmad-devel libsamplerate-devel libsndfile-devel libvorbis-devel lilv-devel
+ qt5-tools-devel qt5-x11extras-devel rubberband-devel sratom-devel suil-devel"
 depends="desktop-file-utils dssi hicolor-icon-theme jack lv2"
 short_desc="Audio/MIDI multi-track sequencer application written in C++/Qt"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Matthias von Faber <mvf@gmx.eu>"
 license="GPL-2.0-or-later"
-homepage="http://qtractor.org"
+homepage="https://qtractor.org"
 changelog="https://raw.githubusercontent.com/rncbc/qtractor/master/ChangeLog"
-distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz"
-checksum=3e8c89d6d6a7a8d84280b5254020515640ef61b8ec356d8aaa3e0da118738daa
+distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz
+ https://github.com/steinbergmedia/vst3sdk/archive/v$_vst3sdk_tag.tar.gz>vst3sdk-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_base/archive/v$_vst3sdk_tag.tar.gz>vst3_base-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v$_vst3sdk_tag.tar.gz>vst3_pluginterfaces-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_public_sdk/archive/v$_vst3sdk_tag.tar.gz>vst3_public_sdk-v${_vst3sdk_tag}.tar.gz"
+checksum="724b80587f844cfc7c58c22d69d6ff1cd30c7752c2116e55837f468edb6bf4d1
+ 815e51e84e6ed900f6103f00e847bee175c2dc95b16a73ae60719daa0e24ad95
+ d69d28a6a932d3c946749c9aeb6220b028d7af7ab10f83e4e732e760347fe796
+ 313f3e8c8f080d514763b3e88964a0820851d81f1159219628e1ed188fdb7303
+ 63cd7e3bf0be8ec9b3934ebdc145e13af84004c988071ecbed1aa5c8f8277d80"
 
-pre_configure() {
-	autoreconf -if
+post_extract() {
+	cd $wrksrc
+	ln -s vst3sdk-$_vst3sdk_tag vst3sdk
+	for src_dest in \
+	 vst3_base-$_vst3sdk_tag:vst3sdk/base \
+	 vst3_pluginterfaces-$_vst3sdk_tag:vst3sdk/pluginterfaces \
+	 vst3_public_sdk-$_vst3sdk_tag:vst3sdk/public.sdk
+	do
+		_src=${src_dest%:*}
+		_dst=${src_dest#*:}
+		rmdir $_dst
+		ln -sr $wrksrc/$_src $_dst
+	done
 }

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (13 preceding siblings ...)
  2021-10-20  8:37 ` [PR PATCH] [Updated] " mvf
@ 2021-10-20 23:01 ` ericonr
  2021-10-20 23:01 ` ericonr
                   ` (6 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-20 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r733205314

Comment:
I think https://github.com/steinbergmedia/vst3_base/blob/master/LICENSE.txt has to be `vlicense`d

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (14 preceding siblings ...)
  2021-10-20 23:01 ` [PR REVIEW] " ericonr
@ 2021-10-20 23:01 ` ericonr
  2021-10-21 10:23 ` mvf
                   ` (5 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-20 23:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r733205467

Comment:
and I think this general license would make the software `GPL-3.0-only`? Is my reading correct?

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (15 preceding siblings ...)
  2021-10-20 23:01 ` ericonr
@ 2021-10-21 10:23 ` mvf
  2021-10-21 10:24 ` mvf
                   ` (4 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-21 10:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r733535555

Comment:
Good catch, I would assume so too.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (16 preceding siblings ...)
  2021-10-21 10:23 ` mvf
@ 2021-10-21 10:24 ` mvf
  2021-10-21 18:57 ` ericonr
                   ` (3 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-21 10:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r733536083

Comment:
Agreed. Trouble is: `vlicense` causes an `xlint` warning in GPL packages (`license ... should not be installed`). Any ideas?

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (17 preceding siblings ...)
  2021-10-21 10:24 ` mvf
@ 2021-10-21 18:57 ` ericonr
  2021-10-21 22:01 ` [PR PATCH] [Updated] " mvf
                   ` (2 subsequent siblings)
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-21 18:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r733964817

Comment:
Use `AND MIT` in the license field.

I'd appreciate if you checked whether it's MIT, ISC or BSD-3-Clause, i can never tell from memory.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Updated] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (18 preceding siblings ...)
  2021-10-21 18:57 ` ericonr
@ 2021-10-21 22:01 ` mvf
  2021-10-21 22:02 ` [PR REVIEW] " mvf
  2021-10-22  6:53 ` [PR PATCH] [Merged]: " ericonr
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-21 22:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by mvf against master on the void-packages repository

https://github.com/mvf/void-packages pr/qtractor
https://github.com/void-linux/void-packages/pull/33623

qtractor: update to 0.9.24, enable VST3 support, adopt
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33623.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr/qtractor-33623.patch --]
[-- Type: text/x-diff, Size: 3661 bytes --]

From c17b39c297720d7885a2ec54b0c62dfb5e5e4899 Mon Sep 17 00:00:00 2001
From: Matthias von Faber <mvf@gmx.eu>
Date: Mon, 18 Oct 2021 21:33:41 +0200
Subject: [PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt

---
 srcpkgs/qtractor/template | 57 ++++++++++++++++++++++++++++-----------
 1 file changed, 41 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/qtractor/template b/srcpkgs/qtractor/template
index 8ea7f5fcd6e2..b9df4028f2ac 100644
--- a/srcpkgs/qtractor/template
+++ b/srcpkgs/qtractor/template
@@ -1,25 +1,50 @@
 # Template file for 'qtractor'
 pkgname=qtractor
-version=0.9.21
+version=0.9.24
 revision=1
+_vst3sdk_tag=3.7.3_build_20
 wrksrc="qtractor-qtractor_${version//./_}"
-build_style=gnu-configure
-build_helper=qmake
-configure_args="--enable-debug ac_cv_qmake=${XBPS_WRAPPERDIR}/qmake
- ac_cv_libsuil_gtk2_in_qt5=yes ac_cv_libsuil_x11_in_qt5=yes"
-hostmakedepends="automake pkg-config qt5-qmake qt5-host-tools"
-makedepends="dssi-devel jack-devel ladspa-sdk liblo-devel libmad-devel
- libsamplerate-devel lilv-devel qt5-tools-devel qt5-x11extras-devel
- rubberband-devel sratom-devel suil-devel vamp-plugin-sdk-devel"
+create_wrksrc=yes
+build_wrksrc="qtractor-qtractor_${version//./_}"
+build_style=cmake
+configure_args="-DCONFIG_VST3SDK=$XBPS_BUILDDIR/$build_wrksrc/vst3sdk"
+hostmakedepends="pkg-config qt5-host-tools qt5-qmake"
+makedepends="aubio-devel dssi-devel jack-devel ladspa-sdk liblo-devel
+ libmad-devel libsamplerate-devel libsndfile-devel libvorbis-devel lilv-devel
+ qt5-tools-devel qt5-x11extras-devel rubberband-devel sratom-devel suil-devel"
 depends="desktop-file-utils dssi hicolor-icon-theme jack lv2"
 short_desc="Audio/MIDI multi-track sequencer application written in C++/Qt"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-2.0-or-later"
-homepage="http://qtractor.org"
+maintainer="Matthias von Faber <mvf@gmx.eu>"
+# qtractor is GPL-2.0-or-later. VST3SDK is GPL-3.0-only, with some parts BSD-3-Clause.
+license="GPL-3.0-only, BSD-3-Clause"
+homepage="https://qtractor.org"
 changelog="https://raw.githubusercontent.com/rncbc/qtractor/master/ChangeLog"
-distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz"
-checksum=3e8c89d6d6a7a8d84280b5254020515640ef61b8ec356d8aaa3e0da118738daa
+distfiles="https://github.com/rncbc/qtractor/archive/qtractor_${version//./_}.tar.gz
+ https://github.com/steinbergmedia/vst3sdk/archive/v$_vst3sdk_tag.tar.gz>vst3sdk-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_base/archive/v$_vst3sdk_tag.tar.gz>vst3_base-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v$_vst3sdk_tag.tar.gz>vst3_pluginterfaces-v${_vst3sdk_tag}.tar.gz
+ https://github.com/steinbergmedia/vst3_public_sdk/archive/v$_vst3sdk_tag.tar.gz>vst3_public_sdk-v${_vst3sdk_tag}.tar.gz"
+checksum="724b80587f844cfc7c58c22d69d6ff1cd30c7752c2116e55837f468edb6bf4d1
+ 815e51e84e6ed900f6103f00e847bee175c2dc95b16a73ae60719daa0e24ad95
+ d69d28a6a932d3c946749c9aeb6220b028d7af7ab10f83e4e732e760347fe796
+ 313f3e8c8f080d514763b3e88964a0820851d81f1159219628e1ed188fdb7303
+ 63cd7e3bf0be8ec9b3934ebdc145e13af84004c988071ecbed1aa5c8f8277d80"
 
-pre_configure() {
-	autoreconf -if
+post_extract() {
+	cd $wrksrc
+	ln -s vst3sdk-$_vst3sdk_tag vst3sdk
+	for src_dest in \
+	 vst3_base-$_vst3sdk_tag:vst3sdk/base \
+	 vst3_pluginterfaces-$_vst3sdk_tag:vst3sdk/pluginterfaces \
+	 vst3_public_sdk-$_vst3sdk_tag:vst3sdk/public.sdk
+	do
+		_src=${src_dest%:*}
+		_dst=${src_dest#*:}
+		rmdir $_dst
+		ln -sr $wrksrc/$_src $_dst
+	done
+}
+
+post_install() {
+	vlicense ../vst3sdk/base/LICENSE.txt VST3SDK-LICENSE.txt
 }

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (19 preceding siblings ...)
  2021-10-21 22:01 ` [PR PATCH] [Updated] " mvf
@ 2021-10-21 22:02 ` mvf
  2021-10-22  6:53 ` [PR PATCH] [Merged]: " ericonr
  21 siblings, 0 replies; 23+ messages in thread
From: mvf @ 2021-10-21 22:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/33623#discussion_r734075802

Comment:
I went with `,` since that's what seems used elsewhere and `AND` doesn't pass `xlint`. It's definitely [BSD-3-Clause](https://opensource.org/licenses/BSD-3-Clause).

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Merged]: qtractor: update to 0.9.24, enable VST3 support, adopt
  2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
                   ` (20 preceding siblings ...)
  2021-10-21 22:02 ` [PR REVIEW] " mvf
@ 2021-10-22  6:53 ` ericonr
  21 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-10-22  6:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

There's a merged pull request on the void-packages repository

qtractor: update to 0.9.24, enable VST3 support, adopt
https://github.com/void-linux/void-packages/pull/33623

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2021-10-22  6:53 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 19:49 [PR PATCH] qtractor: update to 0.9.24, enable VST3 support, adopt mvf
2021-10-18 20:25 ` [PR REVIEW] " ericonr
2021-10-18 20:25 ` ericonr
2021-10-18 20:25 ` ericonr
2021-10-19 15:57 ` [PR PATCH] [Updated] " mvf
2021-10-19 15:59 ` [PR REVIEW] " mvf
2021-10-19 19:38 ` ericonr
2021-10-19 19:38 ` ericonr
2021-10-19 20:15 ` [PR PATCH] [Updated] " mvf
2021-10-19 20:17 ` [PR REVIEW] " mvf
2021-10-19 20:18 ` mvf
2021-10-20  1:05 ` ericonr
2021-10-20  1:07 ` ericonr
2021-10-20  1:07 ` ericonr
2021-10-20  8:37 ` [PR PATCH] [Updated] " mvf
2021-10-20 23:01 ` [PR REVIEW] " ericonr
2021-10-20 23:01 ` ericonr
2021-10-21 10:23 ` mvf
2021-10-21 10:24 ` mvf
2021-10-21 18:57 ` ericonr
2021-10-21 22:01 ` [PR PATCH] [Updated] " mvf
2021-10-21 22:02 ` [PR REVIEW] " mvf
2021-10-22  6:53 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).