Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] update_check/gnome: also check for 2.* and 4.* version
@ 2021-10-15 15:44 tornaria
  2021-10-19 11:43 ` sgn
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: tornaria @ 2021-10-15 15:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages update-gtk
https://github.com/void-linux/void-packages/pull/33569

update_check/gnome: also check for 2.* and 4.* version
Split from #33327.

- check for 2.* (example: `gtk+` currently misses version 2.24.33)
- check for 4.* (example: `gtk4` currently misses version 4.4.0)
- change check for 0.* to ignore devel (e.g. `vala` currently includes 0.53.2 which afaict should be ignored b/c it's development)

Maybe the `[0-4]` I added should be `[0-9]`, or `[0-9]+`.

CC: @paper42, also @sgn since I believe he made the last changes to this regexp. Feel free to redo and drop this PR as you see convenient.

A patch file from https://github.com/void-linux/void-packages/pull/33569.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-gtk-33569.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]

From 0cfe40a90934dadc67c0d79079930894e3d2b2e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Oct 2021 19:22:17 -0300
Subject: [PATCH] update_check/gnome: also check for 2.* and 4.* version

---
 common/xbps-src/shutils/update_check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index 0a624274f500..1e66025d8e3b 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -131,7 +131,7 @@ update_check() {
                 url="https://bitbucket.org/$pkgurlname/downloads"
                 rx='/(get|downloads)/(v?|\Q'"$pkgname"'\E-)?\K[\d.]+(?=\.tar)';;
             *ftp.gnome.org*|*download.gnome.org*)
-                : ${pattern="\Q$pkgname\E-\K(0|[13]\.[0-9]*[02468]|[4-9][0-9]+)\.[0-9.]*[0-9](?=)"}
+                : ${pattern="\Q$pkgname\E-\K([0-4]\.[0-9]*[02468]|[4-9][0-9]+)\.[0-9.]*[0-9](?=)"}
                 url="https://download.gnome.org/sources/$pkgname/cache.json";;
             *kernel.org/pub/linux/kernel/*)
                 rx=linux-'\K'${version%.*}'[\d.]+(?=\.tar\.xz)';;

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: update_check/gnome: also check for 2.* and 4.* version
  2021-10-15 15:44 [PR PATCH] update_check/gnome: also check for 2.* and 4.* version tornaria
@ 2021-10-19 11:43 ` sgn
  2021-10-19 11:44 ` sgn
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2021-10-19 11:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/33569#issuecomment-946639645

Comment:
IIRC, only `gtk+` has `2.x` release, I think it's better to change in `gtk+` update file?


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: update_check/gnome: also check for 2.* and 4.* version
  2021-10-15 15:44 [PR PATCH] update_check/gnome: also check for 2.* and 4.* version tornaria
  2021-10-19 11:43 ` sgn
@ 2021-10-19 11:44 ` sgn
  2021-10-19 11:50 ` sgn
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2021-10-19 11:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/33569#issuecomment-946639645

Comment:
IIRC, only `gtk+` has `2.x` release, I think it's better to change in `gtk+` update file?
Anyway, `[0-4]` look better than `[0134]`

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: update_check/gnome: also check for 2.* and 4.* version
  2021-10-15 15:44 [PR PATCH] update_check/gnome: also check for 2.* and 4.* version tornaria
  2021-10-19 11:43 ` sgn
  2021-10-19 11:44 ` sgn
@ 2021-10-19 11:50 ` sgn
  2022-01-20 14:22 ` tornaria
  2022-01-20 14:22 ` [PR PATCH] [Closed]: " tornaria
  4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2021-10-19 11:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/33569#issuecomment-946643951

Comment:
A lot of packages in `0.x` version doesn't discriminate odd version, e.g `shotwell`

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: update_check/gnome: also check for 2.* and 4.* version
  2021-10-15 15:44 [PR PATCH] update_check/gnome: also check for 2.* and 4.* version tornaria
                   ` (2 preceding siblings ...)
  2021-10-19 11:50 ` sgn
@ 2022-01-20 14:22 ` tornaria
  2022-01-20 14:22 ` [PR PATCH] [Closed]: " tornaria
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2022-01-20 14:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/33569#issuecomment-1017554460

Comment:
I'm closing this because I don't even use gnome and I wouldn't know how to move forward from here.

Note that `gtk+` is still missing `2.24.33` (all the `2.24.*` series is ignored), and while `gtk4` is up to date at `4.6.0`, update-check is missing it nevertheless as the pattern only lets `3.96.*` and `3.98.*` through).

The one for `gtk4` would be fixed by this PR, but the one for `gtk+` is due to a bug in its own update file (it says `ignore="[!2].* 2.90.*"` but it should say `ignore="[!2].*.* 2.90.*"`)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: update_check/gnome: also check for 2.* and 4.* version
  2021-10-15 15:44 [PR PATCH] update_check/gnome: also check for 2.* and 4.* version tornaria
                   ` (3 preceding siblings ...)
  2022-01-20 14:22 ` tornaria
@ 2022-01-20 14:22 ` tornaria
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2022-01-20 14:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

There's a closed pull request on the void-packages repository

update_check/gnome: also check for 2.* and 4.* version
https://github.com/void-linux/void-packages/pull/33569

Description:
Split from #33327.

- check for 2.* (example: `gtk+` currently misses version 2.24.33)
- check for 4.* (example: `gtk4` currently misses version 4.4.0)
- change check for 0.* to ignore devel (e.g. `vala` currently includes 0.53.2 which afaict should be ignored b/c it's development)

Maybe the `[0-4]` I added should be `[0-9]`, or `[0-9]+`.

CC: @paper42, also @sgn since I believe he made the last changes to this regexp. Feel free to redo and drop this PR as you see convenient.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-01-20 14:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 15:44 [PR PATCH] update_check/gnome: also check for 2.* and 4.* version tornaria
2021-10-19 11:43 ` sgn
2021-10-19 11:44 ` sgn
2021-10-19 11:50 ` sgn
2022-01-20 14:22 ` tornaria
2022-01-20 14:22 ` [PR PATCH] [Closed]: " tornaria

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).