From: mvf <mvf@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] qtractor: update to 0.9.24, enable VST3 support, adopt
Date: Tue, 19 Oct 2021 17:59:40 +0200 [thread overview]
Message-ID: <20211019155940.4rPn65oAxaIorB1d-mXsjHoZ-onQy2WlU2qJJ-zyRq0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33623@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
New review comment by mvf on void-packages repository
https://github.com/void-linux/void-packages/pull/33623#discussion_r732021229
Comment:
> Could it be made a proper package we link against?
I'd prefer that too, but this would require major surgery. The SDK has no clean separation into interface and implementation and no install rules. As-is, it can pretty much only be used from source. `qtractor` directly compiles source files from the SDK directory.
> If not, can you think of a reason people would want to disable it? Simplifying dependency fetching can be worth it because it allows xgensum to actually replace the checksums cleanly for you.
Now that you mention it, there's no real reason to disable VST3. There are no downsides, and without it `qtractor` is significantly less useful. I made it a mandatory dep.
next prev parent reply other threads:[~2021-10-19 15:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 19:49 [PR PATCH] " mvf
2021-10-18 20:25 ` [PR REVIEW] " ericonr
2021-10-18 20:25 ` ericonr
2021-10-18 20:25 ` ericonr
2021-10-19 15:57 ` [PR PATCH] [Updated] " mvf
2021-10-19 15:59 ` mvf [this message]
2021-10-19 19:38 ` [PR REVIEW] " ericonr
2021-10-19 19:38 ` ericonr
2021-10-19 20:15 ` [PR PATCH] [Updated] " mvf
2021-10-19 20:17 ` [PR REVIEW] " mvf
2021-10-19 20:18 ` mvf
2021-10-20 1:05 ` ericonr
2021-10-20 1:07 ` ericonr
2021-10-20 1:07 ` ericonr
2021-10-20 8:37 ` [PR PATCH] [Updated] " mvf
2021-10-20 23:01 ` [PR REVIEW] " ericonr
2021-10-20 23:01 ` ericonr
2021-10-21 10:23 ` mvf
2021-10-21 10:24 ` mvf
2021-10-21 18:57 ` ericonr
2021-10-21 22:01 ` [PR PATCH] [Updated] " mvf
2021-10-21 22:02 ` [PR REVIEW] " mvf
2021-10-22 6:53 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019155940.4rPn65oAxaIorB1d-mXsjHoZ-onQy2WlU2qJJ-zyRq0@z \
--to=mvf@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).