Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: New package: aspell-sk-2.01.2
Date: Wed, 20 Oct 2021 21:44:04 +0200	[thread overview]
Message-ID: <20211020194404.u7AkOP7xj9144Ce13Z9M-p__z-Q595w9y5GVqwarq1Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33654@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

There's a merged pull request on the void-packages repository

New package: aspell-sk-2.01.2
https://github.com/void-linux/void-packages/pull/33654

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!--
#### Does it build and run successfully? 
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Different aspell dictionaries use completely different versioning schemes and usually contain dashes. Versions of void packages can't. I wasn't quite sure how to work around that, aspell-en and aspell-cs do it in different ways.

The `xbps-src update-check` doesn't quite work as i would hoped for,
2.01-2 doesn't compare as a newer version than 2.01-1. (and I believe that this is handled improperly in other aspell dict packages, cause they seem to compare one version with a dash against another where it's replaced with a dot)

      parent reply	other threads:[~2021-10-20 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 18:42 [PR PATCH] " priner
2021-10-20 19:11 ` [PR REVIEW] " Chocimier
2021-10-20 19:17 ` [PR PATCH] [Updated] " priner
2021-10-20 19:23 ` [PR REVIEW] " priner
2021-10-20 19:44 ` Chocimier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020194404.u7AkOP7xj9144Ce13Z9M-p__z-Q595w9y5GVqwarq1Q@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).