From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: apitrace 10.0
Date: Fri, 22 Oct 2021 23:19:04 +0200 [thread overview]
Message-ID: <20211022211904.f9HZ62IAqjwpeqY4rPIbeQaUPp98YqhR8Eg9Pkf8cPA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-32029@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/32029#discussion_r734830693
Comment:
It doesn't seem to be linking in brotli? Even though I suggested it :p might make sense to remove as dep.
Or try to understand why it isn't being used.
next prev parent reply other threads:[~2021-10-22 21:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 4:58 [PR PATCH] " mahiuchun
2021-07-18 7:00 ` [PR PATCH] [Updated] " mahiuchun
2021-07-18 23:10 ` mahiuchun
2021-07-31 4:25 ` mahiuchun
2021-07-31 19:27 ` mahiuchun
2021-07-31 20:28 ` mahiuchun
2021-08-03 4:51 ` [PR REVIEW] " ericonr
2021-08-03 4:51 ` ericonr
2021-08-03 4:51 ` ericonr
2021-08-03 15:16 ` [PR PATCH] [Updated] " mahiuchun
2021-08-03 17:56 ` ericonr
2021-08-06 19:06 ` ericonr
2021-09-07 6:36 ` [PR PATCH] [Updated] " mahiuchun
2021-09-29 7:04 ` mahiuchun
2021-10-22 20:41 ` [PR REVIEW] " ericonr
2021-10-22 21:19 ` ericonr [this message]
2021-10-26 6:08 ` [PR PATCH] [Updated] " mahiuchun
2021-10-26 6:18 ` [PR REVIEW] " mahiuchun
2022-05-27 2:12 ` github-actions
2022-06-10 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022211904.f9HZ62IAqjwpeqY4rPIbeQaUPp98YqhR8Eg9Pkf8cPA@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).