From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: relay-0.1.0
Date: Sat, 23 Oct 2021 15:57:11 +0200 [thread overview]
Message-ID: <20211023135711.4QO23JGvOEAaTqsI_ecSN2ET4UeiBKxQydax9v6VX2s@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33639@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/33639#discussion_r734972784
Comment:
This makes the project seem partially formed and not ready for packaging. On the one hand, this seems to be intended primarily as a utility program (or multiple utilities that collaborate) rather than as a Python module one would use in other programs. On the other hand, upstream doesn't provide even basic entrypoint script. (If I'm wrong, and the primary function of this package is to be used in other Python programs, the name should be `python3-relay` or `python3-activityrelay` or something to that effect.)
Regardless, the package requires `python3`, so the proper interpretery would be `/usr/bin/python3` instead of relying on the alternative symlink that a user could redirect to `python2`.
next prev parent reply other threads:[~2021-10-23 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 13:50 [PR PATCH] " TinfoilSubmarine
2021-10-22 21:47 ` [PR REVIEW] " Piraty
2021-10-22 22:02 ` TinfoilSubmarine
2021-10-22 22:11 ` [PR REVIEW] " TinfoilSubmarine
2021-10-23 13:44 ` Duncaen
2021-10-23 13:57 ` ahesford [this message]
2021-10-25 17:15 ` [PR PATCH] [Updated] " TinfoilSubmarine
2021-10-25 17:16 ` [PR PATCH] [Updated] New package: activityrelay-0.1.0 TinfoilSubmarine
2022-04-20 18:32 ` TinfoilSubmarine
2022-04-20 18:32 ` TinfoilSubmarine
2022-04-21 21:22 ` [PR REVIEW] " Piraty
2022-05-06 14:59 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-05-06 15:04 ` [PR REVIEW] New package: activityrelay-0.2.0 TinfoilSubmarine
2022-05-07 16:45 ` [PR PATCH] [Merged]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211023135711.4QO23JGvOEAaTqsI_ecSN2ET4UeiBKxQydax9v6VX2s@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).