Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] librsvg: update to 2.52.0.
Date: Sun, 24 Oct 2021 17:43:43 +0200	[thread overview]
Message-ID: <20211024154343.tzpYKkplrRAhf09zp6ym0pTXaOODS9BlCazJIijHafw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33270@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages rsvg
https://github.com/void-linux/void-packages/pull/33270

librsvg: update to 2.52.0.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

@Gottox I'd like to adopt this, if it's ok with you.

I'm holding off on merging for a bit because they changed the default DPI but might revert it. I want to check at least if void-docs PDF build is still fine.

A patch file from https://github.com/void-linux/void-packages/pull/33270.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rsvg-33270.patch --]
[-- Type: text/x-diff, Size: 2019 bytes --]

From 6053a8d23e922f3d1312230931065c618c092b18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Sat, 2 Oct 2021 16:53:03 -0300
Subject: [PATCH] librsvg: update to 2.52.2, adopt.

Thanks biopsin for spotting the workaround.
---
 srcpkgs/librsvg/template | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/librsvg/template b/srcpkgs/librsvg/template
index d6c9c2c89ddf..b7c13dbfa9a0 100644
--- a/srcpkgs/librsvg/template
+++ b/srcpkgs/librsvg/template
@@ -1,6 +1,6 @@
 # Template file for 'librsvg'
 pkgname=librsvg
-version=2.50.7
+version=2.52.2
 revision=1
 build_style=gnu-configure
 build_helper="gir"
@@ -9,18 +9,27 @@ hostmakedepends="cargo pkg-config python glib-devel gdk-pixbuf-devel vala"
 makedepends="cairo-devel freetype-devel gdk-pixbuf-devel libcroco-devel
  libglib-devel libxml2-devel pango-devel rust vala"
 short_desc="SVG library for GNOME"
-maintainer="Enno Boland <gottox@voidlinux.org>"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
 license="GPL-2.0-or-later, LGPL-2.0-or-later"
 homepage="https://wiki.gnome.org/Projects/LibRsvg"
 # update changelog when release series changes
 changelog="https://gitlab.gnome.org/GNOME/librsvg/-/raw/librsvg-2.50/NEWS"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fffb61b08cd5282aaae147a02b305166a7426fad22a8b9427708f0f2fc426ebc
+checksum=03d2887c18ffb906e1a60f97fe46a7169f69aa28d6db5d285748f3618b093427
 
-do_check() {
-	# reference files are for specific pango and harfbuzz versions
-	# the test suite isn't designed to be run by distros
-	:
+# reference files are for specific pango and harfbuzz versions
+# the test suite isn't designed to be run by distros
+make_check=no
+
+pre_configure() {
+	# otherwise the final linking step uses "cc" instead of $CC
+	if [ "$CROSS_BUILD" ]; then
+		cat >> .cargo/config <<- EOF
+
+		[target.${RUST_TARGET}]
+		linker = "${CC}"
+		EOF
+	fi
 }
 
 librsvg-devel_package() {

  parent reply	other threads:[~2021-10-24 15:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-02 19:54 [PR PATCH] " ericonr
2021-10-02 23:06 ` ericonr
2021-10-03  3:58 ` biopsin
2021-10-03  4:16 ` biopsin
2021-10-03  4:51 ` ericonr
2021-10-03 11:15 ` Gottox
2021-10-24  2:41 ` [PR PATCH] [Updated] " ericonr
2021-10-24 15:43 ` ericonr [this message]
2021-10-24 15:50 ` ericonr
2021-10-24 17:54 ` [PR PATCH] [Updated] " ericonr
2021-10-24 17:55 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211024154343.tzpYKkplrRAhf09zp6ym0pTXaOODS9BlCazJIijHafw@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).