Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40.
@ 2021-10-20 23:04 2asoft
  2021-10-20 23:05 ` [PR REVIEW] " 2asoft
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: 2asoft @ 2021-10-20 23:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

There is a new pull request by 2asoft against master on the void-packages repository

https://github.com/2asoft/void-packages 2asoft/jb_update_jdk
https://github.com/void-linux/void-packages/pull/33660

jetbrains-jdk-bin: update to 11.0.12-b1504.40.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33660.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-2asoft/jb_update_jdk-33660.patch --]
[-- Type: text/x-diff, Size: 2103 bytes --]

From 4d591ab9f47d2d11ed91697f9c627996121b846f Mon Sep 17 00:00:00 2001
From: Anton Afanasyev <1157248+2asoft@users.noreply.github.com>
Date: Sun, 8 Aug 2021 00:24:20 -0700
Subject: [PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40.

---
 srcpkgs/jetbrains-jdk-bin/template | 4 ++--
 srcpkgs/jetbrains-jdk-bin/update   | 6 +++++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/jetbrains-jdk-bin/template b/srcpkgs/jetbrains-jdk-bin/template
index 60272b6918c6..7114636c6562 100644
--- a/srcpkgs/jetbrains-jdk-bin/template
+++ b/srcpkgs/jetbrains-jdk-bin/template
@@ -1,6 +1,6 @@
 # Template file for 'jetbrains-jdk-bin'
 pkgname=jetbrains-jdk-bin
-version=11.0.11b1504.16
+version=11.0.12b1504.40
 revision=1
 archs="x86_64"
 wrksrc="jbr"
@@ -11,7 +11,7 @@ homepage="https://github.com/JetBrains/JetBrainsRuntime"
 _jdk_ver=${version%b*}
 _jdk_build=${version#*b}
 distfiles="https://cache-redirector.jetbrains.com/intellij-jbr/jbr_jcef-${_jdk_ver//\./_}-linux-x64-b${_jdk_build}.tar.gz"
-checksum=f289130e302357d000c84e56d31e24fb0d1fcf74cac84787acc1b08d6f51490f
+checksum=56646f634eafbe85d177e40267f52d83a4bbfcb2bd359b97282bca54812e0784
 # This JDK appears to link to libs that do not exist, but functions well even in their absence.
 # Best guess is that they are optional. ¯\_(ツ)_/¯
 noverifyrdeps=yes
diff --git a/srcpkgs/jetbrains-jdk-bin/update b/srcpkgs/jetbrains-jdk-bin/update
index 6fbb4a879cf7..c1576ba70c36 100644
--- a/srcpkgs/jetbrains-jdk-bin/update
+++ b/srcpkgs/jetbrains-jdk-bin/update
@@ -1,5 +1,9 @@
+# NOTE: This does not check the jdk_ver part of the version (eg 11.0.4)
+# If it changes, this update check will not detect it, it will only detect the build number change.
+# It will be up to the maintainer to go hunt down the correct jdk version and update the template.
 _jdk_ver=${version%b*}
 _jdk_build=${version#*b}
-version=${_jdk_ver}.b${_jdk_build}
+version=${_jdk_ver}-b${_jdk_build}
+echo "Template is for version $version"
 pattern="/releases/tag/jb\K11_\d+_\d+-b\d+(\.\d+)?(?=\">)"
 site="https://github.com/JetBrains/JetBrainsRuntime"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
@ 2021-10-20 23:05 ` 2asoft
  2021-10-21 17:10 ` Chocimier
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 2asoft @ 2021-10-20 23:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New review comment by 2asoft on void-packages repository

https://github.com/void-linux/void-packages/pull/33660#discussion_r733206760

Comment:
This stuff is here to help whoever tries updating.
XBPS support for parsing the page at $site is not enough to properly get a version number.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
  2021-10-20 23:05 ` [PR REVIEW] " 2asoft
@ 2021-10-21 17:10 ` Chocimier
  2021-10-26  5:42 ` 2asoft
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2021-10-21 17:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33660#issuecomment-948825897

Comment:
> This does not check the jdk_ver part of the version (eg 11.0.4)

I don't see why? With current file it works correctly.

    XBPS_UPDATE_CHECK_VERBOSE=1 ./xbps-src update-check jetbrains-jdk-bin
    using jetbrains-jdk-bin/update overrides
    fetching https://github.com/JetBrains/JetBrainsRuntime and scanning with /releases/tag/jb\K11_\d+_\d+-b\d+(\.\d+)?(?=">)
    found version 11.0.12-b1504.40
    jetbrains-jdk-bin-11.0.11.b1504.16 -> jetbrains-jdk-bin-11.0.12-b1504.40

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
  2021-10-20 23:05 ` [PR REVIEW] " 2asoft
  2021-10-21 17:10 ` Chocimier
@ 2021-10-26  5:42 ` 2asoft
  2021-10-26  5:42 ` [PR PATCH] [Updated] " 2asoft
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 2asoft @ 2021-10-26  5:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

New comment by 2asoft on void-packages repository

https://github.com/void-linux/void-packages/pull/33660#issuecomment-951579943

Comment:
ok, it actually doesnt work in certain cases even with the change I have, so I am happy to remove that.

To try it out, try separately lowering each individual component in the template, then running `update-check` and see the results.
It works for some, but not all.
I dont mind maintaining it like this for now, but I ack it is a bit of a pain for anyone unfamiliar as there is no clear indication there is an update (must manually look).

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
                   ` (2 preceding siblings ...)
  2021-10-26  5:42 ` 2asoft
@ 2021-10-26  5:42 ` 2asoft
  2021-10-26  5:43 ` 2asoft
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 2asoft @ 2021-10-26  5:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

There is an updated pull request by 2asoft against master on the void-packages repository

https://github.com/2asoft/void-packages 2asoft/jb_update_jdk
https://github.com/void-linux/void-packages/pull/33660

jetbrains-jdk-bin: update to 11.0.12-b1504.40.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33660.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-2asoft/jb_update_jdk-33660.patch --]
[-- Type: text/x-diff, Size: 1784 bytes --]

From e4f1404a9a8093dca57a83e39b5d6b968b3c9c17 Mon Sep 17 00:00:00 2001
From: Anton Afanasyev <1157248+2asoft@users.noreply.github.com>
Date: Sun, 8 Aug 2021 00:24:20 -0700
Subject: [PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40.

---
 srcpkgs/jetbrains-jdk-bin/template | 4 ++--
 srcpkgs/jetbrains-jdk-bin/update   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/jetbrains-jdk-bin/template b/srcpkgs/jetbrains-jdk-bin/template
index 60272b6918c6..7114636c6562 100644
--- a/srcpkgs/jetbrains-jdk-bin/template
+++ b/srcpkgs/jetbrains-jdk-bin/template
@@ -1,6 +1,6 @@
 # Template file for 'jetbrains-jdk-bin'
 pkgname=jetbrains-jdk-bin
-version=11.0.11b1504.16
+version=11.0.12b1504.40
 revision=1
 archs="x86_64"
 wrksrc="jbr"
@@ -11,7 +11,7 @@ homepage="https://github.com/JetBrains/JetBrainsRuntime"
 _jdk_ver=${version%b*}
 _jdk_build=${version#*b}
 distfiles="https://cache-redirector.jetbrains.com/intellij-jbr/jbr_jcef-${_jdk_ver//\./_}-linux-x64-b${_jdk_build}.tar.gz"
-checksum=f289130e302357d000c84e56d31e24fb0d1fcf74cac84787acc1b08d6f51490f
+checksum=56646f634eafbe85d177e40267f52d83a4bbfcb2bd359b97282bca54812e0784
 # This JDK appears to link to libs that do not exist, but functions well even in their absence.
 # Best guess is that they are optional. ¯\_(ツ)_/¯
 noverifyrdeps=yes
diff --git a/srcpkgs/jetbrains-jdk-bin/update b/srcpkgs/jetbrains-jdk-bin/update
index 6fbb4a879cf7..983317555e2d 100644
--- a/srcpkgs/jetbrains-jdk-bin/update
+++ b/srcpkgs/jetbrains-jdk-bin/update
@@ -1,5 +1,5 @@
 _jdk_ver=${version%b*}
 _jdk_build=${version#*b}
-version=${_jdk_ver}.b${_jdk_build}
+version=${_jdk_ver}-b${_jdk_build}
 pattern="/releases/tag/jb\K11_\d+_\d+-b\d+(\.\d+)?(?=\">)"
 site="https://github.com/JetBrains/JetBrainsRuntime"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
                   ` (3 preceding siblings ...)
  2021-10-26  5:42 ` [PR PATCH] [Updated] " 2asoft
@ 2021-10-26  5:43 ` 2asoft
  2021-10-26  5:43 ` 2asoft
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 2asoft @ 2021-10-26  5:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

There is an updated pull request by 2asoft against master on the void-packages repository

https://github.com/2asoft/void-packages 2asoft/jb_update_jdk
https://github.com/void-linux/void-packages/pull/33660

jetbrains-jdk-bin: update to 11.0.12-b1504.40.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33660.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-2asoft/jb_update_jdk-33660.patch --]
[-- Type: text/x-diff, Size: 1289 bytes --]

From 3ded21111c53429c2114d47efe4f572edcfb292c Mon Sep 17 00:00:00 2001
From: Anton Afanasyev <1157248+2asoft@users.noreply.github.com>
Date: Sun, 8 Aug 2021 00:24:20 -0700
Subject: [PATCH] jetbrains-jdk-bin: update to 11.0.12.b1504.40.

---
 srcpkgs/jetbrains-jdk-bin/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/jetbrains-jdk-bin/template b/srcpkgs/jetbrains-jdk-bin/template
index 60272b6918c6..7114636c6562 100644
--- a/srcpkgs/jetbrains-jdk-bin/template
+++ b/srcpkgs/jetbrains-jdk-bin/template
@@ -1,6 +1,6 @@
 # Template file for 'jetbrains-jdk-bin'
 pkgname=jetbrains-jdk-bin
-version=11.0.11b1504.16
+version=11.0.12b1504.40
 revision=1
 archs="x86_64"
 wrksrc="jbr"
@@ -11,7 +11,7 @@ homepage="https://github.com/JetBrains/JetBrainsRuntime"
 _jdk_ver=${version%b*}
 _jdk_build=${version#*b}
 distfiles="https://cache-redirector.jetbrains.com/intellij-jbr/jbr_jcef-${_jdk_ver//\./_}-linux-x64-b${_jdk_build}.tar.gz"
-checksum=f289130e302357d000c84e56d31e24fb0d1fcf74cac84787acc1b08d6f51490f
+checksum=56646f634eafbe85d177e40267f52d83a4bbfcb2bd359b97282bca54812e0784
 # This JDK appears to link to libs that do not exist, but functions well even in their absence.
 # Best guess is that they are optional. ¯\_(ツ)_/¯
 noverifyrdeps=yes

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
                   ` (4 preceding siblings ...)
  2021-10-26  5:43 ` 2asoft
@ 2021-10-26  5:43 ` 2asoft
  2021-10-26  5:44 ` 2asoft
  2021-10-26 18:37 ` [PR PATCH] [Merged]: " Chocimier
  7 siblings, 0 replies; 9+ messages in thread
From: 2asoft @ 2021-10-26  5:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

New comment by 2asoft on void-packages repository

https://github.com/void-linux/void-packages/pull/33660#issuecomment-951579943

Comment:
ok, it actually doesnt work in certain cases even with the change I have, so I am happy to remove that.

To try it out, try separately lowering each individual component in the template, then running `update-check` and see the results.
It works for some, but not all.
I dont mind maintaining it like this for now, but I ack it is a bit of a pain for anyone unfamiliar as there is no clear indication there is an update (must manually look).

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
                   ` (5 preceding siblings ...)
  2021-10-26  5:43 ` 2asoft
@ 2021-10-26  5:44 ` 2asoft
  2021-10-26 18:37 ` [PR PATCH] [Merged]: " Chocimier
  7 siblings, 0 replies; 9+ messages in thread
From: 2asoft @ 2021-10-26  5:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New comment by 2asoft on void-packages repository

https://github.com/void-linux/void-packages/pull/33660#issuecomment-951580932

Comment:
> > This does not check the jdk_ver part of the version (eg 11.0.4)
> 
> I don't see why? With current file it works correctly.

Interesting, this must have changed within the last few months.
It used to be needed.
Removed the hack from `update`, thanks for noticing!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: jetbrains-jdk-bin: update to 11.0.12-b1504.40.
  2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
                   ` (6 preceding siblings ...)
  2021-10-26  5:44 ` 2asoft
@ 2021-10-26 18:37 ` Chocimier
  7 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2021-10-26 18:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

There's a merged pull request on the void-packages repository

jetbrains-jdk-bin: update to 11.0.12-b1504.40.
https://github.com/void-linux/void-packages/pull/33660

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-10-26 18:37 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20 23:04 [PR PATCH] jetbrains-jdk-bin: update to 11.0.12-b1504.40 2asoft
2021-10-20 23:05 ` [PR REVIEW] " 2asoft
2021-10-21 17:10 ` Chocimier
2021-10-26  5:42 ` 2asoft
2021-10-26  5:42 ` [PR PATCH] [Updated] " 2asoft
2021-10-26  5:43 ` 2asoft
2021-10-26  5:43 ` 2asoft
2021-10-26  5:44 ` 2asoft
2021-10-26 18:37 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).