From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: sane: add libcurl for escl backend, add runit service
Date: Thu, 28 Oct 2021 06:20:31 +0200 [thread overview]
Message-ID: <20211028042031.LrPN3K9pdWoN-VKAh6qAOjXukMUXfSCaJXz82kQD7SI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31851@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 4500 bytes --]
There's a merged pull request on the void-packages repository
sane: add libcurl for escl backend, add runit service
https://github.com/void-linux/void-packages/pull/31851
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
Changes
* Make Avahi support optional
* Add libcurl for eSCL (AirScan) backend when Avahi is enabled
* Add `_saned` user/group
* Add a runit service for `saned`
There is an issue with the runit service when SANE is built with Avahi support. `saned` will spawn a second process (pid 1429) which can be seen below:
```
$ ps
1428 _saned _saned 0.0 0.0 16164 6088 ? S 18:57:06 00:00:00 saned -l -u _saned -d128
1429 _saned _saned 0.0 0.0 16164 548 ? S 18:57:06 00:00:00 saned -l -u _saned -d128
```
```
$ svlogtail
2021-07-08T08:57:06.35901 daemon.debug: Jul 8 18:57:06 saned[1428]: read_config: searching for config file
2021-07-08T08:57:06.35906 daemon.debug: Jul 8 18:57:06 saned[1428]: read_config: done reading config
2021-07-08T08:57:06.35909 daemon.debug: Jul 8 18:57:06 saned[1428]: saned (AF-indep+IPv6) from sane-backends 1.0.32 starting up
2021-07-08T08:57:06.35911 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: trying to get port for service "sane-port" (getaddrinfo)
2021-07-08T08:57:06.36066 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [1] socket () using IPv6
2021-07-08T08:57:06.36069 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [1] setsockopt ()
2021-07-08T08:57:06.36066 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [1] socket () using IPv6
2021-07-08T08:57:06.36069 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [1] setsockopt ()
2021-07-08T08:57:06.36070 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [1] bind () to port 6566
2021-07-08T08:57:06.36072 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [1] listen ()
2021-07-08T08:57:06.36076 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [0] socket () using IPv4
2021-07-08T08:57:06.36077 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [0] setsockopt ()
2021-07-08T08:57:06.36079 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [0] bind () to port 6566
2021-07-08T08:57:06.36080 daemon.debug: Jul 8 18:57:06 saned[1428]: do_bindings: [0] bind failed: Address already in use
2021-07-08T08:57:06.36083 daemon.debug: Jul 8 18:57:06 saned[1428]: Dropped privileges to uid 993 gid 990
2021-07-08T08:57:06.36084 daemon.debug: Jul 8 18:57:06 saned[1428]: run_standalone: spawning Avahi process
2021-07-08T08:57:06.36101 daemon.debug: Jul 8 18:57:06 saned[1428]: run_standalone: waiting for control connection
2021-07-08T08:57:06.36204 daemon.debug: Jul 8 18:57:06 saned[1429]: saned_avahi_callback: AVAHI_CLIENT_CONNECTING
```
The second process is related to Avahi functionality. `sv` will stop the main process (pid 1428) but the second process remains. This doesn’t occur when SANE is built without Avahi support. This is why I made Avahi support optional.
I don't know how to properly fix this other than to have a `./finish` script clean up any lingering `saned` processes, but I’m not sure how safe that is. If there is no acceptable solution I can drop the runit service from this PR.
next prev parent reply other threads:[~2021-10-28 4:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 9:45 [PR PATCH] sane: update to 1.0.32, " amak79
2021-07-08 10:07 ` [PR PATCH] [Updated] " amak79
2021-07-08 11:24 ` amak79
2021-07-09 20:47 ` [PR REVIEW] " Piraty
2021-07-09 20:54 ` Piraty
2021-07-10 0:45 ` [PR PATCH] [Updated] " amak79
2021-07-14 5:30 ` amak79
2021-07-17 4:04 ` ericonr
2021-07-17 7:29 ` amak79
2021-07-18 2:38 ` [PR PATCH] [Updated] " amak79
2021-07-20 19:20 ` [PR REVIEW] " ericonr
2021-07-20 19:20 ` ericonr
2021-07-21 0:56 ` [PR PATCH] [Updated] " amak79
2021-07-21 21:27 ` ericonr
2021-07-22 3:36 ` amak79
2021-07-22 18:53 ` ericonr
2021-07-23 1:58 ` [PR PATCH] [Updated] " amak79
2021-07-23 2:06 ` amak79
2021-07-23 13:13 ` [PR PATCH] [Updated] " amak79
2021-08-13 2:27 ` amak79
2021-08-13 2:29 ` amak79
2021-08-24 8:01 ` [PR PATCH] [Updated] " amak79
2021-10-26 9:49 ` amak79
2021-10-28 4:20 ` ericonr [this message]
2021-10-28 4:20 ` sane: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028042031.LrPN3K9pdWoN-VKAh6qAOjXukMUXfSCaJXz82kQD7SI@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).