Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-jellyfish: Update to 0.8.8
@ 2021-10-21  3:59 vpzomtrrfrt
  2021-10-21  4:19 ` [PR PATCH] [Updated] " vpzomtrrfrt
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: vpzomtrrfrt @ 2021-10-21  3:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is a new pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages jellyfish-0.8.8
https://github.com/void-linux/void-packages/pull/33667

python3-jellyfish: Update to 0.8.8
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33667.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jellyfish-0.8.8-33667.patch --]
[-- Type: text/x-diff, Size: 1436 bytes --]

From 3f5eaa7970d7b6c6abff6b3b2cd7037fcf389ab0 Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Wed, 20 Oct 2021 21:57:17 -0600
Subject: [PATCH] python3-jellyfish: Update to 0.8.8

---
 srcpkgs/python3-jellyfish/template | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-jellyfish/template b/srcpkgs/python3-jellyfish/template
index c1b55e36e8ef..edecbfc52131 100644
--- a/srcpkgs/python3-jellyfish/template
+++ b/srcpkgs/python3-jellyfish/template
@@ -1,19 +1,25 @@
 # Template file for 'python3-jellyfish'
 pkgname=python3-jellyfish
-version=0.7.2
-revision=4
+version=0.8.8
+revision=1
 wrksrc="jellyfish-${version}"
 build_style=python3-module
 pycompile_module="jellyfish"
 hostmakedepends=" python3-setuptools"
 makedepends="python3-devel"
+checkdepends="python3-pytest"
 short_desc="Python3 library for approximate and phonetic matching of strings"
 maintainer="Duncaen <duncaen@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://github.com/sunlightlabs/jellyfish"
 distfiles="${PYPI_SITE}/j/jellyfish/jellyfish-${version}.tar.gz"
-checksum=cb09c50d7e2bb7b926fc7654762bc81f9c629e0c92ae7137bf22b34f39515286
+checksum=0506089cacf9b5897442134417b04b3c6610c19f280ae535eace390dc6325a5c
 
 post_install() {
 	vlicense LICENSE
 }
+
+do_check() {
+	build_loc=$(compgen -G build/lib.linux-*)
+	PYTHONPATH="${build_loc}" pytest "${build_loc}/jellyfish/test.py"
+}

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
@ 2021-10-21  4:19 ` vpzomtrrfrt
  2021-10-22 20:54 ` paper42
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: vpzomtrrfrt @ 2021-10-21  4:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages jellyfish-0.8.8
https://github.com/void-linux/void-packages/pull/33667

python3-jellyfish: Update to 0.8.8
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33667.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jellyfish-0.8.8-33667.patch --]
[-- Type: text/x-diff, Size: 1437 bytes --]

From 8fce32e008d13709452e45c517016d467bb0a840 Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Wed, 20 Oct 2021 21:57:17 -0600
Subject: [PATCH] python3-jellyfish: Update to 0.8.8

---
 srcpkgs/python3-jellyfish/template | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-jellyfish/template b/srcpkgs/python3-jellyfish/template
index c1b55e36e8ef..7e66ca4e9478 100644
--- a/srcpkgs/python3-jellyfish/template
+++ b/srcpkgs/python3-jellyfish/template
@@ -1,19 +1,24 @@
 # Template file for 'python3-jellyfish'
 pkgname=python3-jellyfish
-version=0.7.2
-revision=4
+version=0.8.8
+revision=1
 wrksrc="jellyfish-${version}"
 build_style=python3-module
-pycompile_module="jellyfish"
 hostmakedepends=" python3-setuptools"
 makedepends="python3-devel"
+checkdepends="python3-pytest"
 short_desc="Python3 library for approximate and phonetic matching of strings"
 maintainer="Duncaen <duncaen@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://github.com/sunlightlabs/jellyfish"
 distfiles="${PYPI_SITE}/j/jellyfish/jellyfish-${version}.tar.gz"
-checksum=cb09c50d7e2bb7b926fc7654762bc81f9c629e0c92ae7137bf22b34f39515286
+checksum=0506089cacf9b5897442134417b04b3c6610c19f280ae535eace390dc6325a5c
 
 post_install() {
 	vlicense LICENSE
 }
+
+do_check() {
+	build_loc=$(compgen -G build/lib.linux-*)
+	PYTHONPATH="${build_loc}" pytest "${build_loc}/jellyfish/test.py"
+}

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
  2021-10-21  4:19 ` [PR PATCH] [Updated] " vpzomtrrfrt
@ 2021-10-22 20:54 ` paper42
  2021-10-22 21:08 ` [PR REVIEW] " paper42
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2021-10-22 20:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33667#issuecomment-949953693

Comment:
Did you test this update with beets 1.4.9?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
  2021-10-21  4:19 ` [PR PATCH] [Updated] " vpzomtrrfrt
  2021-10-22 20:54 ` paper42
@ 2021-10-22 21:08 ` paper42
  2021-10-22 21:12 ` vpzomtrrfrt
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2021-10-22 21:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33667#discussion_r734844292

Comment:
```suggestion
make_check_target=build/lib.*/jellyfish/test.py
```

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
                   ` (2 preceding siblings ...)
  2021-10-22 21:08 ` [PR REVIEW] " paper42
@ 2021-10-22 21:12 ` vpzomtrrfrt
  2021-10-22 21:16 ` [PR PATCH] [Updated] " vpzomtrrfrt
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: vpzomtrrfrt @ 2021-10-22 21:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by vpzomtrrfrt on void-packages repository

https://github.com/void-linux/void-packages/pull/33667#issuecomment-949962259

Comment:
> Did you test this update with beets 1.4.9?

I hadn't but it seems to work

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
                   ` (3 preceding siblings ...)
  2021-10-22 21:12 ` vpzomtrrfrt
@ 2021-10-22 21:16 ` vpzomtrrfrt
  2021-10-22 21:17 ` vpzomtrrfrt
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: vpzomtrrfrt @ 2021-10-22 21:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages jellyfish-0.8.8
https://github.com/void-linux/void-packages/pull/33667

python3-jellyfish: Update to 0.8.8
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33667.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jellyfish-0.8.8-33667.patch --]
[-- Type: text/x-diff, Size: 1347 bytes --]

From 670faf4faac9df07a889116b3f6876a5905493a7 Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Wed, 20 Oct 2021 21:57:17 -0600
Subject: [PATCH] python3-jellyfish: Update to 0.8.8

---
 srcpkgs/python3-jellyfish/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-jellyfish/template b/srcpkgs/python3-jellyfish/template
index c1b55e36e8ef..7edad1557692 100644
--- a/srcpkgs/python3-jellyfish/template
+++ b/srcpkgs/python3-jellyfish/template
@@ -1,18 +1,19 @@
 # Template file for 'python3-jellyfish'
 pkgname=python3-jellyfish
-version=0.7.2
-revision=4
+version=0.8.8
+revision=1
 wrksrc="jellyfish-${version}"
 build_style=python3-module
-pycompile_module="jellyfish"
 hostmakedepends=" python3-setuptools"
 makedepends="python3-devel"
+checkdepends="python3-pytest"
 short_desc="Python3 library for approximate and phonetic matching of strings"
 maintainer="Duncaen <duncaen@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://github.com/sunlightlabs/jellyfish"
 distfiles="${PYPI_SITE}/j/jellyfish/jellyfish-${version}.tar.gz"
-checksum=cb09c50d7e2bb7b926fc7654762bc81f9c629e0c92ae7137bf22b34f39515286
+checksum=0506089cacf9b5897442134417b04b3c6610c19f280ae535eace390dc6325a5c
+make_check_target=build/lib.*/jellyfish/test.py
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
                   ` (4 preceding siblings ...)
  2021-10-22 21:16 ` [PR PATCH] [Updated] " vpzomtrrfrt
@ 2021-10-22 21:17 ` vpzomtrrfrt
  2021-10-26  1:02 ` Goorzhel
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: vpzomtrrfrt @ 2021-10-22 21:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages jellyfish-0.8.8
https://github.com/void-linux/void-packages/pull/33667

python3-jellyfish: Update to 0.8.8
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33667.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jellyfish-0.8.8-33667.patch --]
[-- Type: text/x-diff, Size: 1347 bytes --]

From 29c7e8244dcddbab1314ff4fc8da298057449992 Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Wed, 20 Oct 2021 21:57:17 -0600
Subject: [PATCH] python3-jellyfish: Update to 0.8.8

---
 srcpkgs/python3-jellyfish/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-jellyfish/template b/srcpkgs/python3-jellyfish/template
index c1b55e36e8ef..61a15e15e861 100644
--- a/srcpkgs/python3-jellyfish/template
+++ b/srcpkgs/python3-jellyfish/template
@@ -1,18 +1,19 @@
 # Template file for 'python3-jellyfish'
 pkgname=python3-jellyfish
-version=0.7.2
-revision=4
+version=0.8.8
+revision=1
 wrksrc="jellyfish-${version}"
 build_style=python3-module
-pycompile_module="jellyfish"
+make_check_target=build/lib.*/jellyfish/test.py
 hostmakedepends=" python3-setuptools"
 makedepends="python3-devel"
+checkdepends="python3-pytest"
 short_desc="Python3 library for approximate and phonetic matching of strings"
 maintainer="Duncaen <duncaen@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://github.com/sunlightlabs/jellyfish"
 distfiles="${PYPI_SITE}/j/jellyfish/jellyfish-${version}.tar.gz"
-checksum=cb09c50d7e2bb7b926fc7654762bc81f9c629e0c92ae7137bf22b34f39515286
+checksum=0506089cacf9b5897442134417b04b3c6610c19f280ae535eace390dc6325a5c
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
                   ` (5 preceding siblings ...)
  2021-10-22 21:17 ` vpzomtrrfrt
@ 2021-10-26  1:02 ` Goorzhel
  2021-10-26  1:02 ` Goorzhel
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Goorzhel @ 2021-10-26  1:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2956 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/33667#issuecomment-951461611

Comment:
@vpzomtrrfrt , @paper42: I just did, and can confirm this fixes `beet`. Previously, it was throwing:

<details>
<summary>TypeError: str argument expected</summary>

```
$ beet im .
Traceback (most recent call last):
  File "/usr/bin/beet", line 33, in <module>
    sys.exit(load_entry_point('beets==1.4.9', 'console_scripts', 'beet')())
  File "/usr/lib/python3.10/site-packages/beets/ui/__init__.py", line 1266, in main
    _raw_main(args)
  File "/usr/lib/python3.10/site-packages/beets/ui/__init__.py", line 1253, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/usr/lib/python3.10/site-packages/beets/ui/commands.py", line 955, in import_func
    import_files(lib, paths, query)
  File "/usr/lib/python3.10/site-packages/beets/ui/commands.py", line 925, in import_files
    session.run()
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 329, in run
    pl.run_parallel(QUEUE_SIZE)
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 445, in run_parallel
    six.reraise(exc_info[0], exc_info[1], exc_info[2])
  File "/usr/lib/python3.10/site-packages/six.py", line 719, in reraise
    raise value
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 312, in run
    out = self.coro.send(msg)
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 194, in coro
    func(*(args + (task,)))
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 1351, in lookup_candidates
    task.lookup_candidates()
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 641, in lookup_candidates
    autotag.tag_album(self.items, search_ids=self.search_ids)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 461, in tag_album
    _add_candidate(items, candidates, matched_candidate)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 374, in _add_candidate
    mapping, extra_items, extra_tracks = assign_items(items, info.tracks)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 102, in assign_items
    row.append(track_distance(item, track))
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 141, in track_distance
    dist.add_string('track_title', item.title, track_info.title)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 533, in add_string
    dist = string_dist(str1, str2)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 275, in string_dist
    base_dist = _string_dist_basic(str1, str2)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 241, in _string_dist_basic
    return levenshtein_distance(str1, str2) / float(max(len(str1), len(str2)))
TypeError: str argument expected
```
</details>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
                   ` (6 preceding siblings ...)
  2021-10-26  1:02 ` Goorzhel
@ 2021-10-26  1:02 ` Goorzhel
  2021-10-26  1:03 ` Goorzhel
  2021-10-28 22:28 ` [PR PATCH] [Merged]: " paper42
  9 siblings, 0 replies; 11+ messages in thread
From: Goorzhel @ 2021-10-26  1:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2966 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/33667#issuecomment-951461611

Comment:
@vpzomtrrfrt , @paper42: I just did, and can confirm this fixes `beet (at 1.4.9). Previously, it was throwing:

<details>
<summary>TypeError: str argument expected</summary>

```
$ beet im .
Traceback (most recent call last):
  File "/usr/bin/beet", line 33, in <module>
    sys.exit(load_entry_point('beets==1.4.9', 'console_scripts', 'beet')())
  File "/usr/lib/python3.10/site-packages/beets/ui/__init__.py", line 1266, in main
    _raw_main(args)
  File "/usr/lib/python3.10/site-packages/beets/ui/__init__.py", line 1253, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/usr/lib/python3.10/site-packages/beets/ui/commands.py", line 955, in import_func
    import_files(lib, paths, query)
  File "/usr/lib/python3.10/site-packages/beets/ui/commands.py", line 925, in import_files
    session.run()
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 329, in run
    pl.run_parallel(QUEUE_SIZE)
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 445, in run_parallel
    six.reraise(exc_info[0], exc_info[1], exc_info[2])
  File "/usr/lib/python3.10/site-packages/six.py", line 719, in reraise
    raise value
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 312, in run
    out = self.coro.send(msg)
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 194, in coro
    func(*(args + (task,)))
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 1351, in lookup_candidates
    task.lookup_candidates()
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 641, in lookup_candidates
    autotag.tag_album(self.items, search_ids=self.search_ids)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 461, in tag_album
    _add_candidate(items, candidates, matched_candidate)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 374, in _add_candidate
    mapping, extra_items, extra_tracks = assign_items(items, info.tracks)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 102, in assign_items
    row.append(track_distance(item, track))
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 141, in track_distance
    dist.add_string('track_title', item.title, track_info.title)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 533, in add_string
    dist = string_dist(str1, str2)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 275, in string_dist
    base_dist = _string_dist_basic(str1, str2)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 241, in _string_dist_basic
    return levenshtein_distance(str1, str2) / float(max(len(str1), len(str2)))
TypeError: str argument expected
```
</details>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
                   ` (7 preceding siblings ...)
  2021-10-26  1:02 ` Goorzhel
@ 2021-10-26  1:03 ` Goorzhel
  2021-10-28 22:28 ` [PR PATCH] [Merged]: " paper42
  9 siblings, 0 replies; 11+ messages in thread
From: Goorzhel @ 2021-10-26  1:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2967 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/33667#issuecomment-951461611

Comment:
@vpzomtrrfrt , @paper42: I just did, and can confirm this fixes `beet` (at 1.4.9). Previously, it was throwing:

<details>
<summary>TypeError: str argument expected</summary>

```
$ beet im .
Traceback (most recent call last):
  File "/usr/bin/beet", line 33, in <module>
    sys.exit(load_entry_point('beets==1.4.9', 'console_scripts', 'beet')())
  File "/usr/lib/python3.10/site-packages/beets/ui/__init__.py", line 1266, in main
    _raw_main(args)
  File "/usr/lib/python3.10/site-packages/beets/ui/__init__.py", line 1253, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/usr/lib/python3.10/site-packages/beets/ui/commands.py", line 955, in import_func
    import_files(lib, paths, query)
  File "/usr/lib/python3.10/site-packages/beets/ui/commands.py", line 925, in import_files
    session.run()
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 329, in run
    pl.run_parallel(QUEUE_SIZE)
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 445, in run_parallel
    six.reraise(exc_info[0], exc_info[1], exc_info[2])
  File "/usr/lib/python3.10/site-packages/six.py", line 719, in reraise
    raise value
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 312, in run
    out = self.coro.send(msg)
  File "/usr/lib/python3.10/site-packages/beets/util/pipeline.py", line 194, in coro
    func(*(args + (task,)))
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 1351, in lookup_candidates
    task.lookup_candidates()
  File "/usr/lib/python3.10/site-packages/beets/importer.py", line 641, in lookup_candidates
    autotag.tag_album(self.items, search_ids=self.search_ids)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 461, in tag_album
    _add_candidate(items, candidates, matched_candidate)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 374, in _add_candidate
    mapping, extra_items, extra_tracks = assign_items(items, info.tracks)
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 102, in assign_items
    row.append(track_distance(item, track))
  File "/usr/lib/python3.10/site-packages/beets/autotag/match.py", line 141, in track_distance
    dist.add_string('track_title', item.title, track_info.title)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 533, in add_string
    dist = string_dist(str1, str2)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 275, in string_dist
    base_dist = _string_dist_basic(str1, str2)
  File "/usr/lib/python3.10/site-packages/beets/autotag/hooks.py", line 241, in _string_dist_basic
    return levenshtein_distance(str1, str2) / float(max(len(str1), len(str2)))
TypeError: str argument expected
```
</details>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Merged]: python3-jellyfish: Update to 0.8.8
  2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
                   ` (8 preceding siblings ...)
  2021-10-26  1:03 ` Goorzhel
@ 2021-10-28 22:28 ` paper42
  9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2021-10-28 22:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

There's a merged pull request on the void-packages repository

python3-jellyfish: Update to 0.8.8
https://github.com/void-linux/void-packages/pull/33667

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-10-28 22:28 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21  3:59 [PR PATCH] python3-jellyfish: Update to 0.8.8 vpzomtrrfrt
2021-10-21  4:19 ` [PR PATCH] [Updated] " vpzomtrrfrt
2021-10-22 20:54 ` paper42
2021-10-22 21:08 ` [PR REVIEW] " paper42
2021-10-22 21:12 ` vpzomtrrfrt
2021-10-22 21:16 ` [PR PATCH] [Updated] " vpzomtrrfrt
2021-10-22 21:17 ` vpzomtrrfrt
2021-10-26  1:02 ` Goorzhel
2021-10-26  1:02 ` Goorzhel
2021-10-26  1:03 ` Goorzhel
2021-10-28 22:28 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).