From: jhe2 <jhe2@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] avidemux: update to 2.7.8.
Date: Fri, 29 Oct 2021 09:07:39 +0200 [thread overview]
Message-ID: <20211029070739.BU1Tm3Az1uNxVZhI4ah5sUsPD15jC3RGk9wcfUPzUH0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33783@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
New review comment by jhe2 on void-packages repository
https://github.com/void-linux/void-packages/pull/33783#discussion_r738983622
Comment:
You are right, ``-fno-PIC`` is enough. I first added the more obvious ``-fomit-frame-pointer`` and after that was not enough, I added the ``-fno-PIC`` flag, so I didn't notice. I've updated the pull request accordingly.
next prev parent reply other threads:[~2021-10-29 7:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 8:35 [PR PATCH] " jhe2
2021-10-27 20:19 ` dmarto
2021-10-27 20:20 ` dmarto
2021-10-28 7:26 ` [PR PATCH] [Updated] " jhe2
2021-10-28 7:28 ` jhe2
2021-10-29 4:08 ` [PR REVIEW] " ericonr
2021-10-29 7:06 ` [PR PATCH] [Updated] " jhe2
2021-10-29 7:07 ` jhe2 [this message]
2021-10-29 7:09 ` jhe2
2021-10-29 11:12 ` dmarto
2021-10-30 18:13 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029070739.BU1Tm3Az1uNxVZhI4ah5sUsPD15jC3RGk9wcfUPzUH0@z \
--to=jhe2@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).