From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] common/lint-commits: catch non-conventional subject
Date: Fri, 29 Oct 2021 21:23:37 +0200 [thread overview]
Message-ID: <20211029192337.MhzhU7S_TcikCid5wgqMm02nLJzA2NNjDH57VOP__l4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33768@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
There is an updated pull request by Chocimier against master on the void-packages repository
https://github.com/Chocimier/void-packages-org subject
https://github.com/void-linux/void-packages/pull/33768
common/lint-commits: catch non-conventional subject
None
A patch file from https://github.com/void-linux/void-packages/pull/33768.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-subject-33768.patch --]
[-- Type: text/x-diff, Size: 932 bytes --]
From 11360d0216c724040a95c0a4f9b7662e422bafb9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Tue, 26 Oct 2021 20:32:34 +0200
Subject: [PATCH] common/lint-commits: catch non-conventional subject
---
common/scripts/lint-commits | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/scripts/lint-commits b/common/scripts/lint-commits
index 785bf0ef1d0d..65f584f5f84e 100755
--- a/common/scripts/lint-commits
+++ b/common/scripts/lint-commits
@@ -38,6 +38,7 @@ do
(NF > 2) && (length > 80) { print C ": long line: " $0; exit 1 }
!subject {
if (length > 50) { print C ": subject is a bit long" }
+ if (!($0 ~ ":" || $0 ~ "^Take over maintainership " || $0 ~ "^Orphan ")) { print C ": subject does not follow CONTRIBUTING.md guildelines" }
# Below check is too noisy?
# if (!($0 ~ "^New package:" || $0 ~ ".*: update to")) {
# print C ": not new package/update/removal?"
next prev parent reply other threads:[~2021-10-29 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 18:35 [PR PATCH] " Chocimier
2021-10-29 19:23 ` Chocimier [this message]
2021-10-29 19:24 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029192337.MhzhU7S_TcikCid5wgqMm02nLJzA2NNjDH57VOP__l4@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).