Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: nvimpager: update to 0.10.3
Date: Sat, 30 Oct 2021 20:06:04 +0200	[thread overview]
Message-ID: <20211030180604.BNNWudalsTyQhSAy9xtBJnvzcbkIMm6hA54-E8ESVpg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33805@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33805#issuecomment-955571169

Comment:
> Besides updating to 0.10.3, this fixes a problem that occurred for me recently (probably from the 0.10.2 update): the script is configured via the makefile, inserting the PREFIX to pass the right paths to nvim. But the gnu-makefile build style only passes PREFIX during do_install, not during do_build. As the first non-wildcard target in the makefile is install, I just skipped do_build.

This explanation can be included in the commit message, and it'd be of great help there.

Adding a comment to template saying `# nothing to build` is also friendly :)

  reply	other threads:[~2021-10-30 18:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 10:32 [PR PATCH] " crater2150
2021-10-30 18:06 ` ericonr [this message]
2021-10-31 18:50 ` [PR PATCH] [Updated] " crater2150
2021-10-31 18:51 ` crater2150
2021-10-31 21:18 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211030180604.BNNWudalsTyQhSAy9xtBJnvzcbkIMm6hA54-E8ESVpg@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).