[PR PATCH] New package: lsp-plugins-1.1.30

[PR PATCH] New package: lsp-plugins-1.1.30

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]

There is a new pull request by lemmi against master on the void-packages repository

https://github.com/lemmi/void-packages lsp-plugins
https://github.com/void-linux/void-packages/pull/33672

New package: lsp-plugins-1.1.30
Required for the EQ with easyeffects to work 

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/33672.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsp-plugins-33672.patch --]
[-- Type: text/x-diff, Size: 1163 bytes --]

From 3fd662a1130184dd5f7b5c905519c85f0726ffd6 Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Thu, 21 Oct 2021 17:10:56 +0200
Subject: [PATCH] New package: lsp-plugins-1.1.30

---
 srcpkgs/lsp-plugins/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/lsp-plugins/template

diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
new file mode 100644
index 000000000000..8ddb1f3449c8
--- /dev/null
+++ b/srcpkgs/lsp-plugins/template
@@ -0,0 +1,16 @@
+# Template file for 'lsp-plugins'
+pkgname=lsp-plugins
+version=1.1.30
+revision=1
+build_style=gnu-makefile
+make_build_args="BUILD_MODULES=lv2"
+CXXFLAGS="-std=c++98"
+hostmakedepends="pkg-config"
+makedepends="lv2 jack-devel libX11-devel cairo-devel libsndfile-devel"
+short_desc="Linux Studio Plugins - LV2 plugins"
+maintainer="lemmi <lemmi@nerd2nerd.org>"
+license="LGPL-3"
+homepage="https://lsp-plug.in"
+changelog="https://github.com/sadko4u/lsp-plugins/releases"
+distfiles="https://github.com/sadko4u/lsp-plugins/archive/refs/tags/${version}.tar.gz"
+checksum=9cf43257729093c240375b3640b1514dff34b092b83b54a5ee68d7e8565c8f80

Re: New package: lsp-plugins-1.1.30

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/33672#issuecomment-957451211

Comment:
there has been some work 👉 #31664 and #29932

Re: New package: lsp-plugins-1.1.30

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/33672#issuecomment-1150594234

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: lsp-plugins-1.1.30

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a closed pull request on the void-packages repository

New package: lsp-plugins-1.1.30
https://github.com/void-linux/void-packages/pull/33672

Description:
Required for the EQ with easyeffects to work 

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-1095045079

Comment:
Unfortunately, I have no time to work on it now.

Re: New package: lsp-plugins-1.1.30

[prez]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-1095037938

Comment:
1.2.0 is out, with a different build process and including the patches for musl. 
Are you going to update your PR or do you want me to take a stab at it?

Re: New package: lsp-plugins-1.1.30

[paper42]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#issuecomment-1082357531

Comment:
outdated and superseded by 3 other PRs

Re: New package: lsp-plugins-1.1.30

[sgn]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-890436339

Comment:
> > We are not Debian, and they have been building on arm* natively for a while. I look forward to us getting there, but we are not there now.
> 
> They even have it for `mipsel`. Do they really build Debian packages on something like a Wi-Fi router? Funny

They build it semi-natively by qemu-user

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-890407423

Comment:
> This will still need to be fixed, we do have conventions and standards.

Would be nice to make `xlint` check for 80 columns limit.

> You're the one requesting this package be included... that means you figure it out. We can help, but your attitude isn't helping us help.

Today I've read a bit more about exporting variables into nested `make` invocations. Hopefully it'll help to finally fix cross builds.

> We are not Debian, and they have been building on arm* natively for a while. I look forward to us getting there, but we are not there now.

They even have it for `mipsel`. Do they really build Debian packages on something like a Wi-Fi router? Funny

Re: New package: lsp-plugins-1.1.30

[abenson]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-890406351

Comment:
> instead of nitpicking something minor like 80 columns limit

This will still need to be fixed, we do have conventions and standards.

> please figure out how to compile src/utils for host architecture

You're the one requesting this package be included... that means you figure it out.  We can help, but your attitude isn't helping us help.

>  Debian has this package for many archs

We are not Debian, and they have been building on arm* natively for a while.  I look forward to us getting there, but we are not there now.

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-890327731

Comment:
@paper42 if you really want to help with this PR then instead of nitpicking something minor like 80 columns limit please figure out how to compile `src/utils` for **host** architecture, then run those utils to do some code generation and then compile everything for **target** architecture. This projects' build system consists of many Makefiles which are not aware of cross compilation at all. So now I'm working on a patch for upstream to make it aware of cross compilation. I'll create a PR at upstream when this patch finally will work.

Debian has this package for many archs: https://packages.debian.org/sid/lsp-plugins, but I don't know how they managed to do that. Maybe they compiled it on those archs as hosts (without cross compiling)?

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-890327731

Comment:
@paper42 if you really want to help with this PR then instead of nitpicking something minor like 80 columns limit please figure out how to compile `src/utils` for **host** architecture, then run those utils to do some code generation and then compile everything for **target** architecture. This projects' build system consists of many Makefiles which are not aware of cross compilation at all. So now I'm working on a patch for upstream to make it aware of cross compilation.

Debian has this package for many archs: https://packages.debian.org/sid/lsp-plugins, but I don't know how they managed to do that. Maybe they compiled it on those archs as hosts (without cross compiling)?

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-890327731

Comment:
@paper42 if you really want to help with this PR then instead of nitpicking something minor like 80 columns limit please figure out how to compile `src/utils` for **host** architecture, then run those utils to do some code generation and then compile everything for `target` architecture. This projects' build system consists of many Makefiles which are not aware of cross compilation at all. So now I'm working on a patch for upstream to make it aware of cross compilation.

Debian has this package for many archs: https://packages.debian.org/sid/lsp-plugins, but I don't know how they managed to do that. Maybe they compiled it on those archs as hosts (without cross compiling)?

Re: New package: lsp-plugins-1.1.30

[paper42]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-888602526

Comment:
> @paper42 BTW, will this package be still useful for `easyeffects`?

yes, nothing changes on that front

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-888589439

Comment:
@paper42 BTW, will this package be still useful for `easyeffects`?

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-888589439

Comment:
@paper42 BTW, will this package be still usefull for `easyeffects`?

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-888586655

Comment:
> please remove the parallel tests commit from this PR, it is confusing for reviewers

I'll remove it when I get all the archs working, it's very useful for me now.

Re: New package: lsp-plugins-1.1.30

[paper42]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31664#issuecomment-888585700

Comment:
please remove the parallel tests commit from this PR, it is confusing for reviewers

Re: New package: lsp-plugins-1.1.30

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#issuecomment-869016942

Comment:
@paper42 seems this PR haven't been active for a while, so I decided to create another one based on your work: https://github.com/void-linux/void-packages/pull/31663