Re: [PR PATCH] [Updated] ulogd: move logs to subdir, update logrotate file, add conf_files

[amak79 <amak79@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

There is an updated pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages ulogd
https://github.com/void-linux/void-packages/pull/33847

ulogd: move logs to subdir, update logrotate file, add conf_files
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

The logrotate file is configured to rotate `/var/log/ulog.log` and `/var/log/ulog.pcap`, but the default `/etc/ulogd.conf` is configured for `/var/log/ulogd.log` and `/var/log/ulogd.pcap` so nothing will get rotated.

A patch file from https://github.com/void-linux/void-packages/pull/33847.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ulogd-33847.patch --]
[-- Type: text/x-diff, Size: 1791 bytes --]

From 406f43d37b1a6bf9f68ece7d4c3143b7afc1db90 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 31 Oct 2021 23:27:44 +1100
Subject: [PATCH] ulogd: move logs to subdir, update logrotate file, add
 conf_files

---
 srcpkgs/ulogd/files/ulogd.logrotate | 6 +++---
 srcpkgs/ulogd/template              | 8 ++++++--
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/ulogd/files/ulogd.logrotate b/srcpkgs/ulogd/files/ulogd.logrotate
index c50479d92cfb..186a95eb42a3 100644
--- a/srcpkgs/ulogd/files/ulogd.logrotate
+++ b/srcpkgs/ulogd/files/ulogd.logrotate
@@ -1,8 +1,8 @@
-/var/log/ulog.log /var/log/ulog.pcap {
-    missingok
+/var/log/ulogd/*.log /var/log/ulogd/*.pcap {
     compress
+    missingok
+    notifempty
     sharedscripts
-    create 640 _ulogd adm
     postrotate
 	sv hup ulogd
     endscript
diff --git a/srcpkgs/ulogd/template b/srcpkgs/ulogd/template
index 55e9ae34a0e1..633a78c2cfd4 100644
--- a/srcpkgs/ulogd/template
+++ b/srcpkgs/ulogd/template
@@ -1,7 +1,7 @@
 # Template file for 'ulogd'
 pkgname=ulogd
 version=2.0.7
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="--sbindir=/usr/bin"
 hostmakedepends="pkg-config automake"
@@ -13,10 +13,14 @@ license="GPL-2.0-only"
 homepage="http://www.netfilter.org/projects/ulogd/"
 distfiles="${homepage}/files/${pkgname}-${version}.tar.bz2"
 checksum=990a05494d9c16029ba0a83f3b7294fc05c756546b8d60d1c1572dc25249a92b
-CFLAGS="-D_GNU_SOURCE"
+conf_files="/etc/ulogd.conf /etc/logrotate.d/ulogd"
+make_dirs="/var/log/ulogd 2750 root adm"
 system_accounts="_ulogd"
 
+CFLAGS="-D_GNU_SOURCE"
+
 post_install() {
+	vsed -i -e "s:/var/log:/var/log/ulogd:g" ulogd.conf
 	vinstall ulogd.conf 644 etc
 	vinstall ${FILESDIR}/ulogd.logrotate 644 etc/logrotate.d ulogd
 	vsv ulogd