Github messages for voidlinux
 help / color / mirror / Atom feed
From: foopub <foopub@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Fixing patch whitespace
Date: Fri, 05 Nov 2021 18:28:42 +0100	[thread overview]
Message-ID: <20211105172842.cULXz2bNv1Z_Xf2SshcJBYpMIpT6YPsFekWaOEzZYWA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33917@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

New comment by foopub on void-packages repository

https://github.com/void-linux/void-packages/issues/33917#issuecomment-962081798

Comment:
I actually get an error with the firefox-esr build, even tho there's no problem with the patching, so can't verify the build works: 

```
=> firefox-esr-78.14.0_1: running do_build ...
Traceback (most recent call last):
  File "/builddir/firefox-78.14.0/./mach", line 235, in <module>
    main(sys.argv[1:])
  File "/builddir/firefox-78.14.0/./mach", line 227, in main
    mach = get_mach()
  File "/builddir/firefox-78.14.0/./mach", line 209, in get_mach
    mach = check_and_get_mach(dir_path)
  File "/builddir/firefox-78.14.0/./mach", line 165, in check_and_get_mach
    return load_mach(dir_path, mach_path)
  File "/builddir/firefox-78.14.0/./mach", line 153, in load_mach
    return mach_bootstrap.bootstrap(dir_path)
  File "/builddir/firefox-78.14.0/build/mach_bootstrap.py", line 203, in bootstrap
    import mach.main
  File "/builddir/firefox-78.14.0/python/mach/mach/main.py", line 19, in <module>
    from collections import Iterable
ImportError: cannot import name 'Iterable' from 'collections' (/usr/lib/python3.10/collections/__init__.py)
=> ERROR: firefox-esr-78.14.0_1: do_build: './mach build' exited with 1
=> ERROR:   in do_build() at srcpkgs/firefox-esr/template:169
```

But `cat srcpkgs/firefox-esr/patches/* | grep py` shows no python files so so I guess this error isn't related to the patch? Is it safe check it off here? 



  reply	other threads:[~2021-11-05 17:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 17:25 [ISSUE] " foopub
2021-11-05 17:28 ` foopub [this message]
2021-11-05 17:47 ` q66
2021-11-05 17:47 ` q66
2021-11-05 21:04 ` paper42
2021-11-07 11:07 ` foopub
2021-11-07 17:26 ` paper42
2021-11-09  8:43 ` newbluemoon
2021-11-09 19:00 ` newbluemoon
2022-06-11  2:13 ` github-actions
2022-06-25  2:15 ` [ISSUE] [CLOSED] " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211105172842.cULXz2bNv1Z_Xf2SshcJBYpMIpT6YPsFekWaOEzZYWA@z \
    --to=foopub@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).