Github messages for voidlinux
 help / color / mirror / Atom feed
From: Goorzhel <Goorzhel@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: kodi: update to 19.3.
Date: Wed, 17 Nov 2021 00:52:22 +0100	[thread overview]
Message-ID: <20211116235222.rP7ydJdaGszVjlH67Q_qWEEOHWw-RJHH6FVi_augLW0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34083@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

New comment by Goorzhel on void-packages repository

https://github.com/void-linux/void-packages/pull/34083#issuecomment-968461434

Comment:
```cpp
  #if !defined(TARGET_POSIX) || defined(TARGET_DARWIN) || defined(TARGET_FREEBSD) || defined(TARGET_ANDROID) || !defined(__GLIBC__)
        *pos = pFile->GetPosition();
  #else
        pos->__pos = pFile->GetPosition();
  #endif
```

So, the first branch seems to treat `pos` as an integer (I think), or at least something that can be assigned an integer, but that's not the case in musl:
```cpp
  typedef union _G_fpos64_t {
          char __opaque[16];
          long long __lldata;
          double __align;
  } fpos_t;
```
And the other branch also won't work because there's no `__pos` member.

I dunno, I think I'm going to need someone that groks C++ to take a look at this, because I'm in over my head here.

EDIT: I had missed two crucial type-casting lines.

  parent reply	other threads:[~2021-11-16 23:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 22:09 [PR PATCH] " Goorzhel
2021-11-14 22:49 ` Goorzhel
2021-11-14 22:49 ` Goorzhel
2021-11-15  1:33 ` Goorzhel
2021-11-15  1:35 ` Goorzhel
2021-11-15  2:29 ` Goorzhel
2021-11-15  6:02 ` [PR PATCH] [Updated] " Goorzhel
2021-11-16 23:52 ` Goorzhel [this message]
2021-12-04  4:32 ` ericonr
2021-12-04  4:33 ` [PR PATCH] [Updated] " Goorzhel
2021-12-04  4:39 ` Goorzhel
2021-12-04  4:39 ` Goorzhel
2021-12-04  4:42 ` ericonr
2022-04-04 23:11 ` marmeladema
2022-04-05  0:03 ` the-maldridge
2022-04-05  0:03 ` [PR PATCH] [Closed]: " the-maldridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116235222.rP7ydJdaGszVjlH67Q_qWEEOHWw-RJHH6FVi_augLW0@z \
    --to=goorzhel@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).